[MediaWiki-commits] [Gerrit] mediawiki...LinkFilter[master]: Fix E_WARNING after moving a page under MW 1.28
Jack Phoenix has submitted this change and it was merged. Change subject: Fix E_WARNING after moving a page under MW 1.28 .. Fix E_WARNING after moving a page under MW 1.28 Warning: Parameter 3 to LinkFilterHooks::updateLinkFilter() expected to be a reference, value given in ..\includes\Hooks.php on line 195 I'm not sure why this fixes it, but it does... Change-Id: Ide975a042880d5d71e4f8dd4ad7d3420f74d676d --- M LinkFilterHooks.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jack Phoenix: Verified; Looks good to me, approved diff --git a/LinkFilterHooks.php b/LinkFilterHooks.php index 2f4cd11..96bea5b 100644 --- a/LinkFilterHooks.php +++ b/LinkFilterHooks.php @@ -18,7 +18,7 @@ * @param $newId Integer * @return Boolean: true */ - public static function updateLinkFilter( &$title, &$newTitle, &$user, $oldId, $newId ) { + public static function updateLinkFilter( &$title, &$newTitle, $user, $oldId, $newId ) { if ( $title->getNamespace() == NS_LINK ) { $dbw = wfGetDB( DB_MASTER ); $dbw->update( -- To view, visit https://gerrit.wikimedia.org/r/324330 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide975a042880d5d71e4f8dd4ad7d3420f74d676d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/LinkFilter Gerrit-Branch: master Gerrit-Owner: Jack PhoenixGerrit-Reviewer: Jack Phoenix ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...LinkFilter[master]: Fix E_WARNING after moving a page under MW 1.28
Jack Phoenix has uploaded a new change for review. https://gerrit.wikimedia.org/r/324330 Change subject: Fix E_WARNING after moving a page under MW 1.28 .. Fix E_WARNING after moving a page under MW 1.28 Warning: Parameter 3 to LinkFilterHooks::updateLinkFilter() expected to be a reference, value given in ..\includes\Hooks.php on line 195 I'm not sure why this fixes it, but it does... Change-Id: Ide975a042880d5d71e4f8dd4ad7d3420f74d676d --- M LinkFilterHooks.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LinkFilter refs/changes/30/324330/1 diff --git a/LinkFilterHooks.php b/LinkFilterHooks.php index 2f4cd11..96bea5b 100644 --- a/LinkFilterHooks.php +++ b/LinkFilterHooks.php @@ -18,7 +18,7 @@ * @param $newId Integer * @return Boolean: true */ - public static function updateLinkFilter( &$title, &$newTitle, &$user, $oldId, $newId ) { + public static function updateLinkFilter( &$title, &$newTitle, $user, $oldId, $newId ) { if ( $title->getNamespace() == NS_LINK ) { $dbw = wfGetDB( DB_MASTER ); $dbw->update( -- To view, visit https://gerrit.wikimedia.org/r/324330 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ide975a042880d5d71e4f8dd4ad7d3420f74d676d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/LinkFilter Gerrit-Branch: master Gerrit-Owner: Jack Phoenix___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits