[MediaWiki-commits] [Gerrit] mediawiki...LoginNotify[master]: Remove dead code and messages
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/362089 )
Change subject: Remove dead code and messages
..
Remove dead code and messages
Change-Id: Ifbbf6844648940357df41d6998453edfe113c9a8
---
M i18n/en.json
M i18n/qqq.json
M includes/Hooks.php
3 files changed, 0 insertions(+), 11 deletions(-)
Approvals:
MaxSem: Looks good to me, approved
jenkins-bot: Verified
diff --git a/i18n/en.json b/i18n/en.json
index 01273fb..fa43439 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -11,7 +11,6 @@
"echo-pref-tooltip-login-fail": "Notify me when there have been
multiple failed attempts to log in to my account.",
"echo-category-title-login-success": "Login from new computer",
"echo-pref-tooltip-login-success": "Notify me whenever somebody logs
into my account from a computer I have not used before.",
- "loginnotify-login-fail": "There have been several failed attempts to
log in to your account",
"loginnotify-primary-link": "Help",
"notification-loginnotify-login-fail-email-subject":
"{{PLURAL:$2|Failed attempt|Multiple failed attempts}} to log in to
{{SITENAME}} as $1",
"notification-loginnotify-login-success-email-subject": "Login to
{{SITENAME}} as $1 from a computer you have not recently used",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 981e129..3d7c89b 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -11,7 +11,6 @@
"echo-pref-tooltip-login-fail": "Help tooltip for
{{msg-mw|echo-category-title-login-fail}}",
"echo-category-title-login-success": "Label for 2 checkboxes in the
Notifications section of [[Special:Preferences]]. The checkbox controls if the
user receives notification on someone logging in to this account from a
computer that has not previously been used to log in by this user.",
"echo-pref-tooltip-login-success": "Help tooltip for
{{msg-mw|echo-category-title-login-success}}",
- "loginnotify-login-fail": "FIXME I have no idea where this message is
used.\n{{notranslate}}",
"loginnotify-primary-link": "Label for link to a help page about the
feature\n{{Identical|Help}}",
"notification-loginnotify-login-fail-email-subject": "Email subject
line for email notice that there have been failed login attempts for the user's
account. $1 is the user in question.",
"notification-loginnotify-login-success-email-subject": "Email subject
line for email notice that someone has logged in to the user's account from a
computer that has not previously been used. $1 is the user in question.",
diff --git a/includes/Hooks.php b/includes/Hooks.php
index 86d8794..82a9cce 100644
--- a/includes/Hooks.php
+++ b/includes/Hooks.php
@@ -50,14 +50,6 @@
'category' => 'login-fail',
'group' => 'negative',
'presentation-model' => PresentationModel::class,
- // fixme, what does this actually do?
- 'title-message' => 'loginnotify-login-fail',
- 'title-params' => [],
- // FIXME Should count be a parameter
- 'email-subject-params' => [ 'agent', 'count' ],
- 'email-body-batch-params' => [ 'agent', 'count' ],
- // FIXME is it ok not to set batch email messages, since
- // we have immediate flag?
'icon' => 'LoginNotify-user-avatar',
'immediate' => true,
];
@@ -80,7 +72,6 @@
];
$notifications['login-success'] = [
'category' => 'login-success',
- // FIXME title-message. What is its purpose??
] + $loginBase;
}
--
To view, visit https://gerrit.wikimedia.org/r/362089
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbbf6844648940357df41d6998453edfe113c9a8
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/LoginNotify
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen
Gerrit-Reviewer: Catrope
Gerrit-Reviewer: Mattflaschen
Gerrit-Reviewer: MaxSem
Gerrit-Reviewer: Niharika29
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...LoginNotify[master]: Remove dead code and messages
Mattflaschen has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/362089 )
Change subject: Remove dead code and messages
..
Remove dead code and messages
Change-Id: Ifbbf6844648940357df41d6998453edfe113c9a8
---
M i18n/en.json
M i18n/qqq.json
M includes/Hooks.php
3 files changed, 0 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LoginNotify
refs/changes/89/362089/1
diff --git a/i18n/en.json b/i18n/en.json
index 764c890..001ee86 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -11,7 +11,6 @@
"echo-pref-tooltip-login-fail": "Notify me when there have been
multiple failed attempts to log in to my account.",
"echo-category-title-login-success": "Login from new computer",
"echo-pref-tooltip-login-success": "Notify me whenever somebody logs
into my account from a computer I have not used before.",
- "loginnotify-login-fail": "There have been several failed attempts to
log in to your account",
"loginnotify-primary-link": "Help",
"notification-loginnotify-login-fail-email-subject":
"{{PLURAL:$2|Failed attempt|Multiple failed attempts}} to log in to
{{SITENAME}} as $1",
"notification-loginnotify-login-success-email-subject": "Login to
{{SITENAME}} as $1 from a computer you have not recently used",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 981e129..3d7c89b 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -11,7 +11,6 @@
"echo-pref-tooltip-login-fail": "Help tooltip for
{{msg-mw|echo-category-title-login-fail}}",
"echo-category-title-login-success": "Label for 2 checkboxes in the
Notifications section of [[Special:Preferences]]. The checkbox controls if the
user receives notification on someone logging in to this account from a
computer that has not previously been used to log in by this user.",
"echo-pref-tooltip-login-success": "Help tooltip for
{{msg-mw|echo-category-title-login-success}}",
- "loginnotify-login-fail": "FIXME I have no idea where this message is
used.\n{{notranslate}}",
"loginnotify-primary-link": "Label for link to a help page about the
feature\n{{Identical|Help}}",
"notification-loginnotify-login-fail-email-subject": "Email subject
line for email notice that there have been failed login attempts for the user's
account. $1 is the user in question.",
"notification-loginnotify-login-success-email-subject": "Email subject
line for email notice that someone has logged in to the user's account from a
computer that has not previously been used. $1 is the user in question.",
diff --git a/includes/Hooks.php b/includes/Hooks.php
index 86d8794..32c9e02 100644
--- a/includes/Hooks.php
+++ b/includes/Hooks.php
@@ -50,14 +50,6 @@
'category' => 'login-fail',
'group' => 'negative',
'presentation-model' => PresentationModel::class,
- // fixme, what does this actually do?
- 'title-message' => 'loginnotify-login-fail',
- 'title-params' => [],
- // FIXME Should count be a parameter
- 'email-subject-params' => [ 'agent', 'count' ],
- 'email-body-batch-params' => [ 'agent', 'count' ],
- // FIXME is it ok not to set batch email messages, since
- // we have immediate flag?
'icon' => 'LoginNotify-user-avatar',
'immediate' => true,
];
--
To view, visit https://gerrit.wikimedia.org/r/362089
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifbbf6844648940357df41d6998453edfe113c9a8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LoginNotify
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
