[MediaWiki-commits] [Gerrit] mediawiki...MassAction[master]: Internationalize hardcoded strings from View Task

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/395817 )

Change subject: Internationalize hardcoded strings from View Task
..


Internationalize hardcoded strings from View Task

Bug: T96418
Change-Id: I4129f57f465dc7fad40d8883e207b7456db3ddd7
---
M i18n/en.json
M i18n/qqq.json
M src/MassActionSpecialPage.php
3 files changed, 64 insertions(+), 25 deletions(-)

Approvals:
  Brian Wolff: Verified; Looks good to me, approved



diff --git a/i18n/en.json b/i18n/en.json
index 7b0ae63..1d7a682 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -27,5 +27,23 @@
"massaction-regexreplace-desc": "Performs a regex replace on the 
content using the pattern",
"massaction-titleregexmatcher-desc": "Matches pages with titles 
matching regex \"$1\"",
"massaction-titleregexmatcher-enabled": "Title regex matcher enabled?",
-   "massaction-titleregexmatcher-label": "Title regex"
+   "massaction-titleregexmatcher-label": "Title regex",
+   "massaction-task-id": "Task Id",
+   "massaction-view-task-submit": "View Task",
+   "massaction-view-task-title": "View Task",
+   "massaction-view-task-no-tasks": "No task exists with the id: $1",
+   "massaction-view-task-id": "Task $1",
+   "massaction-view-task-summary": "Summary: $1",
+   "massaction-view-task-user": "User: {{GENDER:$1|$1}}",
+   "massaction-view-task-target-type": "Target Type: $1",
+   "massaction-view-task-date-created": "Date Created: $1",
+   "massaction-view-task-state": "State: $1",
+   "massaction-view-task-actions": "{{PLURAL:$1|Action (1)|Actions ($1)}}",
+   "massaction-view-task-matchers": "{{PLURAL:$1|Matcher (1)|Matchers 
($1)}}",
+   "massaction-view-task-targets": "{{PLURAL:$1|Target (1)|Targets ($1)}}",
+   "massaction-view-task-save-all": "Save All",
+   "massaction-view-task-target-identifier": "Identifier",
+   "massaction-view-task-target-name": "Name",
+   "massaction-view-task-target-state": "State",
+   "massaction-view-task-target-save": "Save"
 }
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 856145a..53b2535 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -29,5 +29,23 @@
"massaction-regexreplace-desc": "Description for the action that 
replaces the following regex pattern",
"massaction-titleregexmatcher-desc": "Description for the matcher that 
matches the following regex pattern in titles. Parameters:\n* $1 - the regex 
pattern that is being matched",
"massaction-titleregexmatcher-enabled": "Label for whether or not the 
matcher for title regex is enabled",
-   "massaction-titleregexmatcher-label": "Label for the title regex 
matcher"
+   "massaction-titleregexmatcher-label": "Label for the title regex 
matcher",
+   "massaction-task-id": "Placeholder for task id",
+   "massaction-view-task-submit": "Text displayed in submit button",
+   "massaction-view-task-title": "Title for page displaing tasks",
+   "massaction-view-task-no-tasks": "Text displayed when no tasks can be 
displayed for given id. Parameters:\n* $1 - given task id",
+   "massaction-view-task-id": "Title for page displaying task with given 
id. Parameters:\n* $1 - given task id",
+   "massaction-view-task-summary": "Text that shows summary of task. 
Parameters:\n* $1 - task summary",
+   "massaction-view-task-user": "Text that shows user of task. 
Parameters:\n* $1 - task user name",
+   "massaction-view-task-target-type": "Text that shows target type of 
task. Parameters:\n* $1 - task target type",
+   "massaction-view-task-date-created": "Text that shows creation date of 
task. Parameters:\n* $ - task creation date",
+   "massaction-view-task-state": "Text that shows state of task. 
Parameters:\n* $1 - task state",
+   "massaction-view-task-actions": "Title for actions with their count. 
Parameters:\n* $1 - actions count",
+   "massaction-view-task-matchers": "Title for matchers with their count. 
Parameters:\n* $1 - matchers count",
+   "massaction-view-task-targets": "Title for targets with their count. 
Parameters:\n* $1 - targets count",
+   "massaction-view-task-save-all": "Text that shows in submit button for 
saving all targets changes",
+   "massaction-view-task-target-identifier": "Text that shows in table 
heading for target identifier",
+   "massaction-view-task-target-name": "Text that shows in table heading 
for target name",
+   "massaction-view-task-target-state": "Text that shows in table heading 
for target state",
+   "massaction-view-task-target-save": "Text that shows in submit button 
for saving target changes"
 }
diff --git a/src/MassActionSpecialPage.php b/src/MassActionSpecialPage.php
index ece1dc1..51e650d 100644
--- a/src/MassActionSpecialPage.php
+++ b/src/MassActionSpecialPage.php
@@ -84,11 +84,11 @@
$formDescriptor 

[MediaWiki-commits] [Gerrit] mediawiki...MassAction[master]: Internationalize hardcoded strings from View Task

2017-12-06 Thread Albert221 (Code Review)
Albert221 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395817 )

Change subject: Internationalize hardcoded strings from View Task
..

Internationalize hardcoded strings from View Task

It's a part of T96418.

Change-Id: I4129f57f465dc7fad40d8883e207b7456db3ddd7
---
M i18n/en.json
M i18n/qqq.json
M src/MassActionSpecialPage.php
3 files changed, 65 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MassAction 
refs/changes/17/395817/1

diff --git a/i18n/en.json b/i18n/en.json
index 7b0ae63..be46c4a 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -27,5 +27,23 @@
"massaction-regexreplace-desc": "Performs a regex replace on the 
content using the pattern",
"massaction-titleregexmatcher-desc": "Matches pages with titles 
matching regex \"$1\"",
"massaction-titleregexmatcher-enabled": "Title regex matcher enabled?",
-   "massaction-titleregexmatcher-label": "Title regex"
+   "massaction-titleregexmatcher-label": "Title regex",
+   "massaction-task-id": "Task Id",
+   "massaction-view-task-submit": "View Task",
+   "massaction-view-task-title": "View Task",
+   "massaction-view-task-no-tasks": "No task exists with the id: $1",
+   "massaction-view-task-id": "Task $1",
+   "massaction-view-task-summary": "Summary: $1",
+   "massaction-view-task-user": "User: $1",
+   "massaction-view-task-target-type": "Target Type: $1",
+   "massaction-view-task-date-created": "Date Created: $1",
+   "massaction-view-task-state": "State: $1",
+   "massaction-view-task-actions": "Actions ($1)",
+   "massaction-view-task-matchers": "Matchers ($1)",
+   "massaction-view-task-targets": "Targets ($1)",
+   "massaction-view-task-save-all": "Save All",
+   "massaction-view-task-target-identifier": "Identifier",
+   "massaction-view-task-target-name": "Name",
+   "massaction-view-task-target-state": "State",
+   "massaction-view-task-target-save": "Save"
 }
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 856145a..53b2535 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -29,5 +29,23 @@
"massaction-regexreplace-desc": "Description for the action that 
replaces the following regex pattern",
"massaction-titleregexmatcher-desc": "Description for the matcher that 
matches the following regex pattern in titles. Parameters:\n* $1 - the regex 
pattern that is being matched",
"massaction-titleregexmatcher-enabled": "Label for whether or not the 
matcher for title regex is enabled",
-   "massaction-titleregexmatcher-label": "Label for the title regex 
matcher"
+   "massaction-titleregexmatcher-label": "Label for the title regex 
matcher",
+   "massaction-task-id": "Placeholder for task id",
+   "massaction-view-task-submit": "Text displayed in submit button",
+   "massaction-view-task-title": "Title for page displaing tasks",
+   "massaction-view-task-no-tasks": "Text displayed when no tasks can be 
displayed for given id. Parameters:\n* $1 - given task id",
+   "massaction-view-task-id": "Title for page displaying task with given 
id. Parameters:\n* $1 - given task id",
+   "massaction-view-task-summary": "Text that shows summary of task. 
Parameters:\n* $1 - task summary",
+   "massaction-view-task-user": "Text that shows user of task. 
Parameters:\n* $1 - task user name",
+   "massaction-view-task-target-type": "Text that shows target type of 
task. Parameters:\n* $1 - task target type",
+   "massaction-view-task-date-created": "Text that shows creation date of 
task. Parameters:\n* $ - task creation date",
+   "massaction-view-task-state": "Text that shows state of task. 
Parameters:\n* $1 - task state",
+   "massaction-view-task-actions": "Title for actions with their count. 
Parameters:\n* $1 - actions count",
+   "massaction-view-task-matchers": "Title for matchers with their count. 
Parameters:\n* $1 - matchers count",
+   "massaction-view-task-targets": "Title for targets with their count. 
Parameters:\n* $1 - targets count",
+   "massaction-view-task-save-all": "Text that shows in submit button for 
saving all targets changes",
+   "massaction-view-task-target-identifier": "Text that shows in table 
heading for target identifier",
+   "massaction-view-task-target-name": "Text that shows in table heading 
for target name",
+   "massaction-view-task-target-state": "Text that shows in table heading 
for target state",
+   "massaction-view-task-target-save": "Text that shows in submit button 
for saving target changes"
 }
diff --git a/src/MassActionSpecialPage.php b/src/MassActionSpecialPage.php
index ece1dc1..5556c11 100644
--- a/src/MassActionSpecialPage.php
+++ b/src/MassActionSpecialPage.php
@@ -84,11 +84,11 @@
$formDescriptor = array(
'viewid' =>