[MediaWiki-commits] [Gerrit] mediawiki...Metrolook[master]: Improve some parameter docs

2018-01-07 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/402631 )

Change subject: Improve some parameter docs
..


Improve some parameter docs

Change-Id: Ib45c5a3eb45373fdc8ef91b95667bc1b94599f0d
---
M .phpcs.xml
M SkinMetrolook.php
M SkinMetrolookHooks.php
3 files changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Paladox: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/.phpcs.xml b/.phpcs.xml
index d57c719..3ba9483 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,8 +2,6 @@
 


-   
-   

.

diff --git a/SkinMetrolook.php b/SkinMetrolook.php
index 961deff..89ff179 100644
--- a/SkinMetrolook.php
+++ b/SkinMetrolook.php
@@ -118,6 +118,7 @@
 
/**
 * Override to pass our Config instance to it
+* @inheritDoc
 */
public function setupTemplate( $classname, $repository = false, 
$cache_dir = false ) {
return new $classname( $this->metrolookConfig );
diff --git a/SkinMetrolookHooks.php b/SkinMetrolookHooks.php
index 2eae141..d462273 100644
--- a/SkinMetrolookHooks.php
+++ b/SkinMetrolookHooks.php
@@ -72,6 +72,7 @@
 *
 * @param OutputPage $out
 * @param Skin $skin
+* @return true
 */
public static function beforePageDisplay( $out, $skin ) {
if ( $skin instanceof SkinMetrolook ) {
@@ -92,6 +93,7 @@
 *
 * @param User current user $user
 * @param array list of default user preference controls 
&$defaultPreferences
+* @return true
 */
public static function getPreferences( $user, &$defaultPreferences ) {
global $wgMetrolookFeatures;
@@ -113,6 +115,8 @@
 * ResourceLoaderGetConfigVars hook
 *
 * Adds enabled/disabled switches for Vector modules
+* @param array &$vars
+* @return true
 */
public static function resourceLoaderGetConfigVars( &$vars ) {
global $wgMetrolookFeatures, $wgMetrolookSearchBar;

-- 
To view, visit https://gerrit.wikimedia.org/r/402631
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib45c5a3eb45373fdc8ef91b95667bc1b94599f0d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Metrolook
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Metrolook[master]: Improve some parameter docs

2018-01-07 Thread Umherirrender (Code Review) 
Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402631 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: Ib45c5a3eb45373fdc8ef91b95667bc1b94599f0d
---
M .phpcs.xml
M SkinMetrolook.php
M SkinMetrolookHooks.php
3 files changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Metrolook 
refs/changes/31/402631/1

diff --git a/.phpcs.xml b/.phpcs.xml
index d57c719..3ba9483 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,8 +2,6 @@
 


-   
-   

.

diff --git a/SkinMetrolook.php b/SkinMetrolook.php
index 961deff..89ff179 100644
--- a/SkinMetrolook.php
+++ b/SkinMetrolook.php
@@ -118,6 +118,7 @@
 
/**
 * Override to pass our Config instance to it
+* @inheritDoc
 */
public function setupTemplate( $classname, $repository = false, 
$cache_dir = false ) {
return new $classname( $this->metrolookConfig );
diff --git a/SkinMetrolookHooks.php b/SkinMetrolookHooks.php
index 2eae141..d462273 100644
--- a/SkinMetrolookHooks.php
+++ b/SkinMetrolookHooks.php
@@ -72,6 +72,7 @@
 *
 * @param OutputPage $out
 * @param Skin $skin
+* @return true
 */
public static function beforePageDisplay( $out, $skin ) {
if ( $skin instanceof SkinMetrolook ) {
@@ -92,6 +93,7 @@
 *
 * @param User current user $user
 * @param array list of default user preference controls 
&$defaultPreferences
+* @return true
 */
public static function getPreferences( $user, &$defaultPreferences ) {
global $wgMetrolookFeatures;
@@ -113,6 +115,8 @@
 * ResourceLoaderGetConfigVars hook
 *
 * Adds enabled/disabled switches for Vector modules
+* @param array &$vars
+* @return true
 */
public static function resourceLoaderGetConfigVars( &$vars ) {
global $wgMetrolookFeatures, $wgMetrolookSearchBar;

-- 
To view, visit https://gerrit.wikimedia.org/r/402631
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib45c5a3eb45373fdc8ef91b95667bc1b94599f0d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Metrolook
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits