[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Disable print button on iOS

2017-10-23 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385433 )

Change subject: Disable print button on iOS
..


Disable print button on iOS

As documented on the ticket, iOS does not provide PDF functionality
via print.

iOS 11 provides PDF generation but the resulting PDF is unreadable for
our content and missing styles (see T177215#3700576) and we do not know
of any way to invoke that just yet.

Bug: T177215
Change-Id: I7e195ae067625c7865dccee31fa7a2c3c0ee57e5
---
M resources/skins.minerva.scripts/init.js
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Phuedx: Looks good to me, approved



diff --git a/resources/skins.minerva.scripts/init.js 
b/resources/skins.minerva.scripts/init.js
index a267077..0b5a3cd 100644
--- a/resources/skins.minerva.scripts/init.js
+++ b/resources/skins.minerva.scripts/init.js
@@ -261,8 +261,13 @@
initHistoryLink( $( '.last-modifier-tagline a' ) );
M.on( 'resize', loadTabletModules );
loadTabletModules();
-   if ( config.get( 'wgMinervaDownloadIcon' ) && 
!page.isMainPage() ) {
 
+   if (
+   config.get( 'wgMinervaDownloadIcon' ) &&
+   !page.isMainPage() &&
+   // The iOS print dialog does not provide pdf 
functionality (see T177215)
+   !browser.isIos()
+   ) {
// Because the page actions are floated to the right, 
their order in the
// DOM is reversed in the display. The watchstar is 
last in the DOM and
// left-most in the display. Since we want the download 
button to be to

-- 
To view, visit https://gerrit.wikimedia.org/r/385433
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7e195ae067625c7865dccee31fa7a2c3c0ee57e5
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 
Gerrit-Reviewer: Phuedx 
Gerrit-Reviewer: Pmiazga 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Disable print button on iOS

2017-10-20 Thread Jdlrobson (Code Review) 
Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385433 )

Change subject: Disable print button on iOS
..

Disable print button on iOS

As documented on the ticket, iOS does not provide pdf functionality
via print.

iOS 11 provides PDF generation but the resulting PDF is unreadable for
our content and missing styles and we do not know of any way to invoke
that just yet.

Bug: T177215
Change-Id: I7e195ae067625c7865dccee31fa7a2c3c0ee57e5
---
M resources/skins.minerva.scripts/init.js
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue 
refs/changes/33/385433/1

diff --git a/resources/skins.minerva.scripts/init.js 
b/resources/skins.minerva.scripts/init.js
index 1458aa6..a654bca 100644
--- a/resources/skins.minerva.scripts/init.js
+++ b/resources/skins.minerva.scripts/init.js
@@ -261,7 +261,12 @@
initHistoryLink( $( '.last-modifier-tagline a' ) );
M.on( 'resize', loadTabletModules );
loadTabletModules();
-   if ( config.get( 'wgMinervaDownloadIcon' ) && 
!page.isMainPage() ) {
+   if (
+   config.get( 'wgMinervaDownloadIcon' ) &&
+   !page.isMainPage()
+   // The iOS print dialog does not provide pdf 
functionality (see T177215)
+   && !browser.isIos()
+   ) {
new DownloadIcon( skin ).$el.insertAfter( '#ca-watch' );
}
} );

-- 
To view, visit https://gerrit.wikimedia.org/r/385433
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e195ae067625c7865dccee31fa7a2c3c0ee57e5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits