[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Revision::newFromTitle may return null

2017-09-27 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/381071 )

Change subject: Revision::newFromTitle may return null
..


Revision::newFromTitle may return null

Bug: T176882
Change-Id: I9aea25c2db81a12f16414edcb279f3241dc380bc
---
M includes/skins/SkinMinerva.php
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Pmiazga: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index cc09b05..102bef4 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -746,7 +746,12 @@
$historyUrl = $title->getLocalURL( [ 'action' => 
'history' ] );
}
 
-   $editor = $this->getRevisionEditor( Revision::newFromTitle( 
$title ) );
+   $rev = Revision::newFromTitle( $title );
+   if ( $rev ) {
+   $editor = $this->getRevisionEditor( $rev );
+   } else {
+   $editor = false;
+   }
return [
// Use $edit['timestamp'] (Unix format) instead of 
$timestamp (MW format)
'data-timestamp' => $isMainPage ? '' : wfTimestamp( 
TS_UNIX, $timestamp ),

-- 
To view, visit https://gerrit.wikimedia.org/r/381071
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9aea25c2db81a12f16414edcb279f3241dc380bc
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 
Gerrit-Reviewer: Pmiazga 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Revision::newFromTitle may return null

2017-09-27 Thread Jdlrobson (Code Review) 
Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/381071 )

Change subject: Revision::newFromTitle may return null
..

Revision::newFromTitle may return null

Bug: T176882
Change-Id: I9aea25c2db81a12f16414edcb279f3241dc380bc
---
M includes/skins/SkinMinerva.php
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue 
refs/changes/71/381071/1

diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index cc09b05..102bef4 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -746,7 +746,12 @@
$historyUrl = $title->getLocalURL( [ 'action' => 
'history' ] );
}
 
-   $editor = $this->getRevisionEditor( Revision::newFromTitle( 
$title ) );
+   $rev = Revision::newFromTitle( $title );
+   if ( $rev ) {
+   $editor = $this->getRevisionEditor( $rev );
+   } else {
+   $editor = false;
+   }
return [
// Use $edit['timestamp'] (Unix format) instead of 
$timestamp (MW format)
'data-timestamp' => $isMainPage ? '' : wfTimestamp( 
TS_UNIX, $timestamp ),

-- 
To view, visit https://gerrit.wikimedia.org/r/381071
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9aea25c2db81a12f16414edcb279f3241dc380bc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits