[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Hlist tweaks (size and color)

2017-10-09 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/383157 )

Change subject: Hlist tweaks (size and color)
..


Hlist tweaks (size and color)

* Font size should be relative to context
* Only apply linkColor to links in footer

Bug: T169315
Change-Id: Ibb25d8b63e4efaf8b2bc4c28e3bac95a6a16db86
---
M resources/skins.minerva.base.styles/footer.less
M skinStyles/mediawiki.hlist/minerva.less
2 files changed, 8 insertions(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jdlrobson: Looks good to me, approved



diff --git a/resources/skins.minerva.base.styles/footer.less 
b/resources/skins.minerva.base.styles/footer.less
index b3739df..51563b0 100644
--- a/resources/skins.minerva.base.styles/footer.less
+++ b/resources/skins.minerva.base.styles/footer.less
@@ -6,6 +6,13 @@
overflow: auto;
padding-bottom: 6px;
 
+   // links should be separated by same color
+   .hlist {
+   li:after {
+   color: @linkColor;
+   }
+   }
+
.last-modified-bar {
border-bottom: solid 1px @footerBorderColor;
background-color: @lastModifiedBarBgColor;
diff --git a/skinStyles/mediawiki.hlist/minerva.less 
b/skinStyles/mediawiki.hlist/minerva.less
index d6a0f06..abe6279 100644
--- a/skinStyles/mediawiki.hlist/minerva.less
+++ b/skinStyles/mediawiki.hlist/minerva.less
@@ -31,8 +31,7 @@
// Make sure we override any site styles
content: '•' !important;
padding-left: 8px;
-   color: @linkColor;
-   font-size: 16px;
+   font-size: 1em;
line-height: 1;
}
:last-child:after {

-- 
To view, visit https://gerrit.wikimedia.org/r/383157
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb25d8b63e4efaf8b2bc4c28e3bac95a6a16db86
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Pmiazga 
Gerrit-Reviewer: Zoranzoki21 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Hlist tweaks (size and color)

2017-10-09 Thread Jdlrobson (Code Review) 
Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/383157 )

Change subject: Hlist tweaks (size and color)
..

Hlist tweaks (size and color)

* Font size should be relative to context
* Only apply linkColor to links in footer

Bug: T169315
Change-Id: Ibb25d8b63e4efaf8b2bc4c28e3bac95a6a16db86
---
M resources/skins.minerva.base.styles/footer.less
M skinStyles/mediawiki.hlist/minerva.less
2 files changed, 10 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue 
refs/changes/57/383157/1

diff --git a/resources/skins.minerva.base.styles/footer.less 
b/resources/skins.minerva.base.styles/footer.less
index b3739df..55faca9 100644
--- a/resources/skins.minerva.base.styles/footer.less
+++ b/resources/skins.minerva.base.styles/footer.less
@@ -6,6 +6,14 @@
overflow: auto;
padding-bottom: 6px;
 
+
+   // links should be separated by same color
+   .hlist {
+   li:after {
+   color: @linkColor;
+   }
+   }
+
.last-modified-bar {
border-bottom: solid 1px @footerBorderColor;
background-color: @lastModifiedBarBgColor;
diff --git a/skinStyles/mediawiki.hlist/minerva.less 
b/skinStyles/mediawiki.hlist/minerva.less
index d6a0f06..8a6ed05 100644
--- a/skinStyles/mediawiki.hlist/minerva.less
+++ b/skinStyles/mediawiki.hlist/minerva.less
@@ -31,10 +31,10 @@
// Make sure we override any site styles
content: '•' !important;
padding-left: 8px;
-   color: @linkColor;
-   font-size: 16px;
+   font-size: 1em;
line-height: 1;
}
+
:last-child:after {
content: none !important;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/383157
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb25d8b63e4efaf8b2bc4c28e3bac95a6a16db86
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits