[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Make svg_check.sh verbose

2017-12-11 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397565 )

Change subject: Make svg_check.sh verbose
..


Make svg_check.sh verbose

So we know what is going on while the CPU is being busy.

Change-Id: I34a7ecadf549833025a197d72ca131888519a92a
---
M dev-scripts/svg_check.sh
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Jdlrobson: Looks good to me, approved



diff --git a/dev-scripts/svg_check.sh b/dev-scripts/svg_check.sh
index 220e434..db45f91 100755
--- a/dev-scripts/svg_check.sh
+++ b/dev-scripts/svg_check.sh
@@ -3,10 +3,13 @@
 
 while read -r svgfile; do
outfile="$svgfile.tmp"
+   echo -n "Checking compression: $svgfile ... "
node_modules/.bin/svgo --config .svgo.yml -i "$svgfile" -o "$outfile" -q
if [ "$(wc -c < "$svgfile")" -gt "$(wc -c < "$outfile")" ]; then
-   echo "File $svgfile is not compressed."
+   echo -e "\nERR> file $svgfile is not compressed."
found=$((found + 1))
+   else
+   echo "OK"
fi
rm "$outfile"
 done < <(find resources -type f -name '*.svg')

-- 
To view, visit https://gerrit.wikimedia.org/r/397565
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I34a7ecadf549833025a197d72ca131888519a92a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Hashar 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Pmiazga 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Make svg_check.sh verbose

2017-12-11 Thread Hashar (Code Review)
Hashar has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397565 )

Change subject: Make svg_check.sh verbose
..

Make svg_check.sh verbose

So we know what is going on while the CPU is being busy.

Change-Id: I34a7ecadf549833025a197d72ca131888519a92a
---
M dev-scripts/svg_check.sh
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue 
refs/changes/65/397565/1

diff --git a/dev-scripts/svg_check.sh b/dev-scripts/svg_check.sh
index 220e434..db45f91 100755
--- a/dev-scripts/svg_check.sh
+++ b/dev-scripts/svg_check.sh
@@ -3,10 +3,13 @@
 
 while read -r svgfile; do
outfile="$svgfile.tmp"
+   echo -n "Checking compression: $svgfile ... "
node_modules/.bin/svgo --config .svgo.yml -i "$svgfile" -o "$outfile" -q
if [ "$(wc -c < "$svgfile")" -gt "$(wc -c < "$outfile")" ]; then
-   echo "File $svgfile is not compressed."
+   echo -e "\nERR> file $svgfile is not compressed."
found=$((found + 1))
+   else
+   echo "OK"
fi
rm "$outfile"
 done < <(find resources -type f -name '*.svg')

-- 
To view, visit https://gerrit.wikimedia.org/r/397565
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I34a7ecadf549833025a197d72ca131888519a92a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits