[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Cleanup header cache artifacts

2017-02-24 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/339233 )

Change subject: Cleanup header cache artifacts
..


Cleanup header cache artifacts

Changes:
 - removed unused styles

Bug: T158144
Change-Id: I6cd012910fb0b5497c3bd09c69a5c5064c9d1ded
---
M resources/mobile.search/SearchOverlay.less
M resources/skins.minerva.base.styles/ui.less
2 files changed, 0 insertions(+), 37 deletions(-)

Approvals:
  Bmansurov: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/mobile.search/SearchOverlay.less 
b/resources/mobile.search/SearchOverlay.less
index e430038..d92cbc1 100644
--- a/resources/mobile.search/SearchOverlay.less
+++ b/resources/mobile.search/SearchOverlay.less
@@ -125,15 +125,6 @@
&.no-results .search-feedback {
border-top: 0;
}
-
-}
-
-// FIXME: This block is used to support cached HTML for the input margin-top 
rule.
-// Please remove entire block when the cache has cleared for T157987.
-.search-overlay .header .search-box {
-   input.search {
-   margin-top: 0;
-   }
 }
 
 @-webkit-keyframes fadeIn {
diff --git a/resources/skins.minerva.base.styles/ui.less 
b/resources/skins.minerva.base.styles/ui.less
index e8d05a5..d3bdf61 100644
--- a/resources/skins.minerva.base.styles/ui.less
+++ b/resources/skins.minerva.base.styles/ui.less
@@ -120,8 +120,6 @@
 
// Search field
.main,
-   // FIXME: form selector is only necessary until cache has cleared. 
Please remove promptly (T157987)
-   > form,
// Spinner
> div {
vertical-align: middle;
@@ -321,32 +319,6 @@
 .client-nojs {
.section-heading .indicator {
display: none;
-   }
-
-   // FIXME: Remove when cache has cleared (T157987)
-   .header > form {
-   width: auto;
-   vertical-align: middle;
-
-   .button-wrapper,
-   .fulltext-search {
-   background-color: #36c;
-   border-radius: 2px;
-   cursor: pointer;
-   float: right;
-   margin-left: 0.5em;
-   padding: 0.375em 0;
-   }
-
-   > .input-wrapper {
-   overflow: hidden;
-   }
-
-   input.search {
-   margin-right: 0;
-   padding-right: 0.1em;
-   width: 100%;
-   }
}
 
// FIXME: Remove when feature-header-v1 no longer supported

-- 
To view, visit https://gerrit.wikimedia.org/r/339233
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6cd012910fb0b5497c3bd09c69a5c5064c9d1ded
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Pmiazga 
Gerrit-Reviewer: Bmansurov 
Gerrit-Reviewer: Phuedx 
Gerrit-Reviewer: Pmiazga 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Cleanup header cache artifacts

2017-02-22 Thread Pmiazga (Code Review) 
Pmiazga has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/339233 )

Change subject: Cleanup header cache artifacts
..

Cleanup header cache artifacts

Changes:
 - removed unsued styles

Bug: T158144
Change-Id: I6cd012910fb0b5497c3bd09c69a5c5064c9d1ded
---
M resources/mobile.search/SearchOverlay.less
M resources/skins.minerva.base.styles/ui.less
2 files changed, 0 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/33/339233/1

diff --git a/resources/mobile.search/SearchOverlay.less 
b/resources/mobile.search/SearchOverlay.less
index e430038..d92cbc1 100644
--- a/resources/mobile.search/SearchOverlay.less
+++ b/resources/mobile.search/SearchOverlay.less
@@ -125,15 +125,6 @@
&.no-results .search-feedback {
border-top: 0;
}
-
-}
-
-// FIXME: This block is used to support cached HTML for the input margin-top 
rule.
-// Please remove entire block when the cache has cleared for T157987.
-.search-overlay .header .search-box {
-   input.search {
-   margin-top: 0;
-   }
 }
 
 @-webkit-keyframes fadeIn {
diff --git a/resources/skins.minerva.base.styles/ui.less 
b/resources/skins.minerva.base.styles/ui.less
index e8d05a5..006dfae 100644
--- a/resources/skins.minerva.base.styles/ui.less
+++ b/resources/skins.minerva.base.styles/ui.less
@@ -119,8 +119,6 @@
}
 
// Search field
-   .main,
-   // FIXME: form selector is only necessary until cache has cleared. 
Please remove promptly (T157987)
> form,
// Spinner
> div {
@@ -321,32 +319,6 @@
 .client-nojs {
.section-heading .indicator {
display: none;
-   }
-
-   // FIXME: Remove when cache has cleared (T157987)
-   .header > form {
-   width: auto;
-   vertical-align: middle;
-
-   .button-wrapper,
-   .fulltext-search {
-   background-color: #36c;
-   border-radius: 2px;
-   cursor: pointer;
-   float: right;
-   margin-left: 0.5em;
-   padding: 0.375em 0;
-   }
-
-   > .input-wrapper {
-   overflow: hidden;
-   }
-
-   input.search {
-   margin-right: 0;
-   padding-right: 0.1em;
-   width: 100%;
-   }
}
 
// FIXME: Remove when feature-header-v1 no longer supported

-- 
To view, visit https://gerrit.wikimedia.org/r/339233
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6cd012910fb0b5497c3bd09c69a5c5064c9d1ded
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Pmiazga 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits