[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Don't call html_entity_decode() on a URL query string

2017-07-07 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/363991 )

Change subject: Don't call html_entity_decode() on a URL query string
..


Don't call html_entity_decode() on a URL query string

Follows-up 2e96b6a47bd9f.

There is no reason why HTML entities should need to be decoded in URLs,
certainly not in a function whose only job is to remove one
query string parameter and otherwise leave the query string alone.

Change-Id: I1edacd6001ab70ce18b74cf2e029d653d6a2e8b6
---
M includes/MobileContext.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified
  Jforrester: Looks good to me, but someone else must approve



diff --git a/includes/MobileContext.php b/includes/MobileContext.php
index 734f0ef..d9471d5 100644
--- a/includes/MobileContext.php
+++ b/includes/MobileContext.php
@@ -947,7 +947,7 @@
 */
protected function updateDesktopUrlQuery( &$parsedUrl ) {
if ( isset( $parsedUrl['query'] ) && strpos( 
$parsedUrl['query'], 'useformat' ) !== false ) {
-   $query = wfCgiToArray( html_entity_decode( 
$parsedUrl['query'] ) );
+   $query = wfCgiToArray( $parsedUrl['query'] );
unset( $query['useformat'] );
$parsedUrl['query'] = wfArrayToCgi( $query );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/363991
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1edacd6001ab70ce18b74cf2e029d653d6a2e8b6
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Catrope 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Don't call html_entity_decode() on a URL query string

2017-07-07 Thread Catrope (Code Review) 
Catrope has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/363991 )

Change subject: Don't call html_entity_decode() on a URL query string
..

Don't call html_entity_decode() on a URL query string

There is no reason why HTML entities should need to be decoded in URLs,
certainly not in a function whose only job is to remove one
query string parameter and otherwise leave the query string alone.

Change-Id: I1edacd6001ab70ce18b74cf2e029d653d6a2e8b6
---
M includes/MobileContext.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/91/363991/1

diff --git a/includes/MobileContext.php b/includes/MobileContext.php
index 734f0ef..d9471d5 100644
--- a/includes/MobileContext.php
+++ b/includes/MobileContext.php
@@ -947,7 +947,7 @@
 */
protected function updateDesktopUrlQuery( &$parsedUrl ) {
if ( isset( $parsedUrl['query'] ) && strpos( 
$parsedUrl['query'], 'useformat' ) !== false ) {
-   $query = wfCgiToArray( html_entity_decode( 
$parsedUrl['query'] ) );
+   $query = wfCgiToArray( $parsedUrl['query'] );
unset( $query['useformat'] );
$parsedUrl['query'] = wfArrayToCgi( $query );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/363991
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1edacd6001ab70ce18b74cf2e029d653d6a2e8b6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Catrope 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits