[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Fix animation of notifications overlay drawer in RTL

2016-12-09 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/326209 )

Change subject: Fix animation of notifications overlay drawer in RTL
..


Fix animation of notifications overlay drawer in RTL

There were RTL styles, but they weren't being applied because
the rtl and animations classes both apply to the ,
and the styles were wrongly using a descendant selector.

Change-Id: I6b737fa9ee1f3572bb746ba12fc58005474194b8
---
M resources/mobile.mainMenu/mainmenu.less
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Jdlrobson: Looks good to me, approved



diff --git a/resources/mobile.mainMenu/mainmenu.less 
b/resources/mobile.mainMenu/mainmenu.less
index 7b827cc..00c1459 100644
--- a/resources/mobile.mainMenu/mainmenu.less
+++ b/resources/mobile.mainMenu/mainmenu.less
@@ -272,7 +272,7 @@
 
 .rtl {
// FIXME: Make animations a conditional class on the drawer itself
-   .animations .notifications-overlay.navigation-drawer {
+   &.animations .notifications-overlay.navigation-drawer {
// +2% to accommodate for the border/box-shadow
.transform( translate( -102%, 0 ) );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/326209
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6b737fa9ee1f3572bb746ba12fc58005474194b8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Catrope 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Fix animation of notifications overlay drawer in RTL

2016-12-09 Thread Catrope (Code Review) 
Catrope has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/326209 )

Change subject: Fix animation of notifications overlay drawer in RTL
..

Fix animation of notifications overlay drawer in RTL

There were RTL styles, but they weren't being applied because
the rtl and animations classes both apply to the ,
and the styles were wrongly using a descendant selector.

Change-Id: I6b737fa9ee1f3572bb746ba12fc58005474194b8
---
M resources/mobile.mainMenu/mainmenu.less
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/09/326209/1

diff --git a/resources/mobile.mainMenu/mainmenu.less 
b/resources/mobile.mainMenu/mainmenu.less
index 7b827cc..00c1459 100644
--- a/resources/mobile.mainMenu/mainmenu.less
+++ b/resources/mobile.mainMenu/mainmenu.less
@@ -272,7 +272,7 @@
 
 .rtl {
// FIXME: Make animations a conditional class on the drawer itself
-   .animations .notifications-overlay.navigation-drawer {
+   &.animations .notifications-overlay.navigation-drawer {
// +2% to accommodate for the border/box-shadow
.transform( translate( -102%, 0 ) );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/326209
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b737fa9ee1f3572bb746ba12fc58005474194b8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Catrope 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits