[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Use String.prototype.trim
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/373138 ) Change subject: Hygiene: Use String.prototype.trim .. Hygiene: Use String.prototype.trim No need to use $.trim when we support ES5 Change-Id: Ifc9b17a25b6be9014c5b0ae24fae44561c5680f5 --- M tests/qunit/mobile.talk.overlays/test_TalkOverlay.js 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Krinkle: Looks good to me, approved jenkins-bot: Verified Jdlrobson: Looks good to me, approved diff --git a/tests/qunit/mobile.talk.overlays/test_TalkOverlay.js b/tests/qunit/mobile.talk.overlays/test_TalkOverlay.js index 0d89040..b6fd549 100644 --- a/tests/qunit/mobile.talk.overlays/test_TalkOverlay.js +++ b/tests/qunit/mobile.talk.overlays/test_TalkOverlay.js @@ -59,7 +59,7 @@ } ); assert.ok( overlay.$( '.add' ).length > 0, 'There is an "Add discussion" button' ); - assert.strictEqual( $.trim( overlay.$( '.content-header' ).text() ), + assert.strictEqual( overlay.$( '.content-header' ).text().trim(), mw.msg( 'mobile-frontend-talk-explained-empty' ), 'Check the header knows it is empty.' ); } ); @@ -75,7 +75,7 @@ 'The text of the second item is the section heading.' ); assert.strictEqual( overlay.$( '.topic-title-list li a' ).data( 'id' ), 50, 'The data id is set.' ); - assert.strictEqual( $.trim( overlay.$( '.content-header' ).text() ), + assert.strictEqual( overlay.$( '.content-header' ).text().trim(), mw.msg( 'mobile-frontend-talk-explained' ), 'Check the header knows it is not empty.' ); } ); -- To view, visit https://gerrit.wikimedia.org/r/373138 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc9b17a25b6be9014c5b0ae24fae44561c5680f5 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson Gerrit-Reviewer: Jdlrobson Gerrit-Reviewer: Krinkle Gerrit-Reviewer: Pmiazga Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Use String.prototype.trim
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373138 ) Change subject: Hygiene: Use String.prototype.trim .. Hygiene: Use String.prototype.trim No need to use $.trim when we support ES5 Change-Id: Ifc9b17a25b6be9014c5b0ae24fae44561c5680f5 --- M tests/qunit/mobile.talk.overlays/test_TalkOverlay.js 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/38/373138/1 diff --git a/tests/qunit/mobile.talk.overlays/test_TalkOverlay.js b/tests/qunit/mobile.talk.overlays/test_TalkOverlay.js index 0d89040..df367ec 100644 --- a/tests/qunit/mobile.talk.overlays/test_TalkOverlay.js +++ b/tests/qunit/mobile.talk.overlays/test_TalkOverlay.js @@ -59,7 +59,7 @@ } ); assert.ok( overlay.$( '.add' ).length > 0, 'There is an "Add discussion" button' ); - assert.strictEqual( $.trim( overlay.$( '.content-header' ).text() ), + assert.strictEqual( overlay.$( '.content-header' ).text().trim(), mw.msg( 'mobile-frontend-talk-explained-empty' ), 'Check the header knows it is empty.' ); } ); @@ -75,7 +75,7 @@ 'The text of the second item is the section heading.' ); assert.strictEqual( overlay.$( '.topic-title-list li a' ).data( 'id' ), 50, 'The data id is set.' ); - assert.strictEqual( $.trim( overlay.$( '.content-header' ).text() ), + assert.strictEqual( overlay.$( '.content-header' ).text().trim() ), mw.msg( 'mobile-frontend-talk-explained' ), 'Check the header knows it is not empty.' ); } ); -- To view, visit https://gerrit.wikimedia.org/r/373138 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifc9b17a25b6be9014c5b0ae24fae44561c5680f5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
