[MediaWiki-commits] [Gerrit] mediawiki...MultimediaViewer[master]: Update for $wgMediaViewerEnableByDefault

2017-09-25 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/316706 )

Change subject: Update for $wgMediaViewerEnableByDefault
..


Update for $wgMediaViewerEnableByDefault

To be consistent with $wgDefaultUserOptions logic

Migration of bugzilla bug id to maniphest

Bug: T148492
Change-Id: Ie371a0c2445c9aededb5c9e26018d19cbd616358
Depends-On: If53a735458703f0bd2c094349edf86f38f05ccd7
---
M MultimediaViewerHooks.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  MarkTraceur: Looks good to me, approved
  jenkins-bot: Verified
  Jdlrobson: Looks good to me, approved



diff --git a/MultimediaViewerHooks.php b/MultimediaViewerHooks.php
index 71dd430..1064de3 100644
--- a/MultimediaViewerHooks.php
+++ b/MultimediaViewerHooks.php
@@ -158,7 +158,7 @@
global $wgMediaViewerEnableByDefault;
 
if ( $wgMediaViewerEnableByDefault ) {
-   $defaultOptions['multimediaviewer-enable'] = true;
+   $defaultOptions['multimediaviewer-enable'] = 1;
}
 
return true;

-- 
To view, visit https://gerrit.wikimedia.org/r/316706
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie371a0c2445c9aededb5c9e26018d19cbd616358
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Arseny1992 
Gerrit-Reviewer: Aarcos 
Gerrit-Reviewer: Gergő Tisza 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: MarkTraceur 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MultimediaViewer[master]: Update for $wgMediaViewerEnableByDefault

2016-10-18 Thread Arseny1992 (Code Review) 
Arseny1992 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/316706

Change subject: Update for $wgMediaViewerEnableByDefault
..

Update for $wgMediaViewerEnableByDefault

To be consistent with $wgDefaultUserOptions logic

Migration of bugzilla bug id to maniphest

Bug: T148492
Change-Id: Ie371a0c2445c9aededb5c9e26018d19cbd616358
---
M MultimediaViewerHooks.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer 
refs/changes/06/316706/1

diff --git a/MultimediaViewerHooks.php b/MultimediaViewerHooks.php
index d27a3c7..13f8ae7 100644
--- a/MultimediaViewerHooks.php
+++ b/MultimediaViewerHooks.php
@@ -154,7 +154,7 @@
}
 
if ( $wgMediaViewerEnableByDefault ) {
-   $wgDefaultUserOptions['multimediaviewer-enable'] = true;
+   $wgDefaultUserOptions['multimediaviewer-enable'] = 1;
}
}
 
@@ -321,7 +321,7 @@
 
$user = $out->getUser();
$vars['wgMediaViewerOnClick'] = self::shouldHandleClicks( $user 
);
-   // needed because of bug 69942; could be different for anon and 
logged-in
+   // needed because of bug T71942; could be different for anon 
and logged-in
$vars['wgMediaViewerEnabledByDefault'] = !empty( 
$wgDefaultUserOptions['multimediaviewer-enable'] );
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/316706
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie371a0c2445c9aededb5c9e26018d19cbd616358
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Arseny1992 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits