Framawiki has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373130 )
Change subject: Add the app name in the success message of
Special:OAuthManageMyGrants/revoke/xxx
......................................................................
Add the app name in the success message of
Special:OAuthManageMyGrants/revoke/xxx
Bug: T171413
Change-Id: I5d7e68f0493f52231bddd7efdf7d9b0ed56e6f42
---
M frontend/specialpages/SpecialMWOAuthManageMyGrants.php
M i18n/en.json
M i18n/qqq.json
3 files changed, 8 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OAuth
refs/changes/30/373130/1
diff --git a/frontend/specialpages/SpecialMWOAuthManageMyGrants.php
b/frontend/specialpages/SpecialMWOAuthManageMyGrants.php
index d582a17..aa03503 100644
--- a/frontend/specialpages/SpecialMWOAuthManageMyGrants.php
+++ b/frontend/specialpages/SpecialMWOAuthManageMyGrants.php
@@ -236,7 +236,10 @@
if ( $status instanceof \Status && $status->isOk() ) {
// Messages: mwoauthmanagemygrants-success-update,
// mwoauthmanagemygrants-success-renounce
- $this->getOutput()->addWikiMsg(
"mwoauthmanagemygrants-success-$action" );
+ $this->getOutput()->addWikiMsg(
"mwoauthmanagemygrants-success-$action",
+ $cmr->get( 'name', function( $s ) use ( $cmr ) {
+ return '<strong>' . $s . ' [' . $cmr->get(
'version' ) . ']</strong>';
+ } ));
}
}
diff --git a/i18n/en.json b/i18n/en.json
index d8ead7e..4dbced0 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -180,8 +180,8 @@
"mwoauthmanagemygrants-renounce": "Deauthorize",
"mwoauthmanagemygrants-action": "Change status:",
"mwoauthmanagemygrants-confirm-submit": "Update access token status",
- "mwoauthmanagemygrants-success-update": "Your preferences for this
application have been updated.",
- "mwoauthmanagemygrants-success-renounce": "The application's access to
your account has been revoked.",
+ "mwoauthmanagemygrants-success-update": "Your preferences for $1 have
been updated.",
+ "mwoauthmanagemygrants-success-renounce": "$1's access to your account
has been revoked.",
"mwoauthmanagemygrants-basic-tooltip": "Why can't I update this grant?
This grant gives your connected application basic permissions which it requires
to function properly. If you don't want this connected application to have
these rights, you should revoke the application's access.",
"mwoauthmanagemygrants-authonly-tooltip": "Why can't I update this
grant? If you don't want this connected application to have this right, you
should revoke the application's access.",
"logentry-mwoauthconsumer-propose": "$1 {{GENDER:$2|proposed}} an OAuth
consumer (consumer key $4)",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index c6a5d57..b829c2a 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -190,8 +190,8 @@
"mwoauthmanagemygrants-renounce": "Used as label for the radio
box.\n\nSee also:\n* {{msg-mw|Mwoauthmanagemygrants-action}}",
"mwoauthmanagemygrants-action": "Used as label for the radio box
group.\n\nFollowed by the following radio boxes:\n*
{{msg-mw|Mwoauthmanagemygrants-update}}\n*
{{msg-mw|Mwoauthmanagemygrants-renounce}}\n{{Identical|Change status}}",
"mwoauthmanagemygrants-confirm-submit": "Used as label for the Submit
button",
- "mwoauthmanagemygrants-success-update": "Message shown when grants for
an OAuth consumer are updated by a user",
- "mwoauthmanagemygrants-success-renounce": "Message shown when grants
for an OAuth consumer are totally revoked",
+ "mwoauthmanagemygrants-success-update": "Message shown when grants for
an OAuth consumer are updated by a user\n\nParameters:\n* $1 - the application
name",
+ "mwoauthmanagemygrants-success-renounce": "Message shown when grants
for an OAuth consumer are totally revoked\n\nParameters:\n* $1 - the
application name",
"mwoauthmanagemygrants-basic-tooltip": "Message for the tooltip shown
next to the disabled checkbox for the \"basic\" grant on
[[Special:OAuthManageMyGrants]], explaining why the checkbox cannot be
modified.",
"mwoauthmanagemygrants-authonly-tooltip": "Message for the tooltip
shown next to the disabled checkboxes for the \"authonly\" and
\"authonlyprivate\" grants on [[Special:OAuthManageMyGrants]], explaining why
the checkbox cannot be modified.\n\nCf.
{{msg-mw|Mwoauthmanagemygrants-basic-tooltip}}",
"logentry-mwoauthconsumer-propose": "{{logentry}}",
--
To view, visit https://gerrit.wikimedia.org/r/373130
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d7e68f0493f52231bddd7efdf7d9b0ed56e6f42
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OAuth
Gerrit-Branch: master
Gerrit-Owner: Framawiki <framaw...@tools.wmflabs.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
