[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Enabled "button panel" for datepicker

2017-11-15 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/391609 )

Change subject: Enabled "button panel" for datepicker
..


Enabled "button panel" for datepicker

This seems to work fine across different jQuery versions.

Change-Id: I8af3ce481176a3c789d1034e482562d3612992bb
---
M libs/PF_datepicker.js
1 file changed, 1 insertion(+), 4 deletions(-)

Approvals:
  Yaron Koren: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/libs/PF_datepicker.js b/libs/PF_datepicker.js
index aebddfb..6e5f851 100644
--- a/libs/PF_datepicker.js
+++ b/libs/PF_datepicker.js
@@ -54,10 +54,7 @@
'changeMonth': true,
'changeYear': true,
'altFormat': 'yy/mm/dd',
-   // Today button does not work 
(http://dev.jqueryui.com/ticket/4045)
-   // do not show button panel for now
-   // TODO: show date picker button panel when bug is fixed
-   'showButtonPanel': false,
+   'showButtonPanel': true,
'firstDay': params.firstDay,
'dateFormat': params.dateFormat,
'beforeShowDay': function ( date ) {return 
PF_DP_checkDate( '#' + input_id + '_show', date );}

-- 
To view, visit https://gerrit.wikimedia.org/r/391609
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8af3ce481176a3c789d1034e482562d3612992bb
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/PageForms
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 
Gerrit-Reviewer: Yaron Koren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Enabled "button panel" for datepicker

2017-11-15 Thread Yaron Koren (Code Review)
Yaron Koren has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/391609 )

Change subject: Enabled "button panel" for datepicker
..

Enabled "button panel" for datepicker

This seems to work fine across different jQuery versions.

Change-Id: I8af3ce481176a3c789d1034e482562d3612992bb
---
M libs/PF_datepicker.js
1 file changed, 1 insertion(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageForms 
refs/changes/09/391609/2

diff --git a/libs/PF_datepicker.js b/libs/PF_datepicker.js
index aebddfb..6e5f851 100644
--- a/libs/PF_datepicker.js
+++ b/libs/PF_datepicker.js
@@ -54,10 +54,7 @@
'changeMonth': true,
'changeYear': true,
'altFormat': 'yy/mm/dd',
-   // Today button does not work 
(http://dev.jqueryui.com/ticket/4045)
-   // do not show button panel for now
-   // TODO: show date picker button panel when bug is fixed
-   'showButtonPanel': false,
+   'showButtonPanel': true,
'firstDay': params.firstDay,
'dateFormat': params.dateFormat,
'beforeShowDay': function ( date ) {return 
PF_DP_checkDate( '#' + input_id + '_show', date );}

-- 
To view, visit https://gerrit.wikimedia.org/r/391609
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8af3ce481176a3c789d1034e482562d3612992bb
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/PageForms
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits