[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Fix for c81949280a0e - fixed escaping of quotes in file names

2017-12-22 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/399815 )

Change subject: Fix for c81949280a0e - fixed escaping of quotes in file names
..


Fix for c81949280a0e - fixed escaping of quotes in file names

Change-Id: I02ef2e5eff23de2dd9d195c36f5ba210d8cedc32
---
M libs/ext.pf.select2.base.js
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Yaron Koren: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/libs/ext.pf.select2.base.js b/libs/ext.pf.select2.base.js
index 854e13b..ac1bbc3 100644
--- a/libs/ext.pf.select2.base.js
+++ b/libs/ext.pf.select2.base.js
@@ -75,9 +75,9 @@
var description = value.description;
var markup = "";
 
-   // Escape quotes in image.
+   // HTML-encode quotes in image name.
if ( image !== undefined ) {
-   image = image.replace( /"/g, '\\\"' );
+   image = image.replace( /"/g, "" );
}
 
var highlightedText = 
pf.select2.base.prototype.textHighlight( text, term );

-- 
To view, visit https://gerrit.wikimedia.org/r/399815
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I02ef2e5eff23de2dd9d195c36f5ba210d8cedc32
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/PageForms
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 
Gerrit-Reviewer: Yaron Koren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Fix for c81949280a0e - fixed escaping of quotes in file names

2017-12-22 Thread Yaron Koren (Code Review) 
Yaron Koren has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/399815 )

Change subject: Fix for c81949280a0e - fixed escaping of quotes in file names
..

Fix for c81949280a0e - fixed escaping of quotes in file names

Change-Id: I02ef2e5eff23de2dd9d195c36f5ba210d8cedc32
---
M libs/ext.pf.select2.base.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageForms 
refs/changes/15/399815/2

diff --git a/libs/ext.pf.select2.base.js b/libs/ext.pf.select2.base.js
index 854e13b..ac1bbc3 100644
--- a/libs/ext.pf.select2.base.js
+++ b/libs/ext.pf.select2.base.js
@@ -75,9 +75,9 @@
var description = value.description;
var markup = "";
 
-   // Escape quotes in image.
+   // HTML-encode quotes in image name.
if ( image !== undefined ) {
-   image = image.replace( /"/g, '\\\"' );
+   image = image.replace( /"/g, "" );
}
 
var highlightedText = 
pf.select2.base.prototype.textHighlight( text, term );

-- 
To view, visit https://gerrit.wikimedia.org/r/399815
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I02ef2e5eff23de2dd9d195c36f5ba210d8cedc32
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/PageForms
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits