[MediaWiki-commits] [Gerrit] mediawiki...PageTriage[master]: ApiPageTriageList: Better document parameter weirdness

2017-01-03 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/330266 )

Change subject: ApiPageTriageList: Better document parameter weirdness
..


ApiPageTriageList: Better document parameter weirdness

The provided example doesn't work because apparently you need
at least one of showreviewed=1 and showunreviewed=1 to get
any results at all.

It is not best-practice api.php module design to have
action=foo without any further parameters return nothing,
but it's 5 years too late to fix it now.

Bug: T154115
Change-Id: I29b0c600dc49384967491aa7d9a208c987a09725
---
M api/ApiPageTriageList.php
M i18n/en.json
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Mattflaschen: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/api/ApiPageTriageList.php b/api/ApiPageTriageList.php
index 90a4607..87b4b52 100644
--- a/api/ApiPageTriageList.php
+++ b/api/ApiPageTriageList.php
@@ -313,7 +313,7 @@
 */
protected function getExamplesMessages() {
return [
-   'action=pagetriagelist=1000=0'
+   
'action=pagetriagelist=100=0=1'
=> 'apihelp-pagetriagelist-example-1',
];
}
diff --git a/i18n/en.json b/i18n/en.json
index ea7014a..c8c5592 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -393,7 +393,7 @@
"apihelp-pagetriagelist-param-non_autoconfirmed_users": "Whether to 
show only pages created by non auto confirmed users.",
"apihelp-pagetriagelist-param-blocked_users": "Whether to show only 
pages created by blocked users.",
"apihelp-pagetriagelist-param-username": "Show only pages created by 
username.",
-   "apihelp-pagetriagelist-example-1": "List 1000 pages in namespace 0",
+   "apihelp-pagetriagelist-example-1": "List 100 unreviewed pages in 
namespace 0",
"apihelp-pagetriagestats-description": "Get the stats for page triage.",
"apihelp-pagetriagestats-param-namespace": "What namespace to pull 
stats from.",
"apihelp-pagetriagestats-param-showredirs": "Whether to include 
redirects.",

-- 
To view, visit https://gerrit.wikimedia.org/r/330266
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I29b0c600dc49384967491aa7d9a208c987a09725
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageTriage
Gerrit-Branch: master
Gerrit-Owner: Catrope 
Gerrit-Reviewer: Mattflaschen 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PageTriage[master]: ApiPageTriageList: Better document parameter weirdness

2017-01-03 Thread Catrope (Code Review) 
Catrope has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/330266 )

Change subject: ApiPageTriageList: Better document parameter weirdness
..

ApiPageTriageList: Better document parameter weirdness

The provided example doesn't work because apparently you need
at least one of showreviewed=1 and showunreviewed=1 to get
any results at all.

It is not best-practice api.php module design to have
action=foo without any further parameters return nothing,
but it's 5 years too late to fix it now.

Bug: T154115
Change-Id: I29b0c600dc49384967491aa7d9a208c987a09725
---
M api/ApiPageTriageList.php
M i18n/en.json
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageTriage 
refs/changes/66/330266/1

diff --git a/api/ApiPageTriageList.php b/api/ApiPageTriageList.php
index 90a4607..87b4b52 100644
--- a/api/ApiPageTriageList.php
+++ b/api/ApiPageTriageList.php
@@ -313,7 +313,7 @@
 */
protected function getExamplesMessages() {
return [
-   'action=pagetriagelist=1000=0'
+   
'action=pagetriagelist=100=0=1'
=> 'apihelp-pagetriagelist-example-1',
];
}
diff --git a/i18n/en.json b/i18n/en.json
index ea7014a..c8c5592 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -393,7 +393,7 @@
"apihelp-pagetriagelist-param-non_autoconfirmed_users": "Whether to 
show only pages created by non auto confirmed users.",
"apihelp-pagetriagelist-param-blocked_users": "Whether to show only 
pages created by blocked users.",
"apihelp-pagetriagelist-param-username": "Show only pages created by 
username.",
-   "apihelp-pagetriagelist-example-1": "List 1000 pages in namespace 0",
+   "apihelp-pagetriagelist-example-1": "List 100 unreviewed pages in 
namespace 0",
"apihelp-pagetriagestats-description": "Get the stats for page triage.",
"apihelp-pagetriagestats-param-namespace": "What namespace to pull 
stats from.",
"apihelp-pagetriagestats-param-showredirs": "Whether to include 
redirects.",

-- 
To view, visit https://gerrit.wikimedia.org/r/330266
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I29b0c600dc49384967491aa7d9a208c987a09725
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageTriage
Gerrit-Branch: master
Gerrit-Owner: Catrope 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits