[MediaWiki-commits] [Gerrit] mediawiki...PageTriage[master]: Add a filter for learners (newly autoconfirmed users)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/391151 ) Change subject: Add a filter for learners (newly autoconfirmed users) .. Add a filter for learners (newly autoconfirmed users) Put the user's experience level in the DB as a string rather than as a learner/not-learner boolean, so it's easier to add filters for e.g. experienced users in the future. Bonus: actually run PageTriageTagsPatch.sql from update.php Bug: T175225 Change-Id: I27fd98fb8003525e6b512aaa5780b6375e0e6850 --- M PageTriage.hooks.php M SpecialNewPagesFeed.php M api/ApiPageTriageList.php M api/ApiPageTriageStats.php M extension.json M i18n/en.json M i18n/qqq.json M includes/ArticleMetadata.php M modules/ext.pageTriage.views.list/ext.pageTriage.listControlNav.js M sql/PageTriageTags.sql M sql/PageTriageTagsPatch.sql M tests/phpunit/ArticleMetadataTest.php 12 files changed, 46 insertions(+), 4 deletions(-) Approvals: jenkins-bot: Verified Jforrester: Looks good to me, but someone else must approve Kaldari: Looks good to me, approved diff --git a/PageTriage.hooks.php b/PageTriage.hooks.php index 733df56..2f395a5 100644 --- a/PageTriage.hooks.php +++ b/PageTriage.hooks.php @@ -839,6 +839,12 @@ 'ptrl_comment', $base . '/PageTriageLogPatch_Drop_ptrl_comment.sql' ); + $updater->addExtensionUpdate( [ + 'modifyTable', + 'pagetriage_tags', + $base . '/PageTriageTagsPatch.sql', + true + ] ); return true; } diff --git a/SpecialNewPagesFeed.php b/SpecialNewPagesFeed.php index f82775e..00181ab 100644 --- a/SpecialNewPagesFeed.php +++ b/SpecialNewPagesFeed.php @@ -245,6 +245,11 @@ <%= mw.msg( 'pagetriage-filter-non-autoconfirmed' ) %> + + <%= mw.msg( 'pagetriage-filter-learners' ) %> + + <%= mw.msg( 'pagetriage-filter-blocked' ) %> diff --git a/api/ApiPageTriageList.php b/api/ApiPageTriageList.php index c8766c7..036f8a4 100644 --- a/api/ApiPageTriageList.php +++ b/api/ApiPageTriageList.php @@ -238,6 +238,8 @@ 'no_inbound_links' => [ 'name' => 'linkcount', 'op' => '=', 'val' => '0' ], // non auto confirmed users 'non_autoconfirmed_users' => [ 'name' => 'user_autoconfirmed', 'op' => '=', 'val' => '0' ], + // learning users (newly autoconfirmed) + 'learners' => [ 'name' => 'user_experience', 'op' => '=', 'val' => 'learner' ], // blocked users 'blocked_users' => [ 'name' => 'user_block_status', 'op' => '=', 'val' => '1' ], // bots @@ -316,6 +318,9 @@ 'non_autoconfirmed_users' => [ ApiBase::PARAM_TYPE => 'boolean', ], + 'learners' => [ + ApiBase::PARAM_TYPE => 'boolean', + ], 'blocked_users' => [ ApiBase::PARAM_TYPE => 'boolean', ], diff --git a/api/ApiPageTriageStats.php b/api/ApiPageTriageStats.php index 228b46d..1e64621 100644 --- a/api/ApiPageTriageStats.php +++ b/api/ApiPageTriageStats.php @@ -56,6 +56,9 @@ 'non_autoconfirmed_users' => [ ApiBase::PARAM_TYPE => 'boolean', ], + 'learners' => [ + ApiBase::PARAM_TYPE => 'boolean', + ], 'blocked_users' => [ ApiBase::PARAM_TYPE => 'boolean', ], diff --git a/extension.json b/extension.json index 04f0e9c..ecfc0f5 100644 --- a/extension.json +++ b/extension.json @@ -262,6 +262,7 @@ "pagetriage-filter-no-categories", "pagetriage-filter-orphan", "pagetriage-filter-non-autoconfirmed", + "pagetriage-filter-learners",
[MediaWiki-commits] [Gerrit] mediawiki...PageTriage[master]: Add a filter for learners (newly autoconfirmed users)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391151 ) Change subject: Add a filter for learners (newly autoconfirmed users) .. Add a filter for learners (newly autoconfirmed users) Put the user's experience level in the DB as a string rather than as a learner/not-learner boolean, so it's easier to add filters for e.g. experienced users in the future. Bonus: actually run PageTriageTagsPatch.sql from update.php Bug: T175225 Change-Id: I27fd98fb8003525e6b512aaa5780b6375e0e6850 --- M PageTriage.hooks.php M SpecialNewPagesFeed.php M api/ApiPageTriageList.php M api/ApiPageTriageStats.php M extension.json M i18n/en.json M i18n/qqq.json M includes/ArticleMetadata.php M modules/ext.pageTriage.views.list/ext.pageTriage.listControlNav.js M sql/PageTriageTags.sql M sql/PageTriageTagsPatch.sql M tests/phpunit/ArticleMetadataTest.php 12 files changed, 41 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageTriage refs/changes/51/391151/1 diff --git a/PageTriage.hooks.php b/PageTriage.hooks.php index 733df56..2f395a5 100644 --- a/PageTriage.hooks.php +++ b/PageTriage.hooks.php @@ -839,6 +839,12 @@ 'ptrl_comment', $base . '/PageTriageLogPatch_Drop_ptrl_comment.sql' ); + $updater->addExtensionUpdate( [ + 'modifyTable', + 'pagetriage_tags', + $base . '/PageTriageTagsPatch.sql', + true + ] ); return true; } diff --git a/SpecialNewPagesFeed.php b/SpecialNewPagesFeed.php index f82775e..00181ab 100644 --- a/SpecialNewPagesFeed.php +++ b/SpecialNewPagesFeed.php @@ -245,6 +245,11 @@ <%= mw.msg( 'pagetriage-filter-non-autoconfirmed' ) %> + + <%= mw.msg( 'pagetriage-filter-learners' ) %> + + <%= mw.msg( 'pagetriage-filter-blocked' ) %> diff --git a/api/ApiPageTriageList.php b/api/ApiPageTriageList.php index c8766c7..036f8a4 100644 --- a/api/ApiPageTriageList.php +++ b/api/ApiPageTriageList.php @@ -238,6 +238,8 @@ 'no_inbound_links' => [ 'name' => 'linkcount', 'op' => '=', 'val' => '0' ], // non auto confirmed users 'non_autoconfirmed_users' => [ 'name' => 'user_autoconfirmed', 'op' => '=', 'val' => '0' ], + // learning users (newly autoconfirmed) + 'learners' => [ 'name' => 'user_experience', 'op' => '=', 'val' => 'learner' ], // blocked users 'blocked_users' => [ 'name' => 'user_block_status', 'op' => '=', 'val' => '1' ], // bots @@ -316,6 +318,9 @@ 'non_autoconfirmed_users' => [ ApiBase::PARAM_TYPE => 'boolean', ], + 'learners' => [ + ApiBase::PARAM_TYPE => 'boolean', + ], 'blocked_users' => [ ApiBase::PARAM_TYPE => 'boolean', ], diff --git a/api/ApiPageTriageStats.php b/api/ApiPageTriageStats.php index 228b46d..1e64621 100644 --- a/api/ApiPageTriageStats.php +++ b/api/ApiPageTriageStats.php @@ -56,6 +56,9 @@ 'non_autoconfirmed_users' => [ ApiBase::PARAM_TYPE => 'boolean', ], + 'learners' => [ + ApiBase::PARAM_TYPE => 'boolean', + ], 'blocked_users' => [ ApiBase::PARAM_TYPE => 'boolean', ], diff --git a/extension.json b/extension.json index 04f0e9c..ecfc0f5 100644 --- a/extension.json +++ b/extension.json @@ -262,6 +262,7 @@ "pagetriage-filter-no-categories", "pagetriage-filter-orphan", "pagetriage-filter-non-autoconfirmed", + "pagetriage-filter-learners", "pagetriage-filter-blocked",
