[MediaWiki-commits] [Gerrit] mediawiki...ParserMigration[master]: Don't run tidy twice

2017-04-04 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/346242 )

Change subject: Don't run tidy twice
..


Don't run tidy twice

It defeats the purpose.

Change-Id: Ie6de3842731da2a2d74af03a42de0632085b4c6b
---
M includes/MigrationEditPage.php
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Subramanya Sastry: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/MigrationEditPage.php b/includes/MigrationEditPage.php
index dc015d7..a42ad14 100644
--- a/includes/MigrationEditPage.php
+++ b/includes/MigrationEditPage.php
@@ -24,6 +24,12 @@
return true;
}
 
+   protected function getPreviewParserOptions() {
+   $parserOptions = parent::getPreviewParserOptions();
+   $parserOptions->setTidy( false );
+   return $parserOptions;
+   }
+
protected function doPreviewParse( \Content $content ) {
$user = $this->context->getUser();
$parserOptions = $this->getPreviewParserOptions();

-- 
To view, visit https://gerrit.wikimedia.org/r/346242
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6de3842731da2a2d74af03a42de0632085b4c6b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ParserMigration
Gerrit-Branch: master
Gerrit-Owner: Tim Starling 
Gerrit-Reviewer: Subramanya Sastry 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ParserMigration[master]: Don't run tidy twice

2017-04-04 Thread Tim Starling (Code Review) 
Tim Starling has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/346242 )

Change subject: Don't run tidy twice
..

Don't run tidy twice

It defeats the purpose.

Change-Id: Ie6de3842731da2a2d74af03a42de0632085b4c6b
---
M includes/MigrationEditPage.php
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ParserMigration 
refs/changes/42/346242/1

diff --git a/includes/MigrationEditPage.php b/includes/MigrationEditPage.php
index dc015d7..a42ad14 100644
--- a/includes/MigrationEditPage.php
+++ b/includes/MigrationEditPage.php
@@ -24,6 +24,12 @@
return true;
}
 
+   protected function getPreviewParserOptions() {
+   $parserOptions = parent::getPreviewParserOptions();
+   $parserOptions->setTidy( false );
+   return $parserOptions;
+   }
+
protected function doPreviewParse( \Content $content ) {
$user = $this->context->getUser();
$parserOptions = $this->getPreviewParserOptions();

-- 
To view, visit https://gerrit.wikimedia.org/r/346242
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6de3842731da2a2d74af03a42de0632085b4c6b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ParserMigration
Gerrit-Branch: master
Gerrit-Owner: Tim Starling 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits