[MediaWiki-commits] [Gerrit] mediawiki...PollNY[master]: Fix E_WARNING after moving a page under MW 1.28

2016-11-29 Thread Jack Phoenix (Code Review) 
Jack Phoenix has submitted this change and it was merged.

Change subject: Fix E_WARNING after moving a page under MW 1.28
..


Fix E_WARNING after moving a page under MW 1.28

Warning: Parameter 3 to PollNYHooks::updatePollQuestion() expected to be a
reference, value given in ..\includes\Hooks.php on line 195

I'm not sure why this fixes it, but it does...

Change-Id: If81f74ac09632d84e9b93a0041600cd41538bebd
---
M PollNYHooks.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jack Phoenix: Verified; Looks good to me, approved



diff --git a/PollNYHooks.php b/PollNYHooks.php
index e997d78..fe8d704 100644
--- a/PollNYHooks.php
+++ b/PollNYHooks.php
@@ -20,7 +20,7 @@
 * @param $newid Integer: new ID of the page [unused]
 * @return Boolean: true
 */
-   public static function updatePollQuestion( &$title, &$newTitle, &$user, 
$oldid, $newid ) {
+   public static function updatePollQuestion( &$title, &$newTitle, $user, 
$oldid, $newid ) {
if( $title->getNamespace() == NS_POLL ) {
$dbw = wfGetDB( DB_MASTER );
$dbw->update(

-- 
To view, visit https://gerrit.wikimedia.org/r/324331
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If81f74ac09632d84e9b93a0041600cd41538bebd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PollNY
Gerrit-Branch: master
Gerrit-Owner: Jack Phoenix 
Gerrit-Reviewer: Jack Phoenix 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PollNY[master]: Fix E_WARNING after moving a page under MW 1.28

2016-11-29 Thread Jack Phoenix (Code Review) 
Jack Phoenix has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/324331

Change subject: Fix E_WARNING after moving a page under MW 1.28
..

Fix E_WARNING after moving a page under MW 1.28

Warning: Parameter 3 to PollNYHooks::updatePollQuestion() expected to be a
reference, value given in ..\includes\Hooks.php on line 195

I'm not sure why this fixes it, but it does...

Change-Id: If81f74ac09632d84e9b93a0041600cd41538bebd
---
M PollNYHooks.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PollNY 
refs/changes/31/324331/1

diff --git a/PollNYHooks.php b/PollNYHooks.php
index e997d78..fe8d704 100644
--- a/PollNYHooks.php
+++ b/PollNYHooks.php
@@ -20,7 +20,7 @@
 * @param $newid Integer: new ID of the page [unused]
 * @return Boolean: true
 */
-   public static function updatePollQuestion( &$title, &$newTitle, &$user, 
$oldid, $newid ) {
+   public static function updatePollQuestion( &$title, &$newTitle, $user, 
$oldid, $newid ) {
if( $title->getNamespace() == NS_POLL ) {
$dbw = wfGetDB( DB_MASTER );
$dbw->update(

-- 
To view, visit https://gerrit.wikimedia.org/r/324331
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If81f74ac09632d84e9b93a0041600cd41538bebd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PollNY
Gerrit-Branch: master
Gerrit-Owner: Jack Phoenix 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits