[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: eventLogging: Extract createAbandonEvent function

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/344389 )

Change subject: eventLogging: Extract createAbandonEvent function
..


eventLogging: Extract createAbandonEvent function

Reducer changes:
* Add tests for ABANDON_END case.
* Extract the body of the ABANDON_END case into the createAbandonEvent
  helper function.

Additional changes:
* totalInteractionProperty -> totalInteractionTime elsewhere in the same
  file.

Bug: T159490
Change-Id: Ifff34271395f330b83cfe487e84800fe2d6f3811
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/reducers/eventLogging.js
M tests/node-qunit/reducers/eventLogging.test.js
4 files changed, 162 insertions(+), 36 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jdlrobson: Looks good to me, approved




-- 
To view, visit https://gerrit.wikimedia.org/r/344389
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifff34271395f330b83cfe487e84800fe2d6f3811
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Jhernandez 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: eventLogging: Extract createAbandonEvent function

[Phuedx (Code Review)]

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/344389 )

Change subject: eventLogging: Extract createAbandonEvent function
..

eventLogging: Extract createAbandonEvent function

Reducer changes:
* Add tests for ABANDON_END case.
* Extract the body of the ABANDON_END case into the createAbandonEvent
  helper function.

Additional changes:
* totalInteractionProperty -> totalInteractionTime elsewhere in the same
  file.

Bug: T159490
Change-Id: Ifff34271395f330b83cfe487e84800fe2d6f3811
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/reducers/eventLogging.js
M tests/node-qunit/reducers/eventLogging.test.js
4 files changed, 162 insertions(+), 36 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/89/344389/1


-- 
To view, visit https://gerrit.wikimedia.org/r/344389
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifff34271395f330b83cfe487e84800fe2d6f3811
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits