[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Hygiene: Move EXTRACT_LENGTH to constants

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/338391 )

Change subject: Hygiene: Move EXTRACT_LENGTH to constants
..


Hygiene: Move EXTRACT_LENGTH to constants

Keep all configuration-like values in one file.
Changes:
 - moved EXTRACT_LENGTH to constants.js file

Change-Id: Ibe5ecfc60f2c09a30a9ecb3586bc5fb6a7365476
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/constants.js
M src/gateway/mediawiki.js
M tests/node-qunit/gateway/mediawiki.test.js
5 files changed, 13 insertions(+), 12 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jdlrobson: Looks good to me, approved




-- 
To view, visit https://gerrit.wikimedia.org/r/338391
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe5ecfc60f2c09a30a9ecb3586bc5fb6a7365476
Gerrit-PatchSet: 7
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Pmiazga 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Jhernandez 
Gerrit-Reviewer: Phuedx 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Hygiene: Move EXTRACT_LENGTH to constants

[Pmiazga (Code Review)]

Pmiazga has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/338164 )

Change subject: Hygiene: Move EXTRACT_LENGTH to constants
..

Hygiene: Move EXTRACT_LENGTH to constants

Keep all configuration-like values in one file.
Changes:
 - moved EXTRACT_LENGTH to constants.js file

Change-Id: Ie7d29ddc12db4a86c99dc70a2e7f7696b67570bb
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/constants.js
M src/gateway/mediawiki.js
M tests/qunit/ext.popups/gateway/mediawiki.test.js
5 files changed, 14 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/64/338164/1


-- 
To view, visit https://gerrit.wikimedia.org/r/338164
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie7d29ddc12db4a86c99dc70a2e7f7696b67570bb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Pmiazga 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits