[MediaWiki-commits] [Gerrit] mediawiki...ProofreadPage[master]: Adds Page: pages outputted by tag as dependenc...

2017-01-10 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/301924 )

Change subject: Adds Page: pages outputted by  tag as dependencies 
of the current page
..


Adds Page: pages outputted by  tag as dependencies of the current 
page

Warning: it may be very expensive, especially with this implementation as its 
could add hundreds of new dependencies and of DB lookups to a given Index: page.

Bug: T114318
Change-Id: I8b8dbf0a1c8102a3543da28814877eec461b07d2
---
M includes/Parser/PagelistTagParser.php
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Tpt: Looks good to me, approved



diff --git a/includes/Parser/PagelistTagParser.php 
b/includes/Parser/PagelistTagParser.php
index 76d1117..4c359ce 100644
--- a/includes/Parser/PagelistTagParser.php
+++ b/includes/Parser/PagelistTagParser.php
@@ -75,6 +75,12 @@
if ( $pageNumber->isEmpty() || !$title ) {
$return .= $view . ' ';
} else {
+   // Adds the page as a dependency in order to 
make sure that the Index: page is purged if the status of the Page: page changes
+   $this->parser->getOutput()->addTemplate(
+   $pageTitle,
+   $pageTitle->getArticleID(),
+   $pageTitle->getLatestRevID()
+   );
$return .= '[[' . $pageTitle->getPrefixedText() 
. '|' . $view . ']] '; // TODO: use linker?
}
}

-- 
To view, visit https://gerrit.wikimedia.org/r/301924
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8b8dbf0a1c8102a3543da28814877eec461b07d2
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Tpt 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: Tpt 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ProofreadPage[master]: Adds Page: pages outputted by tag as dependenc...

2016-07-30 Thread Tpt (Code Review) 
Tpt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/301924

Change subject: Adds Page: pages outputted by  tag as dependencies 
of the current page
..

Adds Page: pages outputted by  tag as dependencies of the current 
page

Warning: it may be very expensive, especially with this implementation as its 
could add hundreds of new dependencies and of DB lookups to a given Index: page.

Bug: T114318
Change-Id: I8b8dbf0a1c8102a3543da28814877eec461b07d2
---
M includes/Parser/PagelistTagParser.php
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage 
refs/changes/24/301924/1

diff --git a/includes/Parser/PagelistTagParser.php 
b/includes/Parser/PagelistTagParser.php
index 76d1117..5bd210f 100644
--- a/includes/Parser/PagelistTagParser.php
+++ b/includes/Parser/PagelistTagParser.php
@@ -75,6 +75,12 @@
if ( $pageNumber->isEmpty() || !$title ) {
$return .= $view . ' ';
} else {
+   // Add the page as a dependence in order to make 
sure that the Index: page is purged if the status of the Page: page changes
+   $this->parser->getOutput()->addTemplate(
+   $pageTitle,
+$pageTitle->getArticleID(),
+$pageTitle->getLatestRevID()
+);
$return .= '[[' . $pageTitle->getPrefixedText() 
. '|' . $view . ']] '; // TODO: use linker?
}
}

-- 
To view, visit https://gerrit.wikimedia.org/r/301924
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b8dbf0a1c8102a3543da28814877eec461b07d2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Tpt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits