[MediaWiki-commits] [Gerrit] mediawiki...Quiz[master]: Define all variables that are sent to process tepmlate

2017-06-11 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/358228 )

Change subject: Define all variables that are sent to process tepmlate
..


Define all variables that are sent to process tepmlate

ProcessTemplate cannot handle undefined variables.This change ensures that
all variables that are being sent to process template are defined.

Bug:T167587
Change-Id: Ic84c38e97baed2d46eefcec555ce4ab0f9191701
---
M Question.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Mvolz: Looks good to me, approved



diff --git a/Question.php b/Question.php
index 952e853..52f60aa 100644
--- a/Question.php
+++ b/Question.php
@@ -354,7 +354,7 @@
function parseTextField( $input ) {
global $wqInputId;
$wqInputId++;
-   $title = $state = $size = $maxlength = $class = $style = $value 
= $disabled = $big = '';
+   $title = $state = $size = $maxlength = $class = $style = $value 
= $disabled = $big = $poss = $name = $bigDisplay = '';
// determine size and maxlength of the input.
if ( array_key_exists( 3, $input ) ) {
$size = $input[3];

-- 
To view, visit https://gerrit.wikimedia.org/r/358228
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic84c38e97baed2d46eefcec555ce4ab0f9191701
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Quiz
Gerrit-Branch: master
Gerrit-Owner: Harjotsingh 
Gerrit-Reviewer: Harjotsingh 
Gerrit-Reviewer: Mvolz 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Quiz[master]: Define all variables that are sent to process tepmlate

2017-06-11 Thread Harjotsingh (Code Review) 
Harjotsingh has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/358228 )

Change subject: Define all variables that are sent to process tepmlate
..

Define all variables that are sent to process tepmlate

ProcessTemplate cannot handle undefined variables.This change ensures that
all variables that are being sent to process template are defined.

Bug:T167587
Change-Id: Ic84c38e97baed2d46eefcec555ce4ab0f9191701
---
M Question.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Quiz 
refs/changes/28/358228/1

diff --git a/Question.php b/Question.php
index 952e853..52f60aa 100644
--- a/Question.php
+++ b/Question.php
@@ -354,7 +354,7 @@
function parseTextField( $input ) {
global $wqInputId;
$wqInputId++;
-   $title = $state = $size = $maxlength = $class = $style = $value 
= $disabled = $big = '';
+   $title = $state = $size = $maxlength = $class = $style = $value 
= $disabled = $big = $poss = $name = $bigDisplay = '';
// determine size and maxlength of the input.
if ( array_key_exists( 3, $input ) ) {
$size = $input[3];

-- 
To view, visit https://gerrit.wikimedia.org/r/358228
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic84c38e97baed2d46eefcec555ce4ab0f9191701
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Quiz
Gerrit-Branch: master
Gerrit-Owner: Harjotsingh 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits