[MediaWiki-commits] [Gerrit] mediawiki...Refreshed[master]: Remove old Echo fixes
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/372489 )
Change subject: Remove old Echo fixes
..
Remove old Echo fixes
Theese arn't really necessary and they prevent the badges from being seen on
Mobile on 1.29+. I can confirm that nothing is broken when I remove theese.
Bug: T170773
Change-Id: I6ce6d298575a72b158724c92bb59180ccbbbf3b2
---
M refreshed/styles/screen/medium.css
M refreshed/styles/screen/small.css
M skin.json
3 files changed, 1 insertion(+), 60 deletions(-)
Approvals:
SamanthaNguyen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/refreshed/styles/screen/medium.css
b/refreshed/styles/screen/medium.css
index cd2b1c5..c229f6f 100644
--- a/refreshed/styles/screen/medium.css
+++ b/refreshed/styles/screen/medium.css
@@ -129,16 +129,6 @@
font-size: 1.313em !important;
}
-/* Extension:Echo fixes */
-#pt-notifications {
- margin-right: 0.75em;
-}
-
-.mw-echo-overlay:before,
-.mw-echo-overlay::before {
- left: 238px !important; /* centering dropdown arrow on notifications
badge */
-}
-
/* Image thumbnails */
.thumb {
width: 100% !important;
diff --git a/refreshed/styles/screen/small.css
b/refreshed/styles/screen/small.css
index ad2b753..b5cf798 100644
--- a/refreshed/styles/screen/small.css
+++ b/refreshed/styles/screen/small.css
@@ -357,55 +357,6 @@
border: 0 !important;
}
-/* Extension:Echo fixes */
-
-#pt-mytalk a.mw-echo-alert { /* "you have new messages" alert in the personal
tools dropdown */
- margin: 0.1em;
-}
-
-#pt-notifications-personaltools { /* "Notifications" item in the personal
tools dropdown */
- display: list-item;
-}
-
-.pt-notifications-personaltools-unread {
- background-color: #c00;
- color: #fff;
- border-radius: 2px; /* matching the notification badge itself and the
"you have new messages" notice, which both have border-radius */
- margin: 0.1em;
-}
-
-.pt-notifications-personaltools-unread:hover {
- background-color: #bf !important;
-}
-
-#pt-notifications {
- position: absolute;
- margin: 0;
- top: 0; /* the container height is greater than that of the
notification button itself so this still leaves some space above the button */
- right: 2.9em; /* 2.75em for the search button, 0.25em of padding within
user button */
- max-width: 2.25em; /* 2.75em (width of user button) - 0.25em of padding
on each side */
- z-index: 1; /* above user button */
- padding: 0;
- width: auto;
- pointer-events: none; /* prevent click event (stop notifications
dropdown from appearing on click) */
-}
-
-.mw-echo-notifications-badge {
- font-size: 0.5em;
- min-width: 3.5px; /* min-width of 7px * 0.5em (stops badge from looking
too wide when it contains a single-digit number) */
- max-width: 2.25em; /* (2.75em (width of user button) - 0.25em of
padding on each side) * 2 because the font size is 0.5em */
- overflow: hidden;
- display: none; /* hide if there are no noticiations */
-}
-
-.mw-echo-unread-notifications {
- display: inline;
-}
-
-.mw-echo-overlay {
- display: none; /* if pointer-events isn't supported (so
#mw-echo-overlay is generated when the notifications badge is clicked), hide
#mw-echo-overlay so it's not visible */
-}
-
/* Image thumbnails */
.thumb {
width: 100% !important;
diff --git a/skin.json b/skin.json
index 216a78b..a677559 100755
--- a/skin.json
+++ b/skin.json
@@ -1,6 +1,6 @@
{
"name": "Refreshed",
- "version": "3.3.5",
+ "version": "3.3.6",
"author": [
"Adam Carter",
"Drew1200",
--
To view, visit https://gerrit.wikimedia.org/r/372489
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ce6d298575a72b158724c92bb59180ccbbbf3b2
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/skins/Refreshed
Gerrit-Branch: master
Gerrit-Owner: MacFan4000
Gerrit-Reviewer: Ajraddatz
Gerrit-Reviewer: GeorgeBarnick
Gerrit-Reviewer: Jack Phoenix
Gerrit-Reviewer: Lewis Cawte
Gerrit-Reviewer: MtMNC
Gerrit-Reviewer: SamanthaNguyen
Gerrit-Reviewer: SamanthaNguyen
Gerrit-Reviewer: Seaside98
Gerrit-Reviewer: SirComputer
Gerrit-Reviewer: UltrasonicNXT
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...Refreshed[master]: Remove old Echo fixes
MacFan4000 has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372489 )
Change subject: Remove old Echo fixes
..
Remove old Echo fixes
Theese arn't really necessary and they prevent the badges from being seen on
Mobile on 1.29+. I can confirm that nothing is broken when I remove theese.
Bug: T170773
Change-Id: I6ce6d298575a72b158724c92bb59180ccbbbf3b2
---
M refreshed/styles/screen/medium.css
M refreshed/styles/screen/small.css
M skin.json
3 files changed, 1 insertion(+), 60 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Refreshed
refs/changes/89/372489/1
diff --git a/refreshed/styles/screen/medium.css
b/refreshed/styles/screen/medium.css
index cd2b1c5..c229f6f 100644
--- a/refreshed/styles/screen/medium.css
+++ b/refreshed/styles/screen/medium.css
@@ -129,16 +129,6 @@
font-size: 1.313em !important;
}
-/* Extension:Echo fixes */
-#pt-notifications {
- margin-right: 0.75em;
-}
-
-.mw-echo-overlay:before,
-.mw-echo-overlay::before {
- left: 238px !important; /* centering dropdown arrow on notifications
badge */
-}
-
/* Image thumbnails */
.thumb {
width: 100% !important;
diff --git a/refreshed/styles/screen/small.css
b/refreshed/styles/screen/small.css
index ad2b753..b5cf798 100644
--- a/refreshed/styles/screen/small.css
+++ b/refreshed/styles/screen/small.css
@@ -357,55 +357,6 @@
border: 0 !important;
}
-/* Extension:Echo fixes */
-
-#pt-mytalk a.mw-echo-alert { /* "you have new messages" alert in the personal
tools dropdown */
- margin: 0.1em;
-}
-
-#pt-notifications-personaltools { /* "Notifications" item in the personal
tools dropdown */
- display: list-item;
-}
-
-.pt-notifications-personaltools-unread {
- background-color: #c00;
- color: #fff;
- border-radius: 2px; /* matching the notification badge itself and the
"you have new messages" notice, which both have border-radius */
- margin: 0.1em;
-}
-
-.pt-notifications-personaltools-unread:hover {
- background-color: #bf !important;
-}
-
-#pt-notifications {
- position: absolute;
- margin: 0;
- top: 0; /* the container height is greater than that of the
notification button itself so this still leaves some space above the button */
- right: 2.9em; /* 2.75em for the search button, 0.25em of padding within
user button */
- max-width: 2.25em; /* 2.75em (width of user button) - 0.25em of padding
on each side */
- z-index: 1; /* above user button */
- padding: 0;
- width: auto;
- pointer-events: none; /* prevent click event (stop notifications
dropdown from appearing on click) */
-}
-
-.mw-echo-notifications-badge {
- font-size: 0.5em;
- min-width: 3.5px; /* min-width of 7px * 0.5em (stops badge from looking
too wide when it contains a single-digit number) */
- max-width: 2.25em; /* (2.75em (width of user button) - 0.25em of
padding on each side) * 2 because the font size is 0.5em */
- overflow: hidden;
- display: none; /* hide if there are no noticiations */
-}
-
-.mw-echo-unread-notifications {
- display: inline;
-}
-
-.mw-echo-overlay {
- display: none; /* if pointer-events isn't supported (so
#mw-echo-overlay is generated when the notifications badge is clicked), hide
#mw-echo-overlay so it's not visible */
-}
-
/* Image thumbnails */
.thumb {
width: 100% !important;
diff --git a/skin.json b/skin.json
index 75f7f9e..216a78b 100755
--- a/skin.json
+++ b/skin.json
@@ -1,6 +1,6 @@
{
"name": "Refreshed",
- "version": "3.3.4",
+ "version": "3.3.5",
"author": [
"Adam Carter",
"Drew1200",
--
To view, visit https://gerrit.wikimedia.org/r/372489
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ce6d298575a72b158724c92bb59180ccbbbf3b2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Refreshed
Gerrit-Branch: master
Gerrit-Owner: MacFan4000
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
