[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: build: Update eslint and stylelint

2017-10-09 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/383139 )

Change subject: build: Update eslint and stylelint
..


build: Update eslint and stylelint

Change-Id: I82bfb5fbfea4997f3048305574d2ff7d28ecd1b8
---
M package.json
M resources/ext.relatedArticles.cards/CardModel.js
M resources/ext.relatedArticles.readMore.gateway/RelatedPagesGateway.js
M tests/qunit/ext.relatedArticles.readMore.gateway/test_RelatedPagesGateway.js
4 files changed, 6 insertions(+), 6 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/package.json b/package.json
index eb10f3d..e5a4f66 100644
--- a/package.json
+++ b/package.json
@@ -4,12 +4,12 @@
 "test": "grunt test"
   },
   "devDependencies": {
-"eslint-config-wikimedia": "0.4.0",
+"eslint-config-wikimedia": "0.5.0",
 "grunt": "1.0.1",
 "grunt-banana-checker": "0.6.0",
-"grunt-eslint": "19.0.0",
+"grunt-eslint": "20.0.0",
 "grunt-jsonlint": "1.1.0",
-"grunt-stylelint": "0.7.0",
+"grunt-stylelint": "0.8.0",
 "stylelint": "7.8.0",
 "stylelint-config-wikimedia": "0.4.1"
   }
diff --git a/resources/ext.relatedArticles.cards/CardModel.js 
b/resources/ext.relatedArticles.cards/CardModel.js
index 3210687..ac12a4b 100644
--- a/resources/ext.relatedArticles.cards/CardModel.js
+++ b/resources/ext.relatedArticles.cards/CardModel.js
@@ -13,7 +13,7 @@
 *  an article
 */
function CardModel( attributes ) {
-   CardModel[ 'super' ].apply( this, arguments );
+   CardModel.super.apply( this, arguments );
/**
 * @property {Object} attributes of the model
 */
diff --git 
a/resources/ext.relatedArticles.readMore.gateway/RelatedPagesGateway.js 
b/resources/ext.relatedArticles.readMore.gateway/RelatedPagesGateway.js
index 5bb8b16..737e345 100644
--- a/resources/ext.relatedArticles.readMore.gateway/RelatedPagesGateway.js
+++ b/resources/ext.relatedArticles.readMore.gateway/RelatedPagesGateway.js
@@ -76,7 +76,7 @@
 
if ( relatedPages.length ) {
parameters.pilimit = relatedPages.length;
-   parameters[ 'continue' ] = ''; // jscs:ignore 
requireDotNotation
+   parameters.continue = '';
 
parameters.titles = relatedPages;
} else if ( this.useCirrusSearch ) {
diff --git 
a/tests/qunit/ext.relatedArticles.readMore.gateway/test_RelatedPagesGateway.js 
b/tests/qunit/ext.relatedArticles.readMore.gateway/test_RelatedPagesGateway.js
index 65eace4..36959a3 100644
--- 
a/tests/qunit/ext.relatedArticles.readMore.gateway/test_RelatedPagesGateway.js
+++ 
b/tests/qunit/ext.relatedArticles.readMore.gateway/test_RelatedPagesGateway.js
@@ -70,7 +70,7 @@
 
QUnit.test( 'When limit is higher than number of cards, no limit is 
enforced.', function ( assert ) {
var gateway = new RelatedPagesGateway( this.api, 'Foo', 
lotsaRelatedPages, true ),
-   // needed to get page images etc..
+   // needed to get page images etc..
stub = this.sandbox.stub( this.api, 'get' )
.returns( $.Deferred().resolve( relatedPages ) 
);
 

-- 
To view, visit https://gerrit.wikimedia.org/r/383139
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I82bfb5fbfea4997f3048305574d2ff7d28ecd1b8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RelatedArticles
Gerrit-Branch: master
Gerrit-Owner: Esanders 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Pmiazga 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: build: Update eslint and stylelint

2017-10-09 Thread Esanders (Code Review) 
Esanders has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/383139 )

Change subject: build: Update eslint and stylelint
..

build: Update eslint and stylelint

Change-Id: I82bfb5fbfea4997f3048305574d2ff7d28ecd1b8
---
M package.json
M resources/ext.relatedArticles.cards/CardModel.js
M resources/ext.relatedArticles.readMore.gateway/RelatedPagesGateway.js
M tests/qunit/ext.relatedArticles.readMore.gateway/test_RelatedPagesGateway.js
4 files changed, 6 insertions(+), 6 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RelatedArticles 
refs/changes/39/383139/1

diff --git a/package.json b/package.json
index eb10f3d..e5a4f66 100644
--- a/package.json
+++ b/package.json
@@ -4,12 +4,12 @@
 "test": "grunt test"
   },
   "devDependencies": {
-"eslint-config-wikimedia": "0.4.0",
+"eslint-config-wikimedia": "0.5.0",
 "grunt": "1.0.1",
 "grunt-banana-checker": "0.6.0",
-"grunt-eslint": "19.0.0",
+"grunt-eslint": "20.0.0",
 "grunt-jsonlint": "1.1.0",
-"grunt-stylelint": "0.7.0",
+"grunt-stylelint": "0.8.0",
 "stylelint": "7.8.0",
 "stylelint-config-wikimedia": "0.4.1"
   }
diff --git a/resources/ext.relatedArticles.cards/CardModel.js 
b/resources/ext.relatedArticles.cards/CardModel.js
index 3210687..ac12a4b 100644
--- a/resources/ext.relatedArticles.cards/CardModel.js
+++ b/resources/ext.relatedArticles.cards/CardModel.js
@@ -13,7 +13,7 @@
 *  an article
 */
function CardModel( attributes ) {
-   CardModel[ 'super' ].apply( this, arguments );
+   CardModel.super.apply( this, arguments );
/**
 * @property {Object} attributes of the model
 */
diff --git 
a/resources/ext.relatedArticles.readMore.gateway/RelatedPagesGateway.js 
b/resources/ext.relatedArticles.readMore.gateway/RelatedPagesGateway.js
index 5bb8b16..737e345 100644
--- a/resources/ext.relatedArticles.readMore.gateway/RelatedPagesGateway.js
+++ b/resources/ext.relatedArticles.readMore.gateway/RelatedPagesGateway.js
@@ -76,7 +76,7 @@
 
if ( relatedPages.length ) {
parameters.pilimit = relatedPages.length;
-   parameters[ 'continue' ] = ''; // jscs:ignore 
requireDotNotation
+   parameters.continue = '';
 
parameters.titles = relatedPages;
} else if ( this.useCirrusSearch ) {
diff --git 
a/tests/qunit/ext.relatedArticles.readMore.gateway/test_RelatedPagesGateway.js 
b/tests/qunit/ext.relatedArticles.readMore.gateway/test_RelatedPagesGateway.js
index 65eace4..36959a3 100644
--- 
a/tests/qunit/ext.relatedArticles.readMore.gateway/test_RelatedPagesGateway.js
+++ 
b/tests/qunit/ext.relatedArticles.readMore.gateway/test_RelatedPagesGateway.js
@@ -70,7 +70,7 @@
 
QUnit.test( 'When limit is higher than number of cards, no limit is 
enforced.', function ( assert ) {
var gateway = new RelatedPagesGateway( this.api, 'Foo', 
lotsaRelatedPages, true ),
-   // needed to get page images etc..
+   // needed to get page images etc..
stub = this.sandbox.stub( this.api, 'get' )
.returns( $.Deferred().resolve( relatedPages ) 
);
 

-- 
To view, visit https://gerrit.wikimedia.org/r/383139
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I82bfb5fbfea4997f3048305574d2ff7d28ecd1b8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RelatedArticles
Gerrit-Branch: master
Gerrit-Owner: Esanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits