[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Update eslint and fix issues
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/365224 )
Change subject: Update eslint and fix issues
..
Update eslint and fix issues
Change-Id: I0e3ad763398430608c30bb22741a57c81b2b7062
---
M modules/ext.RevisionSlider.RevisionListView.js
M modules/ext.RevisionSlider.SliderView.js
M modules/ext.RevisionSlider.init.js
M package.json
4 files changed, 18 insertions(+), 18 deletions(-)
Approvals:
jenkins-bot: Verified
Andrew-WMDE: Looks good to me, approved
diff --git a/modules/ext.RevisionSlider.RevisionListView.js
b/modules/ext.RevisionSlider.RevisionListView.js
index d674d72..9d9a3b6 100644
--- a/modules/ext.RevisionSlider.RevisionListView.js
+++ b/modules/ext.RevisionSlider.RevisionListView.js
@@ -122,9 +122,9 @@
return 0;
}
return Math.ceil(
- ( this.maxRevisionHeight -
this.minRevisionHeight ) *
- Math.log( Math.abs( diffSize ) ) /
maxChangeSizeLogged
- ) + this.minRevisionHeight;
+ ( this.maxRevisionHeight -
this.minRevisionHeight ) *
+ Math.log( Math.abs( diffSize ) ) /
maxChangeSizeLogged ) +
+ this.minRevisionHeight;
},
/**
diff --git a/modules/ext.RevisionSlider.SliderView.js
b/modules/ext.RevisionSlider.SliderView.js
index a05aea0..093d02c 100644
--- a/modules/ext.RevisionSlider.SliderView.js
+++ b/modules/ext.RevisionSlider.SliderView.js
@@ -234,14 +234,14 @@
);
$pointerOlder.draggable( this.buildDraggableOptions(
- $revisions,
- '.mw-revslider-pointer-container-older'
- ) );
+ $revisions,
+ '.mw-revslider-pointer-container-older'
+ ) );
$pointerNewer.draggable( this.buildDraggableOptions(
- $revisions,
- '.mw-revslider-pointer-container-newer'
- ) );
+ $revisions,
+ '.mw-revslider-pointer-container-newer'
+ ) );
},
getOlderPointerPos: function () {
@@ -674,9 +674,9 @@
*/
calculateSliderContainerWidth: function () {
return Math.min(
- this.slider.getRevisions().getLength(),
-
mw.libs.revisionSlider.calculateRevisionsPerWindow( this.containerMargin +
this.outerMargin, this.revisionWidth )
- ) * this.revisionWidth;
+ this.slider.getRevisions().getLength(),
+
mw.libs.revisionSlider.calculateRevisionsPerWindow( this.containerMargin +
this.outerMargin, this.revisionWidth )
+ ) * this.revisionWidth;
},
/**
diff --git a/modules/ext.RevisionSlider.init.js
b/modules/ext.RevisionSlider.init.js
index e394c0f..e95356d 100644
--- a/modules/ext.RevisionSlider.init.js
+++ b/modules/ext.RevisionSlider.init.js
@@ -96,9 +96,10 @@
autoExpandButton.$element.children().attr(
'aria-label',
mw.msg( autoExpand ?
- 'revisionslider-turn-off-auto-expand-title' :
- 'revisionslider-turn-on-auto-expand-title'
- ) );
+ 'revisionslider-turn-off-auto-expand-title' :
+ 'revisionslider-turn-on-auto-expand-title'
+ )
+ );
autoExpandButton.connect( this, {
click: function () {
diff --git a/package.json b/package.json
index 8406b3d..042e82a 100644
--- a/package.json
+++ b/package.json
@@ -11,11 +11,10 @@
"test": "grunt test"
},
"devDependencies": {
- "eslint": "3.12.2",
- "eslint-config-wikimedia": "0.4.0",
"grunt": "1.0.1",
"grunt-banana-checker": "0.6.0",
- "grunt-eslint": "19.0.0",
+ "grunt-eslint": "20.0.0",
+ "eslint-config-wikimedia": "0.4.0",
"grunt-jsonlint": "1.1.0",
"grunt-stylelint": "0.7.0",
"stylelint-config-wikimedia": "0.4.1"
--
To view, visit https://gerrit.wikimedia.org/r/365224
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0e3ad763398430608c30bb22741a57c81b2b7062
Gerrit-PatchSet: 1
Gerrit-Project:
[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Update eslint and fix issues
WMDE-Fisch has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/365224 )
Change subject: Update eslint and fix issues
..
Update eslint and fix issues
Change-Id: I0e3ad763398430608c30bb22741a57c81b2b7062
---
M modules/ext.RevisionSlider.RevisionListView.js
M modules/ext.RevisionSlider.SliderView.js
M modules/ext.RevisionSlider.init.js
M package.json
4 files changed, 18 insertions(+), 18 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RevisionSlider
refs/changes/24/365224/1
diff --git a/modules/ext.RevisionSlider.RevisionListView.js
b/modules/ext.RevisionSlider.RevisionListView.js
index d674d72..9d9a3b6 100644
--- a/modules/ext.RevisionSlider.RevisionListView.js
+++ b/modules/ext.RevisionSlider.RevisionListView.js
@@ -122,9 +122,9 @@
return 0;
}
return Math.ceil(
- ( this.maxRevisionHeight -
this.minRevisionHeight ) *
- Math.log( Math.abs( diffSize ) ) /
maxChangeSizeLogged
- ) + this.minRevisionHeight;
+ ( this.maxRevisionHeight -
this.minRevisionHeight ) *
+ Math.log( Math.abs( diffSize ) ) /
maxChangeSizeLogged ) +
+ this.minRevisionHeight;
},
/**
diff --git a/modules/ext.RevisionSlider.SliderView.js
b/modules/ext.RevisionSlider.SliderView.js
index a05aea0..093d02c 100644
--- a/modules/ext.RevisionSlider.SliderView.js
+++ b/modules/ext.RevisionSlider.SliderView.js
@@ -234,14 +234,14 @@
);
$pointerOlder.draggable( this.buildDraggableOptions(
- $revisions,
- '.mw-revslider-pointer-container-older'
- ) );
+ $revisions,
+ '.mw-revslider-pointer-container-older'
+ ) );
$pointerNewer.draggable( this.buildDraggableOptions(
- $revisions,
- '.mw-revslider-pointer-container-newer'
- ) );
+ $revisions,
+ '.mw-revslider-pointer-container-newer'
+ ) );
},
getOlderPointerPos: function () {
@@ -674,9 +674,9 @@
*/
calculateSliderContainerWidth: function () {
return Math.min(
- this.slider.getRevisions().getLength(),
-
mw.libs.revisionSlider.calculateRevisionsPerWindow( this.containerMargin +
this.outerMargin, this.revisionWidth )
- ) * this.revisionWidth;
+ this.slider.getRevisions().getLength(),
+
mw.libs.revisionSlider.calculateRevisionsPerWindow( this.containerMargin +
this.outerMargin, this.revisionWidth )
+ ) * this.revisionWidth;
},
/**
diff --git a/modules/ext.RevisionSlider.init.js
b/modules/ext.RevisionSlider.init.js
index e394c0f..e95356d 100644
--- a/modules/ext.RevisionSlider.init.js
+++ b/modules/ext.RevisionSlider.init.js
@@ -96,9 +96,10 @@
autoExpandButton.$element.children().attr(
'aria-label',
mw.msg( autoExpand ?
- 'revisionslider-turn-off-auto-expand-title' :
- 'revisionslider-turn-on-auto-expand-title'
- ) );
+ 'revisionslider-turn-off-auto-expand-title' :
+ 'revisionslider-turn-on-auto-expand-title'
+ )
+ );
autoExpandButton.connect( this, {
click: function () {
diff --git a/package.json b/package.json
index 8406b3d..042e82a 100644
--- a/package.json
+++ b/package.json
@@ -11,11 +11,10 @@
"test": "grunt test"
},
"devDependencies": {
- "eslint": "3.12.2",
- "eslint-config-wikimedia": "0.4.0",
"grunt": "1.0.1",
"grunt-banana-checker": "0.6.0",
- "grunt-eslint": "19.0.0",
+ "grunt-eslint": "20.0.0",
+ "eslint-config-wikimedia": "0.4.0",
"grunt-jsonlint": "1.1.0",
"grunt-stylelint": "0.7.0",
"stylelint-config-wikimedia": "0.4.1"
--
To view, visit https://gerrit.wikimedia.org/r/365224
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e3ad763398430608c30bb22741a57c81b2b7062
Gerrit-PatchSet: 1
Gerrit-Project:
