[MediaWiki-commits] [Gerrit] mediawiki...Scribunto[master]: Move tests into tests/phpunit and remove UnitTestsList hook

2017-07-07 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/363894 )

Change subject: Move tests into tests/phpunit and remove UnitTestsList hook
..


Move tests into tests/phpunit and remove UnitTestsList hook

This takes advantage of extension.json's unit tests autodiscovery
mechanism.

Bug: T142120
Change-Id: Id526f3368fc73ba7e6ef1d793ea70ab05fbd9517
---
M common/Hooks.php
M extension.json
R tests/phpunit/engines/LuaCommon/CommonTest.php
R tests/phpunit/engines/LuaCommon/CommonTests-data-fail1.lua
R tests/phpunit/engines/LuaCommon/CommonTests-data-fail2.lua
R tests/phpunit/engines/LuaCommon/CommonTests-data-fail3.lua
R tests/phpunit/engines/LuaCommon/CommonTests-data-fail4.lua
R tests/phpunit/engines/LuaCommon/CommonTests-data-fail5.lua
R tests/phpunit/engines/LuaCommon/CommonTests-data.lua
R tests/phpunit/engines/LuaCommon/CommonTests-lib.lua
R tests/phpunit/engines/LuaCommon/CommonTests.lua
R tests/phpunit/engines/LuaCommon/HashLibraryTest.php
R tests/phpunit/engines/LuaCommon/HashLibraryTests.lua
R tests/phpunit/engines/LuaCommon/HtmlLibraryTest.php
R tests/phpunit/engines/LuaCommon/HtmlLibraryTests.lua
R tests/phpunit/engines/LuaCommon/LanguageLibraryTest.php
R tests/phpunit/engines/LuaCommon/LanguageLibraryTests.lua
R tests/phpunit/engines/LuaCommon/LibraryUtilTest.php
R tests/phpunit/engines/LuaCommon/LibraryUtilTests.lua
R tests/phpunit/engines/LuaCommon/LuaDataProvider.php
R tests/phpunit/engines/LuaCommon/LuaEngineTestBase.php
R tests/phpunit/engines/LuaCommon/LuaEnvironmentComparisonTest.php
R tests/phpunit/engines/LuaCommon/LuaInterpreterTest.php
R tests/phpunit/engines/LuaCommon/MessageLibraryTest.php
R tests/phpunit/engines/LuaCommon/MessageLibraryTests.lua
R tests/phpunit/engines/LuaCommon/SiteLibraryTest.php
R tests/phpunit/engines/LuaCommon/SiteLibraryTests.lua
R tests/phpunit/engines/LuaCommon/TestFramework.lua
R tests/phpunit/engines/LuaCommon/TextLibraryTest.php
R tests/phpunit/engines/LuaCommon/TextLibraryTests.lua
R tests/phpunit/engines/LuaCommon/TitleLibraryTest.php
R tests/phpunit/engines/LuaCommon/TitleLibraryTests.lua
R tests/phpunit/engines/LuaCommon/UriLibraryTest.php
R tests/phpunit/engines/LuaCommon/UriLibraryTests.lua
R tests/phpunit/engines/LuaCommon/UstringLibraryNormalizationTests.lua
R tests/phpunit/engines/LuaCommon/UstringLibraryPureLuaTest.php
R tests/phpunit/engines/LuaCommon/UstringLibraryTest.php
R tests/phpunit/engines/LuaCommon/UstringLibraryTests.lua
R tests/phpunit/engines/LuaCommon/luaParserTests.txt
R tests/phpunit/engines/LuaSandbox/LuaSandboxInterpreterTest.php
R tests/phpunit/engines/LuaSandbox/SandboxTest.php
R tests/phpunit/engines/LuaSandbox/SandboxTests.lua
R tests/phpunit/engines/LuaStandalone/LuaStandaloneInterpreterTest.php
R tests/phpunit/engines/LuaStandalone/StandaloneTest.php
R tests/phpunit/engines/LuaStandalone/StandaloneTests.lua
45 files changed, 5 insertions(+), 36 deletions(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified
  Jforrester: Looks good to me, but someone else must approve



diff --git a/common/Hooks.php b/common/Hooks.php
index abfbfa4..63b90cb 100644
--- a/common/Hooks.php
+++ b/common/Hooks.php
@@ -388,36 +388,6 @@
}
 
/**
-* @param array $files
-* @return bool
-*/
-   public static function unitTestsList( array &$files ) {
-   $tests = [
-   
'engines/LuaStandalone/LuaStandaloneInterpreterTest.php',
-   'engines/LuaStandalone/StandaloneTest.php',
-   'engines/LuaSandbox/LuaSandboxInterpreterTest.php',
-   'engines/LuaSandbox/SandboxTest.php',
-   'engines/LuaCommon/LuaEnvironmentComparisonTest.php',
-   'engines/LuaCommon/CommonTest.php',
-   'engines/LuaCommon/SiteLibraryTest.php',
-   'engines/LuaCommon/UriLibraryTest.php',
-   'engines/LuaCommon/UstringLibraryTest.php',
-   'engines/LuaCommon/MessageLibraryTest.php',
-   'engines/LuaCommon/TitleLibraryTest.php',
-   'engines/LuaCommon/TextLibraryTest.php',
-   'engines/LuaCommon/HtmlLibraryTest.php',
-   'engines/LuaCommon/HashLibraryTest.php',
-   'engines/LuaCommon/LanguageLibraryTest.php',
-   'engines/LuaCommon/UstringLibraryPureLuaTest.php',
-   'engines/LuaCommon/LibraryUtilTest.php',
-   ];
-   foreach ( $tests as $test ) {
-   $files[] = __DIR__ . '/../tests/' . $test;
-   }
-   return true;
-   }
-
-   /**
 * @param Article &$article
 * @param bool &$outputDone
 * @param bool &$pcache
diff --git a/extension.json b/extension.json
index

[MediaWiki-commits] [Gerrit] mediawiki...Scribunto[master]: Move tests into tests/phpunit and remove UnitTestsList hook

2017-07-07 Thread Legoktm (Code Review) 
Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/363894 )

Change subject: Move tests into tests/phpunit and remove UnitTestsList hook
..

Move tests into tests/phpunit and remove UnitTestsList hook

This takes advantage of extension.json's unit tests autodiscovery
mechanism.

Bug: T142120
Change-Id: Id526f3368fc73ba7e6ef1d793ea70ab05fbd9517
---
M common/Hooks.php
M extension.json
R tests/phpunit/engines/LuaCommon/CommonTest.php
R tests/phpunit/engines/LuaCommon/CommonTests-data-fail1.lua
R tests/phpunit/engines/LuaCommon/CommonTests-data-fail2.lua
R tests/phpunit/engines/LuaCommon/CommonTests-data-fail3.lua
R tests/phpunit/engines/LuaCommon/CommonTests-data-fail4.lua
R tests/phpunit/engines/LuaCommon/CommonTests-data-fail5.lua
R tests/phpunit/engines/LuaCommon/CommonTests-data.lua
R tests/phpunit/engines/LuaCommon/CommonTests-lib.lua
R tests/phpunit/engines/LuaCommon/CommonTests.lua
R tests/phpunit/engines/LuaCommon/HashLibraryTest.php
R tests/phpunit/engines/LuaCommon/HashLibraryTests.lua
R tests/phpunit/engines/LuaCommon/HtmlLibraryTest.php
R tests/phpunit/engines/LuaCommon/HtmlLibraryTests.lua
R tests/phpunit/engines/LuaCommon/LanguageLibraryTest.php
R tests/phpunit/engines/LuaCommon/LanguageLibraryTests.lua
R tests/phpunit/engines/LuaCommon/LibraryUtilTest.php
R tests/phpunit/engines/LuaCommon/LibraryUtilTests.lua
R tests/phpunit/engines/LuaCommon/LuaDataProvider.php
R tests/phpunit/engines/LuaCommon/LuaEngineTestBase.php
R tests/phpunit/engines/LuaCommon/LuaEnvironmentComparisonTest.php
R tests/phpunit/engines/LuaCommon/LuaInterpreterTest.php
R tests/phpunit/engines/LuaCommon/MessageLibraryTest.php
R tests/phpunit/engines/LuaCommon/MessageLibraryTests.lua
R tests/phpunit/engines/LuaCommon/SiteLibraryTest.php
R tests/phpunit/engines/LuaCommon/SiteLibraryTests.lua
R tests/phpunit/engines/LuaCommon/TestFramework.lua
R tests/phpunit/engines/LuaCommon/TextLibraryTest.php
R tests/phpunit/engines/LuaCommon/TextLibraryTests.lua
R tests/phpunit/engines/LuaCommon/TitleLibraryTest.php
R tests/phpunit/engines/LuaCommon/TitleLibraryTests.lua
R tests/phpunit/engines/LuaCommon/UriLibraryTest.php
R tests/phpunit/engines/LuaCommon/UriLibraryTests.lua
R tests/phpunit/engines/LuaCommon/UstringLibraryNormalizationTests.lua
R tests/phpunit/engines/LuaCommon/UstringLibraryPureLuaTest.php
R tests/phpunit/engines/LuaCommon/UstringLibraryTest.php
R tests/phpunit/engines/LuaCommon/UstringLibraryTests.lua
R tests/phpunit/engines/LuaCommon/luaParserTests.txt
R tests/phpunit/engines/LuaSandbox/LuaSandboxInterpreterTest.php
R tests/phpunit/engines/LuaSandbox/SandboxTest.php
R tests/phpunit/engines/LuaSandbox/SandboxTests.lua
R tests/phpunit/engines/LuaStandalone/LuaStandaloneInterpreterTest.php
R tests/phpunit/engines/LuaStandalone/StandaloneTest.php
R tests/phpunit/engines/LuaStandalone/StandaloneTests.lua
45 files changed, 5 insertions(+), 36 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Scribunto 
refs/changes/94/363894/1

diff --git a/common/Hooks.php b/common/Hooks.php
index abfbfa4..63b90cb 100644
--- a/common/Hooks.php
+++ b/common/Hooks.php
@@ -388,36 +388,6 @@
}
 
/**
-* @param array $files
-* @return bool
-*/
-   public static function unitTestsList( array &$files ) {
-   $tests = [
-   
'engines/LuaStandalone/LuaStandaloneInterpreterTest.php',
-   'engines/LuaStandalone/StandaloneTest.php',
-   'engines/LuaSandbox/LuaSandboxInterpreterTest.php',
-   'engines/LuaSandbox/SandboxTest.php',
-   'engines/LuaCommon/LuaEnvironmentComparisonTest.php',
-   'engines/LuaCommon/CommonTest.php',
-   'engines/LuaCommon/SiteLibraryTest.php',
-   'engines/LuaCommon/UriLibraryTest.php',
-   'engines/LuaCommon/UstringLibraryTest.php',
-   'engines/LuaCommon/MessageLibraryTest.php',
-   'engines/LuaCommon/TitleLibraryTest.php',
-   'engines/LuaCommon/TextLibraryTest.php',
-   'engines/LuaCommon/HtmlLibraryTest.php',
-   'engines/LuaCommon/HashLibraryTest.php',
-   'engines/LuaCommon/LanguageLibraryTest.php',
-   'engines/LuaCommon/UstringLibraryPureLuaTest.php',
-   'engines/LuaCommon/LibraryUtilTest.php',
-   ];
-   foreach ( $tests as $test ) {
-   $files[] = __DIR__ . '/../tests/' . $test;
-   }
-   return true;
-   }
-
-   /**
 * @param Article &$article
 * @param bool &$outputDone
 * @param bool &$pcache
diff --git a/extension.json b/extension.json
index 4f109bc..d04b6ba 100644
--- a/extension.json
+++