[MediaWiki-commits] [Gerrit] mediawiki...SiteSettings[master]: Allowed NULL value for more DB fields

2017-12-13 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/398119 )

Change subject: Allowed NULL value for more DB fields
..


Allowed NULL value for more DB fields

Change-Id: If33b86239fcd27064fcb57b614883edc0d6b24a9
---
M SiteSettings.sql
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Yaron Koren: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/SiteSettings.sql b/SiteSettings.sql
index bcf3139..65527ef 100644
--- a/SiteSettings.sql
+++ b/SiteSettings.sql
@@ -21,8 +21,8 @@
background_color varchar(20) default NULL,
sidebar_color varchar(20) default NULL,
sidebar_border_color varchar(20) NULL,
-   copyright_text varchar(255) NOT NULL,
-   copyright_url varchar(150) NOT NULL,
+   copyright_text varchar(255) default NULL,
+   copyright_url varchar(150) default NULL,
logo_file varchar(100) default NULL,
favicon_file varchar(50) default NULL,
viewing_policy_id int(11) NOT NULL,

-- 
To view, visit https://gerrit.wikimedia.org/r/398119
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If33b86239fcd27064fcb57b614883edc0d6b24a9
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/SiteSettings
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 
Gerrit-Reviewer: Yaron Koren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki...SiteSettings[master]: Allowed NULL value for more DB fields

2017-12-13 Thread Yaron Koren (Code Review)
Yaron Koren has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398119 )

Change subject: Allowed NULL value for more DB fields
..

Allowed NULL value for more DB fields

Change-Id: If33b86239fcd27064fcb57b614883edc0d6b24a9
---
M SiteSettings.sql
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SiteSettings 
refs/changes/19/398119/2

diff --git a/SiteSettings.sql b/SiteSettings.sql
index bcf3139..65527ef 100644
--- a/SiteSettings.sql
+++ b/SiteSettings.sql
@@ -21,8 +21,8 @@
background_color varchar(20) default NULL,
sidebar_color varchar(20) default NULL,
sidebar_border_color varchar(20) NULL,
-   copyright_text varchar(255) NOT NULL,
-   copyright_url varchar(150) NOT NULL,
+   copyright_text varchar(255) default NULL,
+   copyright_url varchar(150) default NULL,
logo_file varchar(100) default NULL,
favicon_file varchar(50) default NULL,
viewing_policy_id int(11) NOT NULL,

-- 
To view, visit https://gerrit.wikimedia.org/r/398119
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If33b86239fcd27064fcb57b614883edc0d6b24a9
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/SiteSettings
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits