[MediaWiki-commits] [Gerrit] mediawiki...ThrottleOverride[master]: Improve 'exemption applied' message
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/379696 )
Change subject: Improve 'exemption applied' message
..
Improve 'exemption applied' message
Change the message to link somewhere (Special:ThrottleOverrideList).
Also add an appropriate page title. Once again, most of this is c from
Special:Block.
Bug: T174186
Change-Id: I03276c79c11cc65d5c9e22f7a1441004af1a5bb1
---
M SpecialOverrideThrottle.php
M i18n/en.json
M i18n/qqq.json
3 files changed, 7 insertions(+), 3 deletions(-)
Approvals:
BryanDavis: Looks good to me, approved
jenkins-bot: Verified
diff --git a/SpecialOverrideThrottle.php b/SpecialOverrideThrottle.php
index b2a2739..7599ece 100644
--- a/SpecialOverrideThrottle.php
+++ b/SpecialOverrideThrottle.php
@@ -283,7 +283,9 @@
}
function onSuccess() {
- $this->getOutput()->addWikiMsg( 'throttleoverride-success' );
+ $out = $this->getOutput();
+ $out->setPageTitle( $this->msg( 'throttleoverride-success-sub'
) );
+ $out->addWikiMsg( 'throttleoverride-success', wfEscapeWikiText(
$this->target ) );
}
protected function getGroupName() {
diff --git a/i18n/en.json b/i18n/en.json
index 83f218b..e087d98 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -18,7 +18,8 @@
"throttleoverride-text": "Enter the IP address or range you want to
exempt from certain throttles, and how long the exemption should last for.\nAn
optional reason can be given for the logs.",
"throttleoverride-ipaddress": "IP address or range",
"throttleoverride-showlog": "This ip address or range has previously
been exempted from throttles. The log is provided below for reference.",
- "throttleoverride-success": "The exemption was applied.",
+ "throttleoverride-success": "The exemption for $1 was applied.\nSee the [[Special:ThrottleOverrideList|list of throttle overrides]] to
review exemptions.",
+ "throttleoverride-success-sub": "Throttle override succeeded",
"throttleoverride-types": "Throttle types:",
"throttleoverride-types-all": "All types",
"throttleoverride-types-actcreate": "Account creation",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 9a64997..31b4930 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -21,7 +21,8 @@
"throttleoverride-text": "Intro text on [[Special:OverrideThrottle]]",
"throttleoverride-ipaddress": "Label for the IP address field on
[[Special:OverrideThrottle]]",
"throttleoverride-showlog": "Shown when displaying an extract of the
throttleoverride log.",
- "throttleoverride-success": "Text displayed after a successful
submission on [[Special:OverrideThrottle]]",
+ "throttleoverride-success": "Text displayed after a successful
submission on [[Special:OverrideThrottle]].\n\nParameters:\n* $1 - the IP
address or range that was modified.",
+ "throttleoverride-success-sub": "Used as page title in
[[Special:ThrottleOverride]].\n\nThis message is the subject for the following
message:\n* {{msg-mw|throttleoverride-success}}",
"throttleoverride-types": "Label for the types of throttles that can be
overridden.\n{{Identical|Throttle type}}",
"throttleoverride-types-all": "Label for the throttle type representing
all types (used in [[Special:ThrottleOverrideList]]).\n{{Identical|All types}}",
"throttleoverride-types-actcreate": "Label for the throttle type for
account creations",
--
To view, visit https://gerrit.wikimedia.org/r/379696
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03276c79c11cc65d5c9e22f7a1441004af1a5bb1
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/ThrottleOverride
Gerrit-Branch: master
Gerrit-Owner: EddieGP
Gerrit-Reviewer: BryanDavis
Gerrit-Reviewer: Reedy
Gerrit-Reviewer: Siebrand
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...ThrottleOverride[master]: Improve 'exemption applied' message
EddieGP has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379696 )
Change subject: Improve 'exemption applied' message
..
Improve 'exemption applied' message
Change the message to link somewhere (Special:ThrottleOverrideList).
Also add an appropriate page title. Once again, most of this is c from
Special:Block.
Change-Id: I03276c79c11cc65d5c9e22f7a1441004af1a5bb1
---
M SpecialOverrideThrottle.php
M i18n/en.json
M i18n/qqq.json
3 files changed, 10 insertions(+), 4 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ThrottleOverride
refs/changes/96/379696/1
diff --git a/SpecialOverrideThrottle.php b/SpecialOverrideThrottle.php
index ee62d47..56f9cae 100644
--- a/SpecialOverrideThrottle.php
+++ b/SpecialOverrideThrottle.php
@@ -262,7 +262,9 @@
}
function onSuccess() {
- $this->getOutput()->addWikiMsg( 'throttleoverride-success' );
+ $out = $this->getOutput();
+ $out->setPageTitle( $this->msg( 'throttleoverride-success-sub'
) );
+ $out->addWikiMsg( 'throttleoverride-success', wfEscapeWikiText(
$this->target ) );
}
protected function getGroupName() {
diff --git a/i18n/en.json b/i18n/en.json
index 863f6de..dbbb3da 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -2,7 +2,8 @@
"@metadata": {
"authors": [
"Tyler Romeo ",
- "Glaisher"
+ "Glaisher",
+ "EddieGP"
]
},
"overridethrottle": "Override throttles",
@@ -13,7 +14,8 @@
"throttleoverride-legend": "Exemption information",
"throttleoverride-text": "Enter the IP address or range you want to
exempt from certain throttles, and how long the exemption should last for.\nAn
optional reason can be given for the logs.",
"throttleoverride-ipaddress": "IP address or range",
- "throttleoverride-success": "The exemption was applied.",
+ "throttleoverride-success": "The exemption for $1 was applied.\nSee the [[Special:ThrottleOverrideList|list of throttle overrides]] to
review exemptions.",
+ "throttleoverride-success-sub": "Throttle override succeeded",
"throttleoverride-types": "Throttle types:",
"throttleoverride-types-all": "All types",
"throttleoverride-types-actcreate": "Account creation",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index e6bf053..f0af201 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -5,7 +5,8 @@
"Umherirrender",
"Liuxinyu970226",
"Glaisher",
- "Robby"
+ "Robby",
+ "EddieGP"
]
},
"overridethrottle": "{{doc-special|OverrideThrottle}}",
@@ -17,6 +18,7 @@
"throttleoverride-text": "Intro text on [[Special:OverrideThrottle]]",
"throttleoverride-ipaddress": "Label for the IP address field on
[[Special:OverrideThrottle]]",
"throttleoverride-success": "Text displayed after a successful
submission on [[Special:OverrideThrottle]]",
+ "throttleoverride-success-sub": "Used as page title in
[[Special:ThrottleOverride]].\n\nThis message is the subject for the following
message:\n* {{msg-mw|throttleoverride-success}}",
"throttleoverride-types": "Label for the types of throttles that can be
overridden.\n{{Identical|Throttle type}}",
"throttleoverride-types-all": "Label for the throttle type representing
all types (used in [[Special:ThrottleOverrideList]]).\n{{Identical|All types}}",
"throttleoverride-types-actcreate": "Label for the throttle type for
account creations",
--
To view, visit https://gerrit.wikimedia.org/r/379696
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I03276c79c11cc65d5c9e22f7a1441004af1a5bb1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ThrottleOverride
Gerrit-Branch: master
Gerrit-Owner: EddieGP
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
