[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: Reorder Translate filters

2017-11-27 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393671 )

Change subject: Reorder Translate filters
..


Reorder Translate filters

Reorder the filters as follows:
- Translations
- Site messages
- Not translations

Bug: T159795
Change-Id: I9cea48df95a042926d74baea3fed436a02bbe878
---
M utils/RcFilter.php
1 file changed, 11 insertions(+), 11 deletions(-)

Approvals:
  jenkins-bot: Verified
  Nikerabbit: Looks good to me, approved



diff --git a/utils/RcFilter.php b/utils/RcFilter.php
index de9197b..54e533f 100644
--- a/utils/RcFilter.php
+++ b/utils/RcFilter.php
@@ -144,17 +144,6 @@
'isFullCoverage' => true,
'filters' => [
[
-   'name' => 'filter',
-   'label' => 
'translate-rcfilters-translations-filter-label',
-   'description' => 
'translate-rcfilters-translations-filter-desc',
-   'cssClassSuffix' => 'filter',
-   'isRowApplicableCallable' => 
function ( $ctx, $rc ) {
-   $namespaces = 
self::getTranslateNamespaces();
-
-   return !in_array( 
$rc->getAttribute( 'rc_namespace' ), $namespaces );
-   }
-   ],
-   [
'name' => 'only',
'label' => 
'translate-rcfilters-translations-only-label',
'description' => 
'translate-rcfilters-translations-only-desc',
@@ -178,6 +167,17 @@
strpos( 
$rc->getAttribute( 'rc_title' ), '/' ) === false;
}
],
+   [
+   'name' => 'filter',
+   'label' => 
'translate-rcfilters-translations-filter-label',
+   'description' => 
'translate-rcfilters-translations-filter-desc',
+   'cssClassSuffix' => 'filter',
+   'isRowApplicableCallable' => 
function ( $ctx, $rc ) {
+   $namespaces = 
self::getTranslateNamespaces();
+
+   return !in_array( 
$rc->getAttribute( 'rc_namespace' ), $namespaces );
+   }
+   ],
],
'queryCallable' => function ( 
$specialClassName, $ctx, $dbr, &$tables,
&$fields, &$conds, &$query_options, 
&$join_conds, $selectedValues

-- 
To view, visit https://gerrit.wikimedia.org/r/393671
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9cea48df95a042926d74baea3fed436a02bbe878
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Petar.petkovic 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: Reorder Translate filters

2017-11-27 Thread Petar.petkovic (Code Review)
Petar.petkovic has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393671 )

Change subject: Reorder Translate filters
..

Reorder Translate filters

Reorder the filters as follows:
- Translations
- Site messages
- Not translations

Bug: T159795
Change-Id: I9cea48df95a042926d74baea3fed436a02bbe878
---
M utils/RcFilter.php
1 file changed, 11 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/71/393671/1

diff --git a/utils/RcFilter.php b/utils/RcFilter.php
index de9197b..54e533f 100644
--- a/utils/RcFilter.php
+++ b/utils/RcFilter.php
@@ -144,17 +144,6 @@
'isFullCoverage' => true,
'filters' => [
[
-   'name' => 'filter',
-   'label' => 
'translate-rcfilters-translations-filter-label',
-   'description' => 
'translate-rcfilters-translations-filter-desc',
-   'cssClassSuffix' => 'filter',
-   'isRowApplicableCallable' => 
function ( $ctx, $rc ) {
-   $namespaces = 
self::getTranslateNamespaces();
-
-   return !in_array( 
$rc->getAttribute( 'rc_namespace' ), $namespaces );
-   }
-   ],
-   [
'name' => 'only',
'label' => 
'translate-rcfilters-translations-only-label',
'description' => 
'translate-rcfilters-translations-only-desc',
@@ -178,6 +167,17 @@
strpos( 
$rc->getAttribute( 'rc_title' ), '/' ) === false;
}
],
+   [
+   'name' => 'filter',
+   'label' => 
'translate-rcfilters-translations-filter-label',
+   'description' => 
'translate-rcfilters-translations-filter-desc',
+   'cssClassSuffix' => 'filter',
+   'isRowApplicableCallable' => 
function ( $ctx, $rc ) {
+   $namespaces = 
self::getTranslateNamespaces();
+
+   return !in_array( 
$rc->getAttribute( 'rc_namespace' ), $namespaces );
+   }
+   ],
],
'queryCallable' => function ( 
$specialClassName, $ctx, $dbr, &$tables,
&$fields, &$conds, &$query_options, 
&$join_conds, $selectedValues

-- 
To view, visit https://gerrit.wikimedia.org/r/393671
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9cea48df95a042926d74baea3fed436a02bbe878
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Petar.petkovic 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits