[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Restore indicator for menuForceShow of tab menus

2017-11-20 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/392302 )

Change subject: Restore indicator for menuForceShow of tab menus
..


Restore indicator for menuForceShow of tab menus

The previous indicator was removed in 7a42af066b because of a position
transition. The new indicator has no animation.

An indicator is useful to distinguish between the hover and the click
actions.

Change-Id: Icf765d4985aea36e4f4f6653e769aafaf3c30d07
---
M components/tabs.less
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/components/tabs.less b/components/tabs.less
index 5e162dd..006bcbb 100644
--- a/components/tabs.less
+++ b/components/tabs.less
@@ -145,12 +145,12 @@
&:after {
content: '';
position: absolute;
-   top: 0;
+   top: 1.25em;
right: 0;
bottom: 0;
left: 0;
.background-image-svg('images/arrow-down.svg', 
'images/arrow-down.png');
-   background-position: 100% 87%;
+   background-position: 100% 50%;
background-repeat: no-repeat;
// Modify the color of the image from the default #222 
to approx. #444 to match the text.
opacity: 0.85;
@@ -167,6 +167,10 @@
}
 }
 
+div.vectorMenu.menuForceShow h3 span:after {
+   transform: scaleY( -1 );
+}
+
 div.vectorMenu div.menu {
// Match the width of the dropdown "heading" (the tab)
min-width: 100%;

-- 
To view, visit https://gerrit.wikimedia.org/r/392302
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icf765d4985aea36e4f4f6653e769aafaf3c30d07
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Fomafix 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Fomafix 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Restore indicator for menuForceShow of tab menus

2017-11-19 Thread Fomafix (Code Review)
Fomafix has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/392302 )

Change subject: Restore indicator for menuForceShow of tab menus
..

Restore indicator for menuForceShow of tab menus

The previous indicator was removed in 7a42af066b because of a position
transition.

An indicator is useful to distinguish between the hover and the click
actions.

Change-Id: Icf765d4985aea36e4f4f6653e769aafaf3c30d07
---
M components/tabs.less
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector 
refs/changes/02/392302/1

diff --git a/components/tabs.less b/components/tabs.less
index 5e162dd..b1120ec 100644
--- a/components/tabs.less
+++ b/components/tabs.less
@@ -167,6 +167,12 @@
}
 }
 
+div.vectorMenu.menuForceShow h3 span:after {
+   background-position-y: 13%;
+   transform: scaleY( -1 );
+}
+
+
 div.vectorMenu div.menu {
// Match the width of the dropdown "heading" (the tab)
min-width: 100%;

-- 
To view, visit https://gerrit.wikimedia.org/r/392302
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf765d4985aea36e4f4f6653e769aafaf3c30d07
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Fomafix 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits