[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[REL1_29]: Follow-up I488fd7e74: Adjust saveFail calls for new function...

2017-11-04 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/388753 )

Change subject: Follow-up I488fd7e74: Adjust saveFail calls for new function 
signature
..


Follow-up I488fd7e74: Adjust saveFail calls for new function signature

Bug: T164157
Change-Id: I41b946af5a8b80211b0672d7012835f2c9e1dc2b
(cherry picked from commit 998ae22b2de690fe18d49489e3e90aa33267731b)
---
M modules/ve-mw/init/ve.init.mw.ArticleTarget.js
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-mw/init/ve.init.mw.ArticleTarget.js 
b/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
index e033b48..7a66419 100644
--- a/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
+++ b/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
@@ -503,12 +503,12 @@
var data = response.visualeditoredit;
this.saving = false;
if ( !data ) {
-   this.saveFail( doc, saveData, null, 'Invalid response from 
server', response );
+   this.saveFail( doc, saveData, false, null, 'Invalid response 
from server', response );
} else if ( data.result !== 'success' ) {
// Note, this could be any of db failure, hookabort, badtoken 
or even a captcha
-   this.saveFail( doc, saveData, null, 'Save failure', response );
+   this.saveFail( doc, saveData, false, null, 'Save failure', 
response );
} else if ( typeof data.content !== 'string' ) {
-   this.saveFail( doc, saveData, null, 'Invalid HTML content in 
response from server', response );
+   this.saveFail( doc, saveData, false, null, 'Invalid HTML 
content in response from server', response );
} else {
this.saveComplete(
data.content,

-- 
To view, visit https://gerrit.wikimedia.org/r/388753
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I41b946af5a8b80211b0672d7012835f2c9e1dc2b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: REL1_29
Gerrit-Owner: MacFan4000 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Esanders 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[REL1_29]: Follow-up I488fd7e74: Adjust saveFail calls for new function...

2017-11-03 Thread MacFan4000 (Code Review) 
MacFan4000 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/388753 )

Change subject: Follow-up I488fd7e74: Adjust saveFail calls for new function 
signature
..

Follow-up I488fd7e74: Adjust saveFail calls for new function signature

Bug: T164157
Change-Id: I41b946af5a8b80211b0672d7012835f2c9e1dc2b
(cherry picked from commit 998ae22b2de690fe18d49489e3e90aa33267731b)
---
M modules/ve-mw/init/ve.init.mw.ArticleTarget.js
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/53/388753/1

diff --git a/modules/ve-mw/init/ve.init.mw.ArticleTarget.js 
b/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
index e033b48..7a66419 100644
--- a/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
+++ b/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
@@ -503,12 +503,12 @@
var data = response.visualeditoredit;
this.saving = false;
if ( !data ) {
-   this.saveFail( doc, saveData, null, 'Invalid response from 
server', response );
+   this.saveFail( doc, saveData, false, null, 'Invalid response 
from server', response );
} else if ( data.result !== 'success' ) {
// Note, this could be any of db failure, hookabort, badtoken 
or even a captcha
-   this.saveFail( doc, saveData, null, 'Save failure', response );
+   this.saveFail( doc, saveData, false, null, 'Save failure', 
response );
} else if ( typeof data.content !== 'string' ) {
-   this.saveFail( doc, saveData, null, 'Invalid HTML content in 
response from server', response );
+   this.saveFail( doc, saveData, false, null, 'Invalid HTML 
content in response from server', response );
} else {
this.saveComplete(
data.content,

-- 
To view, visit https://gerrit.wikimedia.org/r/388753
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I41b946af5a8b80211b0672d7012835f2c9e1dc2b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: REL1_29
Gerrit-Owner: MacFan4000 
Gerrit-Reviewer: Esanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits