[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: "Automatically enable all new beta features" should enable 2...

2017-09-26 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/379228 )

Change subject: "Automatically enable all new beta features" should enable 2017 
editor
..


"Automatically enable all new beta features" should enable 2017 editor

Bug: T176181
Change-Id: I588dd08b788689fb89de7fd001bded30caa07e64
---
M VisualEditor.hooks.php
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved

Objections:
  Deskana: There's a problem with this change, please improve



diff --git a/VisualEditor.hooks.php b/VisualEditor.hooks.php
index c3b1aa6..2bf92cb 100644
--- a/VisualEditor.hooks.php
+++ b/VisualEditor.hooks.php
@@ -719,8 +719,7 @@
'requirements' => [
'javascript' => true,
'blacklist' => $veConfig->get( 
'VisualEditorBrowserBlacklist' ),
-   ],
-   'exempt-from-auto-enrollment' => true
+   ]
];
}
}

-- 
To view, visit https://gerrit.wikimedia.org/r/379228
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I588dd08b788689fb89de7fd001bded30caa07e64
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Deskana 
Gerrit-Reviewer: Deskana 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: "Automatically enable all new beta features" should enable 2...

2017-09-20 Thread Deskana (Code Review)
Deskana has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/379228 )

Change subject: "Automatically enable all new beta features" should enable 2017 
editor
..

"Automatically enable all new beta features" should enable 2017 editor

Bug: T176181
Change-Id: I588dd08b788689fb89de7fd001bded30caa07e64
---
M VisualEditor.hooks.php
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/28/379228/1

diff --git a/VisualEditor.hooks.php b/VisualEditor.hooks.php
index c3b1aa6..2bf92cb 100644
--- a/VisualEditor.hooks.php
+++ b/VisualEditor.hooks.php
@@ -719,8 +719,7 @@
'requirements' => [
'javascript' => true,
'blacklist' => $veConfig->get( 
'VisualEditorBrowserBlacklist' ),
-   ],
-   'exempt-from-auto-enrollment' => true
+   ]
];
}
}

-- 
To view, visit https://gerrit.wikimedia.org/r/379228
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I588dd08b788689fb89de7fd001bded30caa07e64
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Deskana 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits