jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/378044 )
Change subject: Efficiency improvement for MWLanguageVariantNode#hasRendering ...................................................................... Efficiency improvement for MWLanguageVariantNode#hasRendering Override ve.ce.FocusableNode#hasRendering with a model-based test to improve efficiency and avoid some unnecessary DOM measurements. Change-Id: Ice7aebcc2f30dc73ef049a6ed0d4a0cffe86d8e2 --- M modules/ve-mw/ce/nodes/ve.ce.MWLanguageVariantNode.js 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Bartosz Dziewoński: Looks good to me, approved jenkins-bot: Verified Jforrester: Looks good to me, but someone else must approve diff --git a/modules/ve-mw/ce/nodes/ve.ce.MWLanguageVariantNode.js b/modules/ve-mw/ce/nodes/ve.ce.MWLanguageVariantNode.js index 1298647..91edfcf 100644 --- a/modules/ve-mw/ce/nodes/ve.ce.MWLanguageVariantNode.js +++ b/modules/ve-mw/ce/nodes/ve.ce.MWLanguageVariantNode.js @@ -163,6 +163,16 @@ }; /** + * @inheritdoc + */ +ve.ce.MWLanguageVariantNode.prototype.hasRendering = function () { + // Efficiency improvement: the superclass implementation does a bunch + // of DOM measurement to determine if the node is empty. + // Instead consult the model for a definitive answer. + return !this.model.isHidden(); +}; + +/** * ContentEditable MediaWiki language variant block node. * * @class -- To view, visit https://gerrit.wikimedia.org/r/378044 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice7aebcc2f30dc73ef049a6ed0d4a0cffe86d8e2 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: C. Scott Ananian <canan...@wikimedia.org> Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: C. Scott Ananian <canan...@wikimedia.org> Gerrit-Reviewer: Esanders <esand...@wikimedia.org> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits