[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Scroll highlighted item into view in gallery dialog

2016-12-06 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Scroll highlighted item into view in gallery dialog
..


Scroll highlighted item into view in gallery dialog

Bug: T152053
Change-Id: I6b77f6c27d5629dc18e421f984cf31badfb2ff04
---
M modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Esanders: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js 
b/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
index 63726c3..1799cda 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
@@ -529,6 +529,9 @@
item.toggleHighlighted( true );
this.highlightedItem = item;
 
+   // Scroll item into view in menu
+   OO.ui.Element.static.scrollIntoView( item.$element[ 0 ] );
+
// Populate edit panel
this.$highlightedImage
.css( 'background-image', 'url(' + item.thumbUrl + ')' );

-- 
To view, visit https://gerrit.wikimedia.org/r/325103
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6b77f6c27d5629dc18e421f984cf31badfb2ff04
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Tchanders 
Gerrit-Reviewer: Alex Monk 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Esanders 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Scroll highlighted item into view in gallery dialog

2016-12-03 Thread Tchanders (Code Review) 
Tchanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/325103

Change subject: Scroll highlighted item into view in gallery dialog
..

Scroll highlighted item into view in gallery dialog

Bug: T152053
Change-Id: I6b77f6c27d5629dc18e421f984cf31badfb2ff04
---
M modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/03/325103/1

diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js 
b/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
index 63726c3..1799cda 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
@@ -529,6 +529,9 @@
item.toggleHighlighted( true );
this.highlightedItem = item;
 
+   // Scroll item into view in menu
+   OO.ui.Element.static.scrollIntoView( item.$element[ 0 ] );
+
// Populate edit panel
this.$highlightedImage
.css( 'background-image', 'url(' + item.thumbUrl + ')' );

-- 
To view, visit https://gerrit.wikimedia.org/r/325103
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b77f6c27d5629dc18e421f984cf31badfb2ff04
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Tchanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits