[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Unify monospace font family stack

2017-09-27 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/381142 )

Change subject: Unify monospace font family stack
..


Unify monospace font family stack

Bug: T176636
Change-Id: I9ad1a92cef7875371e232c8e4babc842ba711e8c
---
M modules/ve-mw/ui/styles/dialogs/ve.ui.MWPreDialog.css
M modules/ve-mw/ui/styles/pages/ve.ui.MWParameterPage.css
M modules/ve-mw/ui/styles/widgets/ve.ui.MWAceEditorWidget.css
3 files changed, 9 insertions(+), 6 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/modules/ve-mw/ui/styles/dialogs/ve.ui.MWPreDialog.css 
b/modules/ve-mw/ui/styles/dialogs/ve.ui.MWPreDialog.css
index 5420d4e..4a0d96f 100644
--- a/modules/ve-mw/ui/styles/dialogs/ve.ui.MWPreDialog.css
+++ b/modules/ve-mw/ui/styles/dialogs/ve.ui.MWPreDialog.css
@@ -10,8 +10,9 @@
max-width: none;
/* Don't allow the widget to force the dialog to have scrollbars */
height: 100%;
-   /* Specify a valid second value to fix size in Chrome/FF */
-   font-family: monospace, 'Courier';
+   /* Support: Blink, Gecko, Webkit */
+   /* Specify a valid second value to fix size, see T176636 */
+   font-family: monospace, monospace;
 }
 
 .ve-ui-mwPreDialog .oo-ui-textInputWidget textarea {
diff --git a/modules/ve-mw/ui/styles/pages/ve.ui.MWParameterPage.css 
b/modules/ve-mw/ui/styles/pages/ve.ui.MWParameterPage.css
index ca22b21..d7c8ee5 100644
--- a/modules/ve-mw/ui/styles/pages/ve.ui.MWParameterPage.css
+++ b/modules/ve-mw/ui/styles/pages/ve.ui.MWParameterPage.css
@@ -6,7 +6,8 @@
  */
 
 .ve-ui-mwParameterPage .ve-ui-mwParameter-wikitextFallbackInput {
-   /* Specify a valid second value to fix size in Chrome/FF */
-   font-family: monospace, 'Courier';
+   /* Support: Blink, Gecko, Webkit */
+   /* Specify a valid second value to fix size, see T176636 */
+   font-family: monospace, monospace;
background-color: #c8ccd1;
 }
diff --git a/modules/ve-mw/ui/styles/widgets/ve.ui.MWAceEditorWidget.css 
b/modules/ve-mw/ui/styles/widgets/ve.ui.MWAceEditorWidget.css
index 07f7f6e..d674495 100644
--- a/modules/ve-mw/ui/styles/widgets/ve.ui.MWAceEditorWidget.css
+++ b/modules/ve-mw/ui/styles/widgets/ve.ui.MWAceEditorWidget.css
@@ -8,8 +8,9 @@
 .ve-ui-mwAceEditorWidget .ace_editor {
border: 1px solid #c8ccd1;
margin: 1px;
-   /* Specify a valid second value to fix size in Chrome/FF */
-   font-family: monospace, 'Courier';
+   /* Support: Blink, Gecko, Webkit */
+   /* Specify a valid second value to fix size, see T176636 */
+   font-family: monospace, monospace;
font-size: inherit;
line-height: 1.5;
/* Allow tooptip outside of editor */

-- 
To view, visit https://gerrit.wikimedia.org/r/381142
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9ad1a92cef7875371e232c8e4babc842ba711e8c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Unify monospace font family stack

2017-09-27 Thread VolkerE (Code Review) 
VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/381142 )

Change subject: Unify monospace font family stack
..

Unify monospace font family stack

Bug: T176636
Change-Id: I9ad1a92cef7875371e232c8e4babc842ba711e8c
---
M modules/ve-mw/ui/styles/dialogs/ve.ui.MWPreDialog.css
M modules/ve-mw/ui/styles/pages/ve.ui.MWParameterPage.css
M modules/ve-mw/ui/styles/widgets/ve.ui.MWAceEditorWidget.css
3 files changed, 9 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/42/381142/1

diff --git a/modules/ve-mw/ui/styles/dialogs/ve.ui.MWPreDialog.css 
b/modules/ve-mw/ui/styles/dialogs/ve.ui.MWPreDialog.css
index 5420d4e..4a0d96f 100644
--- a/modules/ve-mw/ui/styles/dialogs/ve.ui.MWPreDialog.css
+++ b/modules/ve-mw/ui/styles/dialogs/ve.ui.MWPreDialog.css
@@ -10,8 +10,9 @@
max-width: none;
/* Don't allow the widget to force the dialog to have scrollbars */
height: 100%;
-   /* Specify a valid second value to fix size in Chrome/FF */
-   font-family: monospace, 'Courier';
+   /* Support: Blink, Gecko, Webkit */
+   /* Specify a valid second value to fix size, see T176636 */
+   font-family: monospace, monospace;
 }
 
 .ve-ui-mwPreDialog .oo-ui-textInputWidget textarea {
diff --git a/modules/ve-mw/ui/styles/pages/ve.ui.MWParameterPage.css 
b/modules/ve-mw/ui/styles/pages/ve.ui.MWParameterPage.css
index ca22b21..d7c8ee5 100644
--- a/modules/ve-mw/ui/styles/pages/ve.ui.MWParameterPage.css
+++ b/modules/ve-mw/ui/styles/pages/ve.ui.MWParameterPage.css
@@ -6,7 +6,8 @@
  */
 
 .ve-ui-mwParameterPage .ve-ui-mwParameter-wikitextFallbackInput {
-   /* Specify a valid second value to fix size in Chrome/FF */
-   font-family: monospace, 'Courier';
+   /* Support: Blink, Gecko, Webkit */
+   /* Specify a valid second value to fix size, see T176636 */
+   font-family: monospace, monospace;
background-color: #c8ccd1;
 }
diff --git a/modules/ve-mw/ui/styles/widgets/ve.ui.MWAceEditorWidget.css 
b/modules/ve-mw/ui/styles/widgets/ve.ui.MWAceEditorWidget.css
index 07f7f6e..d674495 100644
--- a/modules/ve-mw/ui/styles/widgets/ve.ui.MWAceEditorWidget.css
+++ b/modules/ve-mw/ui/styles/widgets/ve.ui.MWAceEditorWidget.css
@@ -8,8 +8,9 @@
 .ve-ui-mwAceEditorWidget .ace_editor {
border: 1px solid #c8ccd1;
margin: 1px;
-   /* Specify a valid second value to fix size in Chrome/FF */
-   font-family: monospace, 'Courier';
+   /* Support: Blink, Gecko, Webkit */
+   /* Specify a valid second value to fix size, see T176636 */
+   font-family: monospace, monospace;
font-size: inherit;
line-height: 1.5;
/* Allow tooptip outside of editor */

-- 
To view, visit https://gerrit.wikimedia.org/r/381142
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ad1a92cef7875371e232c8e4babc842ba711e8c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits