[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Fix I0e802a47: Don't try to send dieWithError error codes as...

2016-12-16 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/327718 )

Change subject: Fix I0e802a47: Don't try to send dieWithError error codes as 
integers
..


Fix I0e802a47: Don't try to send dieWithError error codes as integers

Bug: T152429
Change-Id: If882b14adc945ca49e51a912a676aee0be9c9fec
---
M ApiVisualEditor.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/ApiVisualEditor.php b/ApiVisualEditor.php
index b3981d8..dd8eef2 100644
--- a/ApiVisualEditor.php
+++ b/ApiVisualEditor.php
@@ -116,7 +116,7 @@
} else { // error null, code not 200
$this->dieWithError(
[ 'apierror-visualeditor-docserver-http', 
$response['code'] ],
-   $response['code']
+   (string) $response['code']
);
}
return $response['body'];

-- 
To view, visit https://gerrit.wikimedia.org/r/327718
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If882b14adc945ca49e51a912a676aee0be9c9fec
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Fix I0e802a47: Don't try to send dieWithError error codes as...

2016-12-16 Thread Alex Monk (Code Review) 
Alex Monk has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/327718 )

Change subject: Fix I0e802a47: Don't try to send dieWithError error codes as 
integers
..

Fix I0e802a47: Don't try to send dieWithError error codes as integers

Bug: T152429
Change-Id: If882b14adc945ca49e51a912a676aee0be9c9fec
---
M ApiVisualEditor.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/18/327718/1

diff --git a/ApiVisualEditor.php b/ApiVisualEditor.php
index b3981d8..dd8eef2 100644
--- a/ApiVisualEditor.php
+++ b/ApiVisualEditor.php
@@ -116,7 +116,7 @@
} else { // error null, code not 200
$this->dieWithError(
[ 'apierror-visualeditor-docserver-http', 
$response['code'] ],
-   $response['code']
+   (string) $response['code']
);
}
return $response['body'];

-- 
To view, visit https://gerrit.wikimedia.org/r/327718
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If882b14adc945ca49e51a912a676aee0be9c9fec
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits