[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: NWE: Disable progress bar when pre-parsing for WindowAction's

2016-12-03 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: NWE: Disable progress bar when pre-parsing for WindowAction's
..


NWE: Disable progress bar when pre-parsing for WindowAction's

The progress bar dialogs interfere with the life cycle
of the window you are trying to open. Just disable these
progress bars for now to avoid catastrophic behaviour.

Change-Id: I77c8ae67a2d502bbd189836deb320cd55c3cb11a
---
M modules/ve-mw/dm/ve.dm.MWWikitextSurfaceFragment.js
1 file changed, 8 insertions(+), 8 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-mw/dm/ve.dm.MWWikitextSurfaceFragment.js 
b/modules/ve-mw/dm/ve.dm.MWWikitextSurfaceFragment.js
index 1e2afe0..79e037f 100644
--- a/modules/ve-mw/dm/ve.dm.MWWikitextSurfaceFragment.js
+++ b/modules/ve-mw/dm/ve.dm.MWWikitextSurfaceFragment.js
@@ -163,14 +163,14 @@
);
} );
 
-   // TODO: Emit an event to trigger the progress bar
-   ve.init.target.getSurface().createProgress(
-   parsePromise, ve.msg( 
'visualeditor-generating-wikitext-progress' )
-   ).done( function ( progressBar, cancelPromise ) {
-   cancelPromise.fail( function () {
-   parsePromise.abort();
-   } );
-   } );
+   // TODO: Show progress bar without breaking WindowAction
+   // ve.init.target.getSurface().createProgress(
+   //  parsePromise, ve.msg( 
'visualeditor-generating-wikitext-progress' )
+   // ).done( function ( progressBar, cancelPromise ) {
+   //  cancelPromise.fail( function () {
+   //  parsePromise.abort();
+   //  } );
+   // } );
 
return parsePromise;
 };

-- 
To view, visit https://gerrit.wikimedia.org/r/325110
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I77c8ae67a2d502bbd189836deb320cd55c3cb11a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 
Gerrit-Reviewer: Esanders 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: NWE: Disable progress bar when pre-parsing for WindowAction's

2016-12-03 Thread Esanders (Code Review) 
Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/325110

Change subject: NWE: Disable progress bar when pre-parsing for WindowAction's
..

NWE: Disable progress bar when pre-parsing for WindowAction's

The progress bar dialogs interfer with the life cycle
of the window you are trying to open. Just disable these
progress bars for now to avoid catastrophic behaviour.

Change-Id: I77c8ae67a2d502bbd189836deb320cd55c3cb11a
---
M modules/ve-mw/dm/ve.dm.MWWikitextSurfaceFragment.js
1 file changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/10/325110/1

diff --git a/modules/ve-mw/dm/ve.dm.MWWikitextSurfaceFragment.js 
b/modules/ve-mw/dm/ve.dm.MWWikitextSurfaceFragment.js
index 1e2afe0..79e037f 100644
--- a/modules/ve-mw/dm/ve.dm.MWWikitextSurfaceFragment.js
+++ b/modules/ve-mw/dm/ve.dm.MWWikitextSurfaceFragment.js
@@ -163,14 +163,14 @@
);
} );
 
-   // TODO: Emit an event to trigger the progress bar
-   ve.init.target.getSurface().createProgress(
-   parsePromise, ve.msg( 
'visualeditor-generating-wikitext-progress' )
-   ).done( function ( progressBar, cancelPromise ) {
-   cancelPromise.fail( function () {
-   parsePromise.abort();
-   } );
-   } );
+   // TODO: Show progress bar without breaking WindowAction
+   // ve.init.target.getSurface().createProgress(
+   //  parsePromise, ve.msg( 
'visualeditor-generating-wikitext-progress' )
+   // ).done( function ( progressBar, cancelPromise ) {
+   //  cancelPromise.fail( function () {
+   //  parsePromise.abort();
+   //  } );
+   // } );
 
return parsePromise;
 };

-- 
To view, visit https://gerrit.wikimedia.org/r/325110
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I77c8ae67a2d502bbd189836deb320cd55c3cb11a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits