[MediaWiki-commits] [Gerrit] mediawiki...VoteNY[master]: Replace deprecated Parser::disableCache() function

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/402621 )

Change subject: Replace deprecated Parser::disableCache() function
..


Replace deprecated Parser::disableCache() function

Deprecated in 1.28 in favor of CacheTime::updateCacheExpiry().

Change-Id: I3f5faa40d8edbb0a4bffd74530ff9aaf010f821f
---
M includes/VoteNY.hooks.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jack Phoenix: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/VoteNY.hooks.php b/includes/VoteNY.hooks.php
index aae5c21..c6e3193 100644
--- a/includes/VoteNY.hooks.php
+++ b/includes/VoteNY.hooks.php
@@ -32,7 +32,7 @@
// Disable parser cache (sadly we have to do this, because the 
caching is
// messing stuff up; we want to show an up-to-date rating 
instead of old
// or totally wrong rating, i.e. another page's rating...)
-   $parser->disableCache();
+   $parser->getOutput()->updateCacheExpiry( 0 );
 
// Add CSS & JS
// In order for us to do this *here* instead of having to do 
this in

-- 
To view, visit https://gerrit.wikimedia.org/r/402621
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3f5faa40d8edbb0a4bffd74530ff9aaf010f821f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VoteNY
Gerrit-Branch: master
Gerrit-Owner: SamanthaNguyen 
Gerrit-Reviewer: Jack Phoenix 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VoteNY[master]: Replace deprecated Parser::disableCache() function

[SamanthaNguyen (Code Review)]

SamanthaNguyen has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402621 )

Change subject: Replace deprecated Parser::disableCache() function
..

Replace deprecated Parser::disableCache() function

Deprecated in 1.28 in favor of CacheTime::updateCacheExpiry().

Change-Id: I3f5faa40d8edbb0a4bffd74530ff9aaf010f821f
---
M includes/VoteNY.hooks.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VoteNY 
refs/changes/21/402621/1

diff --git a/includes/VoteNY.hooks.php b/includes/VoteNY.hooks.php
index aae5c21..c6e3193 100644
--- a/includes/VoteNY.hooks.php
+++ b/includes/VoteNY.hooks.php
@@ -32,7 +32,7 @@
// Disable parser cache (sadly we have to do this, because the 
caching is
// messing stuff up; we want to show an up-to-date rating 
instead of old
// or totally wrong rating, i.e. another page's rating...)
-   $parser->disableCache();
+   $parser->getOutput()->updateCacheExpiry( 0 );
 
// Add CSS & JS
// In order for us to do this *here* instead of having to do 
this in

-- 
To view, visit https://gerrit.wikimedia.org/r/402621
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f5faa40d8edbb0a4bffd74530ff9aaf010f821f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VoteNY
Gerrit-Branch: master
Gerrit-Owner: SamanthaNguyen 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits