[MediaWiki-commits] [Gerrit] mediawiki...WikiEditor[master]: Emit deprecation warnings when old modules are used

2018-01-08 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/402851 )

Change subject: Emit deprecation warnings when old modules are used
..


Emit deprecation warnings when old modules are used

Bug: T184194
Depends-On: If22fccbb43c5b05db2a666d61ae8864ee9815e7d
Change-Id: If5649ab48ebbf47e9981ec010bb1e5ce668c5487
---
M extension.json
1 file changed, 20 insertions(+), 10 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/extension.json b/extension.json
index 7937823..97d6102 100644
--- a/extension.json
+++ b/extension.json
@@ -287,34 +287,44 @@
"styles": "ext.wikiEditor.toolbar.styles.less"
},
"ext.wikiEditor.toolbar": {
-   "dependencies": [ "ext.wikiEditor" ]
+   "dependencies": "ext.wikiEditor",
+   "deprecated": "Please use 'ext.wikiEditor' instead."
},
"ext.wikiEditor.dialogs": {
-   "dependencies": [ "ext.wikiEditor" ]
+   "dependencies": "ext.wikiEditor",
+   "deprecated": "Please use 'ext.wikiEditor' instead."
},
"ext.wikiEditor.core": {
-   "dependencies": [ "ext.wikiEditor" ]
+   "dependencies": "ext.wikiEditor",
+   "deprecated": "Please use 'ext.wikiEditor' instead."
},
"jquery.wikiEditor": {
-   "dependencies": [ "ext.wikiEditor" ]
+   "dependencies": "ext.wikiEditor",
+   "deprecated": "Please use 'ext.wikiEditor' instead."
},
"jquery.wikiEditor.core": {
-   "dependencies": [ "ext.wikiEditor" ]
+   "dependencies": "ext.wikiEditor",
+   "deprecated": "Please use 'ext.wikiEditor' instead."
},
"jquery.wikiEditor.dialogs": {
-   "dependencies": [ "ext.wikiEditor" ]
+   "dependencies": "ext.wikiEditor",
+   "deprecated": "Please use 'ext.wikiEditor' instead."
},
"jquery.wikiEditor.dialogs.config": {
-   "dependencies": [ "ext.wikiEditor" ]
+   "dependencies": "ext.wikiEditor",
+   "deprecated": "Please use 'ext.wikiEditor' instead."
},
"jquery.wikiEditor.toolbar": {
-   "dependencies": [ "ext.wikiEditor" ]
+   "dependencies": "ext.wikiEditor",
+   "deprecated": "Please use 'ext.wikiEditor' instead."
},
"jquery.wikiEditor.toolbar.config": {
-   "dependencies": [ "ext.wikiEditor" ]
+   "dependencies": "ext.wikiEditor",
+   "deprecated": "Please use 'ext.wikiEditor' instead."
},
"jquery.wikiEditor.toolbar.i18n": {
-   "dependencies": [ "ext.wikiEditor" ]
+   "dependencies": "ext.wikiEditor",
+   "deprecated": "Please use 'ext.wikiEditor' instead."
}
},
"ResourceFileModulePaths": {

-- 
To view, visit https://gerrit.wikimedia.org/r/402851
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If5649ab48ebbf47e9981ec010bb1e5ce668c5487
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 
Gerrit-Reviewer: Esanders 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: TheDJ 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikiEditor[master]: Emit deprecation warnings when old modules are used

2018-01-08 Thread Esanders (Code Review) 
Esanders has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402851 )

Change subject: Emit deprecation warnings when old modules are used
..

Emit deprecation warnings when old modules are used

Bug: T184194
Change-Id: If5649ab48ebbf47e9981ec010bb1e5ce668c5487
---
M extension.json
A modules/ext.wikiEditor.deprecatedModule.js
2 files changed, 24 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor 
refs/changes/51/402851/1

diff --git a/extension.json b/extension.json
index 7937823..7ada8e2 100644
--- a/extension.json
+++ b/extension.json
@@ -287,34 +287,44 @@
"styles": "ext.wikiEditor.toolbar.styles.less"
},
"ext.wikiEditor.toolbar": {
-   "dependencies": [ "ext.wikiEditor" ]
+   "dependencies": "ext.wikiEditor",
+   "scripts": "ext.wikiEditor.deprecatedModule.js"
},
"ext.wikiEditor.dialogs": {
-   "dependencies": [ "ext.wikiEditor" ]
+   "dependencies": "ext.wikiEditor",
+   "scripts": "ext.wikiEditor.deprecatedModule.js"
},
"ext.wikiEditor.core": {
-   "dependencies": [ "ext.wikiEditor" ]
+   "dependencies": "ext.wikiEditor",
+   "scripts": "ext.wikiEditor.deprecatedModule.js"
},
"jquery.wikiEditor": {
-   "dependencies": [ "ext.wikiEditor" ]
+   "dependencies": "ext.wikiEditor",
+   "scripts": "ext.wikiEditor.deprecatedModule.js"
},
"jquery.wikiEditor.core": {
-   "dependencies": [ "ext.wikiEditor" ]
+   "dependencies": "ext.wikiEditor",
+   "scripts": "ext.wikiEditor.deprecatedModule.js"
},
"jquery.wikiEditor.dialogs": {
-   "dependencies": [ "ext.wikiEditor" ]
+   "dependencies": "ext.wikiEditor",
+   "scripts": "ext.wikiEditor.deprecatedModule.js"
},
"jquery.wikiEditor.dialogs.config": {
-   "dependencies": [ "ext.wikiEditor" ]
+   "dependencies": "ext.wikiEditor",
+   "scripts": "ext.wikiEditor.deprecatedModule.js"
},
"jquery.wikiEditor.toolbar": {
-   "dependencies": [ "ext.wikiEditor" ]
+   "dependencies": "ext.wikiEditor",
+   "scripts": "ext.wikiEditor.deprecatedModule.js"
},
"jquery.wikiEditor.toolbar.config": {
-   "dependencies": [ "ext.wikiEditor" ]
+   "dependencies": "ext.wikiEditor",
+   "scripts": "ext.wikiEditor.deprecatedModule.js"
},
"jquery.wikiEditor.toolbar.i18n": {
-   "dependencies": [ "ext.wikiEditor" ]
+   "dependencies": "ext.wikiEditor",
+   "scripts": "ext.wikiEditor.deprecatedModule.js"
}
},
"ResourceFileModulePaths": {
diff --git a/modules/ext.wikiEditor.deprecatedModule.js 
b/modules/ext.wikiEditor.deprecatedModule.js
new file mode 100644
index 000..c1bedfd
--- /dev/null
+++ b/modules/ext.wikiEditor.deprecatedModule.js
@@ -0,0 +1,4 @@
+/* global mw */
+
+mw.track( 'mw.deprecate', 'wikieditor-modules' );
+mw.log.warn( 'WikiEditor should only be loaded via the \'ext.wikiEditor\' 
module.' );

-- 
To view, visit https://gerrit.wikimedia.org/r/402851
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If5649ab48ebbf47e9981ec010bb1e5ce668c5487
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits