[MediaWiki-commits] [Gerrit] mediawiki...WikiEditor[master]: Track time-to-ready/loaded via window.performance

2017-12-11 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397580 )

Change subject: Track time-to-ready/loaded via window.performance
..


Track time-to-ready/loaded via window.performance

Change-Id: Iadb9c131ca6730c20d4b166e686942f9b404e198
---
M modules/ext.wikiEditor.js
1 file changed, 17 insertions(+), 7 deletions(-)

Approvals:
  Esanders: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ext.wikiEditor.js b/modules/ext.wikiEditor.js
index a9368f1..3defae4 100644
--- a/modules/ext.wikiEditor.js
+++ b/modules/ext.wikiEditor.js
@@ -58,14 +58,24 @@
 
if ( $editingSessionIdInput.length ) {
editingSessionId = $editingSessionIdInput.val();
-   logEditEvent( 'ready', {
-   editingSessionId: editingSessionId
-   } );
-   $textarea.on( 'wikiEditor-toolbar-doneInitialSections', 
function () {
-   logEditEvent( 'loaded', {
-   editingSessionId: editingSessionId
+   if ( window.performance && window.performance.timing ) {
+   // We want to track from the time the user 
started to try to
+   // launch the editor which navigationStart 
approximates. All
+   // of our supported browsers *should* allow 
this. Rather than
+   // fall back to the timestamp when the page 
loaded for those
+   // that don't, we just ignore them, so as to 
not skew the
+   // results towards better-performance in those 
cases.
+   logEditEvent( 'ready', {
+   editingSessionId: editingSessionId,
+   timing: Date.now() - 
window.performance.timing.navigationStart
} );
-   } );
+   $textarea.on( 
'wikiEditor-toolbar-doneInitialSections', function () {
+   logEditEvent( 'loaded', {
+   editingSessionId: 
editingSessionId,
+   timing: Date.now() - 
window.performance.timing.navigationStart
+   } );
+   } );
+   }
$textarea.closest( 'form' ).submit( function () {
submitting = true;
} );

-- 
To view, visit https://gerrit.wikimedia.org/r/397580
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iadb9c131ca6730c20d4b166e686942f9b404e198
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: DLynch 
Gerrit-Reviewer: Esanders 
Gerrit-Reviewer: TheDJ 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikiEditor[master]: Track time-to-ready/loaded via window.performance

2017-12-11 Thread DLynch (Code Review) 
DLynch has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397580 )

Change subject: Track time-to-ready/loaded via window.performance
..

Track time-to-ready/loaded via window.performance

Change-Id: Iadb9c131ca6730c20d4b166e686942f9b404e198
---
M modules/ext.wikiEditor.js
1 file changed, 13 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor 
refs/changes/80/397580/1

diff --git a/modules/ext.wikiEditor.js b/modules/ext.wikiEditor.js
index a9368f1..f1300c2 100644
--- a/modules/ext.wikiEditor.js
+++ b/modules/ext.wikiEditor.js
@@ -5,6 +5,14 @@
 ( function ( $, mw ) {
var editingSessionId;
 
+   var startTime;
+   if ( window.performance && window.performance.timing ) {
+   // Time we started to navigate to this page
+   startTime = window.performance.timing.navigationStart;
+   } else {
+   startTime = Date.now();
+   }
+
function logEditEvent( action, data ) {
if ( mw.loader.getState( 'schema.Edit' ) === null ) {
return;
@@ -54,16 +62,18 @@
var $textarea = $( '#wpTextbox1' ),
$editingSessionIdInput = $( '#editingStatsId' ),
origText = $textarea.val(),
-   submitting, onUnloadFallback;
+   submitting, onUnloadFallback, startTime;
 
if ( $editingSessionIdInput.length ) {
editingSessionId = $editingSessionIdInput.val();
logEditEvent( 'ready', {
-   editingSessionId: editingSessionId
+   editingSessionId: editingSessionId,
+   timing: startTime - Date.now()
} );
$textarea.on( 'wikiEditor-toolbar-doneInitialSections', 
function () {
logEditEvent( 'loaded', {
-   editingSessionId: editingSessionId
+   editingSessionId: editingSessionId,
+   timing: startTime - Date.now()
} );
} );
$textarea.closest( 'form' ).submit( function () {

-- 
To view, visit https://gerrit.wikimedia.org/r/397580
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iadb9c131ca6730c20d4b166e686942f9b404e198
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: DLynch 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits