[MediaWiki-commits] [Gerrit] mediawiki...WikiLexicalData[master]: Use getter instead of property

2018-01-14 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/332043 )

Change subject: Use getter instead of property
..


Use getter instead of property

TextContent has the dedicated getter getNativeData() to access to the
object property mText, so let’s use it. I proposed to change the visibility
of the object property, so this extension would be broken if/when the
visibility is changed, but anyway it’s better to access through the getter.

Bug: T155298
Change-Id: I97a7c69a770844949bb4cf3de74b43dd85d4aaf6
---
M includes/api/owAddAnnotation.php
M includes/api/owAddDefinition.php
M includes/api/owAddSyntrans.php
M includes/api/owAddToCollection.php
4 files changed, 8 insertions(+), 8 deletions(-)

Approvals:
  Daniel Kinzler: Looks good to me, but someone else must approve
  Seb35: Looks good to me, but someone else must approve
  Kipcool: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/api/owAddAnnotation.php b/includes/api/owAddAnnotation.php
index d98e117..c8886dd 100644
--- a/includes/api/owAddAnnotation.php
+++ b/includes/api/owAddAnnotation.php
@@ -450,7 +450,7 @@
);
}
 
-   $text = $wikiText->mText;
+   $text = $wikiText->getNativeData();
 
// Check if the page is redirected,
// then adjust accordingly.
@@ -460,7 +460,7 @@
$csvWikiPageTitle = Title::newFromText( $redirectedText 
);
$csvWikiPage = new WikiPage ( $csvWikiPageTitle );
$wikiText = $csvWikiPage->getContent( Revision::RAW );
-   $text = $wikiText->mText;
+   $text = $wikiText->getNativeData();
}
 
$process = array (
diff --git a/includes/api/owAddDefinition.php b/includes/api/owAddDefinition.php
index 542c2f0..1cb5c00 100644
--- a/includes/api/owAddDefinition.php
+++ b/includes/api/owAddDefinition.php
@@ -132,7 +132,7 @@
) )
);
 
-   $text = $wikiText->mText;
+   $text = $wikiText->getNativeData();
 
// Check if the page is redirected,
// then adjust accordingly.
@@ -142,7 +142,7 @@
$csvWikiPageTitle = Title::newFromText( $redirectedText 
);
$csvWikiPage = new WikiPage ( $csvWikiPageTitle );
$wikiText = $csvWikiPage->getContent( Revision::RAW );
-   $text = $wikiText->mText;
+   $text = $wikiText->getNativeData();
}
 
$this->getResult()->addValue( null, $this->getModuleName(),
diff --git a/includes/api/owAddSyntrans.php b/includes/api/owAddSyntrans.php
index 6489956..6230769 100644
--- a/includes/api/owAddSyntrans.php
+++ b/includes/api/owAddSyntrans.php
@@ -172,7 +172,7 @@
) )
);
 
-   $text = $wikiText->mText;
+   $text = $wikiText->getNativeData();
 
// Check if the page is redirected,
// then adjust accordingly.
@@ -182,7 +182,7 @@
$csvWikiPageTitle = Title::newFromText( $redirectedText 
);
$csvWikiPage = new WikiPage ( $csvWikiPageTitle );
$wikiText = $csvWikiPage->getContent( Revision::RAW );
-   $text = $wikiText->mText;
+   $text = $wikiText->getNativeData();
}
 
$this->getResult()->addValue( null, $this->getModuleName(),
diff --git a/includes/api/owAddToCollection.php 
b/includes/api/owAddToCollection.php
index 138180b..9173a9c 100644
--- a/includes/api/owAddToCollection.php
+++ b/includes/api/owAddToCollection.php
@@ -139,7 +139,7 @@
) )
);
 
-   $text = $wikiText->mText;
+   $text = $wikiText->getNativeData();
 
// Check if the page is redirected,
// then adjust accordingly.
@@ -149,7 +149,7 @@
$csvWikiPageTitle = Title::newFromText( $redirectedText 
);
$csvWikiPage = new WikiPage ( $csvWikiPageTitle );
$wikiText = $csvWikiPage->getContent( Revision::RAW );
-   $text = $wikiText->mText;
+   $text = $wikiText->getNativeData();
}
 
$this->getResult()->addValue( null, $this->getModuleName(),

-- 
To view, visit https://gerrit.wikimedia.org/r/332043
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I97a7c69a770844949bb4cf3de74b43dd85d4aaf6
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikiLexicalData
Gerrit-Branch: master
Gerrit-Owner: Seb35

[MediaWiki-commits] [Gerrit] mediawiki...WikiLexicalData[master]: Use getter instead of property

2017-01-14 Thread Seb35 (Code Review) 
Seb35 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/332043 )

Change subject: Use getter instead of property
..

Use getter instead of property

TextContent has the dedicated getter getNativeData() to access to the
object property mText, so let’s use it. I proposed to change the visibility
of the object property, so this extension would be broken if/when the
visibility is changed, but anyway it’s better to access through the getter.

Bug: T155298
Change-Id: I97a7c69a770844949bb4cf3de74b43dd85d4aaf6
---
M includes/api/owAddAnnotation.php
M includes/api/owAddDefinition.php
M includes/api/owAddSyntrans.php
M includes/api/owAddToCollection.php
4 files changed, 8 insertions(+), 8 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiLexicalData 
refs/changes/43/332043/1

diff --git a/includes/api/owAddAnnotation.php b/includes/api/owAddAnnotation.php
index c354e1b..b32c8a3 100644
--- a/includes/api/owAddAnnotation.php
+++ b/includes/api/owAddAnnotation.php
@@ -478,7 +478,7 @@
);
}
 
-   $text = $wikiText->mText;
+   $text = $wikiText->getNativeData();
 
// Check if the page is redirected,
// then adjust accordingly.
@@ -488,7 +488,7 @@
$csvWikiPageTitle = Title::newFromText( $redirectedText 
);
$csvWikiPage = new WikiPage ( $csvWikiPageTitle );
$wikiText = $csvWikiPage->getContent( Revision::RAW );
-   $text = $wikiText->mText;
+   $text = $wikiText->getNativeData();
}
 
$process = array (
diff --git a/includes/api/owAddDefinition.php b/includes/api/owAddDefinition.php
index 90979b4..ce6f6d7 100644
--- a/includes/api/owAddDefinition.php
+++ b/includes/api/owAddDefinition.php
@@ -149,7 +149,7 @@
) )
);
 
-   $text = $wikiText->mText;
+   $text = $wikiText->getNativeData();
 
// Check if the page is redirected,
// then adjust accordingly.
@@ -159,7 +159,7 @@
$csvWikiPageTitle = Title::newFromText( $redirectedText 
);
$csvWikiPage = new WikiPage ( $csvWikiPageTitle );
$wikiText = $csvWikiPage->getContent( Revision::RAW );
-   $text = $wikiText->mText;
+   $text = $wikiText->getNativeData();
}
 
$this->getResult()->addValue( null, $this->getModuleName(),
diff --git a/includes/api/owAddSyntrans.php b/includes/api/owAddSyntrans.php
index 8deae41..365ebe7 100644
--- a/includes/api/owAddSyntrans.php
+++ b/includes/api/owAddSyntrans.php
@@ -192,7 +192,7 @@
) )
);
 
-   $text = $wikiText->mText;
+   $text = $wikiText->getNativeData();
 
// Check if the page is redirected,
// then adjust accordingly.
@@ -202,7 +202,7 @@
$csvWikiPageTitle = Title::newFromText( $redirectedText 
);
$csvWikiPage = new WikiPage ( $csvWikiPageTitle );
$wikiText = $csvWikiPage->getContent( Revision::RAW );
-   $text = $wikiText->mText;
+   $text = $wikiText->getNativeData();
}
 
$this->getResult()->addValue( null, $this->getModuleName(),
diff --git a/includes/api/owAddToCollection.php 
b/includes/api/owAddToCollection.php
index 477de84..8c6e69f 100644
--- a/includes/api/owAddToCollection.php
+++ b/includes/api/owAddToCollection.php
@@ -155,7 +155,7 @@
) )
);
 
-   $text = $wikiText->mText;
+   $text = $wikiText->getNativeData();
 
// Check if the page is redirected,
// then adjust accordingly.
@@ -165,7 +165,7 @@
$csvWikiPageTitle = Title::newFromText( $redirectedText 
);
$csvWikiPage = new WikiPage ( $csvWikiPageTitle );
$wikiText = $csvWikiPage->getContent( Revision::RAW );
-   $text = $wikiText->mText;
+   $text = $wikiText->getNativeData();
}
 
$this->getResult()->addValue( null, $this->getModuleName(),

-- 
To view, visit https://gerrit.wikimedia.org/r/332043
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I97a7c69a770844949bb4cf3de74b43dd85d4aaf6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiLexicalData
Gerrit-Branch: master
Gerrit-Owner: Seb35 

___
MediaWiki-commits mailing list