[MediaWiki-commits] [Gerrit] mediawiki...WikiLove[master]: Simplify by using api.parse from module 'mediawiki.api.parse'
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/385071 ) Change subject: Simplify by using api.parse from module 'mediawiki.api.parse' .. Simplify by using api.parse from module 'mediawiki.api.parse' Change-Id: I000c7e85e13de30d9203bae86b13696dc4153315 --- M extension.json M resources/ext.wikiLove.core.js 2 files changed, 7 insertions(+), 9 deletions(-) Approvals: Krinkle: Looks good to me, approved jenkins-bot: Verified diff --git a/extension.json b/extension.json index 9a4ba0e..274fe4c 100644 --- a/extension.json +++ b/extension.json @@ -216,6 +216,7 @@ ], "dependencies": [ "mediawiki.api", + "mediawiki.api.parse", "ext.wikiLove.defaultOptions", "jquery.ui.dialog", "mediawiki.ui.button", diff --git a/resources/ext.wikiLove.core.js b/resources/ext.wikiLove.core.js index 338fa9a..645db1a 100644 --- a/resources/ext.wikiLove.core.js +++ b/resources/ext.wikiLove.core.js @@ -560,16 +560,13 @@ */ doPreview: function ( wikitext ) { $( '#mw-wikilove-preview-spinner' ).fadeIn( 200 ); - api.post( { - 'action': 'parse', - 'contentmodel': 'wikitext', - 'text': wikitext, - 'prop': 'text', - 'disableeditsection': true, - 'pst': true + api.parse( wikitext, { + prop: 'text', + disableeditsection: true, + pst: true } ) - .done( function ( data ) { - $.wikiLove.showPreview( data.parse.text['*'] ); + .done( function ( html ) { + $.wikiLove.showPreview( html ); $( '#mw-wikilove-preview-spinner' ).fadeOut( 200 ); } ) .fail( function () { -- To view, visit https://gerrit.wikimedia.org/r/385071 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I000c7e85e13de30d9203bae86b13696dc4153315 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/WikiLove Gerrit-Branch: master Gerrit-Owner: Fomafix Gerrit-Reviewer: Krinkle Gerrit-Reviewer: Thiemo Mättig (WMDE) Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...WikiLove[master]: Simplify by using api.parse from module 'mediawiki.api.parse'
Fomafix has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385071 ) Change subject: Simplify by using api.parse from module 'mediawiki.api.parse' .. Simplify by using api.parse from module 'mediawiki.api.parse' Change-Id: I000c7e85e13de30d9203bae86b13696dc4153315 --- M extension.json M resources/ext.wikiLove.core.js 2 files changed, 7 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiLove refs/changes/71/385071/1 diff --git a/extension.json b/extension.json index 611ec8b..3362c01 100644 --- a/extension.json +++ b/extension.json @@ -213,6 +213,7 @@ ], "dependencies": [ "mediawiki.api", + "mediawiki.api.parse", "ext.wikiLove.defaultOptions", "jquery.ui.dialog", "mediawiki.ui.button", diff --git a/resources/ext.wikiLove.core.js b/resources/ext.wikiLove.core.js index bc5f8c5..0fc69b5 100644 --- a/resources/ext.wikiLove.core.js +++ b/resources/ext.wikiLove.core.js @@ -560,16 +560,13 @@ */ doPreview: function ( wikitext ) { $( '#mw-wikilove-preview-spinner' ).fadeIn( 200 ); - api.post( { - 'action': 'parse', - 'contentmodel': 'wikitext', - 'text': wikitext, - 'prop': 'text', - 'disableeditsection': true, - 'pst': true + api.parse( wikitext, { + prop: 'text', + disableeditsection: true, + pst: true } ) - .done( function ( data ) { - $.wikiLove.showPreview( data.parse.text['*'] ); + .done( function ( text ) { + $.wikiLove.showPreview( text ); $( '#mw-wikilove-preview-spinner' ).fadeOut( 200 ); } ) .fail( function () { -- To view, visit https://gerrit.wikimedia.org/r/385071 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I000c7e85e13de30d9203bae86b13696dc4153315 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikiLove Gerrit-Branch: master Gerrit-Owner: Fomafix ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits