[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Another attempt to fix jenkins

2017-12-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/398532 )

Change subject: Another attempt to fix jenkins
..


Another attempt to fix jenkins

Change-Id: I94b1552a4dec5231bcf287cab68654bf22b7d5c7
---
M client/tests/phpunit/includes/Hooks/EchoNotificationsHandlersTest.php
M lib/tests/phpunit/Changes/TestChanges.php
2 files changed, 11 insertions(+), 11 deletions(-)

Approvals:
  jenkins-bot: Verified
  Thiemo Kreuz (WMDE): Looks good to me, approved



diff --git 
a/client/tests/phpunit/includes/Hooks/EchoNotificationsHandlersTest.php 
b/client/tests/phpunit/includes/Hooks/EchoNotificationsHandlersTest.php
index 1b13ffc..fe9d416 100644
--- a/client/tests/phpunit/includes/Hooks/EchoNotificationsHandlersTest.php
+++ b/client/tests/phpunit/includes/Hooks/EchoNotificationsHandlersTest.php
@@ -151,28 +151,28 @@
$settings->setSetting( 'sendEchoNotification', true );
$handlers = $this->getHandlers( $settings );
 
-   Title::newFromText( 'Dummy2' )->resetArticleID( 0 );
+   Title::newFromText( 'Duummy2' )->resetArticleID( 0 );
$this->assertFalse(
$handlers->doWikibaseHandleChange( $changeDe ),
-   "Failed asserting that 'Dummy' does not create an event"
+   "Failed asserting that 'Duummy' does not create an 
event"
);
 
-   $this->insertPage( 'Dummy2' );
+   $this->insertPage( 'Duummy2' );
$this->assertFalse(
$handlers->doWikibaseHandleChange( $changeDe ),
-   "Failed asserting that 'Dummy2' does not create an 
event"
+   "Failed asserting that 'Duummy2' does not create an 
event"
);
 
-   $this->insertPage( 'Dummy', '#REDIRECT [[Dummy2]]' );
+   $this->insertPage( 'Duummy', '#REDIRECT [[Duummy2]]' );
$this->assertFalse(
$handlers->doWikibaseHandleChange( $changeDe ),
-   "Failed asserting that 'Dummy2' redirected to by 
'Dummy' does not create an event"
+   "Failed asserting that 'Duummy2' redirected to by 
'Duummy' does not create an event"
);
 
-   $this->insertPage( 'Dummy' );
+   $this->insertPage( 'Duummy' );
$this->assertTrue(
$handlers->doWikibaseHandleChange( $changeDe ),
-   "Failed asserting that 'Dummy2' creates an event"
+   "Failed asserting that 'Duummy2' creates an event"
);
}
 
diff --git a/lib/tests/phpunit/Changes/TestChanges.php 
b/lib/tests/phpunit/Changes/TestChanges.php
index ec0024d..ad8c293 100644
--- a/lib/tests/phpunit/Changes/TestChanges.php
+++ b/lib/tests/phpunit/Changes/TestChanges.php
@@ -74,7 +74,7 @@
// -
 
$new = new Item( new ItemId( 'Q100' ) );
-   $new->getSiteLinkList()->addNewSiteLink( 'dewiki', 
'Dummy' );
+   $new->getSiteLinkList()->addNewSiteLink( 'dewiki', 
'Duummy' );
$changes['set-dewiki-sitelink'] = 
$changeFactory->newFromUpdate( EntityChange::UPDATE, $old, $new );
$old = $new->copy();
 
@@ -86,13 +86,13 @@
$new = new Item( new ItemId( 'Q100' ) );
 
$new->getSiteLinkList()->addNewSiteLink( 'enwiki', 
'Emmy' );
-   $new->getSiteLinkList()->addNewSiteLink( 'dewiki', 
'Dummy' );
+   $new->getSiteLinkList()->addNewSiteLink( 'dewiki', 
'Duummy' );
 
$changes['change-sitelink-order'] = 
$changeFactory->newFromUpdate( EntityChange::UPDATE, $old, $new );
$old = $new->copy();
 
// -
-   $new->getSiteLinkList()->setNewSiteLink( 'dewiki', 
'Dummy2' );
+   $new->getSiteLinkList()->setNewSiteLink( 'dewiki', 
'Duummy2' );
$changes['change-dewiki-sitelink'] = 
$changeFactory->newFromUpdate( EntityChange::UPDATE, $old, $new );
$old = $new->copy();
 

-- 
To view, visit https://gerrit.wikimedia.org/r/398532
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I94b1552a4dec5231bcf287cab68654bf22b7d5c7
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup 
Gerrit-Reviewer: Ladsgroup 
Gerrit-Reviewer: Thiemo Kreuz (WMDE) 
Gerrit-Reviewer: WMDE-leszek 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Another attempt to fix jenkins

2017-12-15 Thread Ladsgroup (Code Review)
Ladsgroup has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398532 )

Change subject: Another attempt to fix jenkins
..

Another attempt to fix jenkins

Change-Id: I94b1552a4dec5231bcf287cab68654bf22b7d5c7
---
M client/tests/phpunit/includes/Hooks/EchoNotificationsHandlersTest.php
M lib/tests/phpunit/Changes/TestChanges.php
2 files changed, 7 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/32/398532/1

diff --git 
a/client/tests/phpunit/includes/Hooks/EchoNotificationsHandlersTest.php 
b/client/tests/phpunit/includes/Hooks/EchoNotificationsHandlersTest.php
index 1b13ffc..23ba113 100644
--- a/client/tests/phpunit/includes/Hooks/EchoNotificationsHandlersTest.php
+++ b/client/tests/phpunit/includes/Hooks/EchoNotificationsHandlersTest.php
@@ -151,28 +151,28 @@
$settings->setSetting( 'sendEchoNotification', true );
$handlers = $this->getHandlers( $settings );
 
-   Title::newFromText( 'Dummy2' )->resetArticleID( 0 );
+   Title::newFromText( 'Duummy2' )->resetArticleID( 0 );
$this->assertFalse(
$handlers->doWikibaseHandleChange( $changeDe ),
"Failed asserting that 'Dummy' does not create an event"
);
 
-   $this->insertPage( 'Dummy2' );
+   $this->insertPage( 'Duummy2' );
$this->assertFalse(
$handlers->doWikibaseHandleChange( $changeDe ),
-   "Failed asserting that 'Dummy2' does not create an 
event"
+   "Failed asserting that 'Duummy2' does not create an 
event"
);
 
-   $this->insertPage( 'Dummy', '#REDIRECT [[Dummy2]]' );
+   $this->insertPage( 'Dummy', '#REDIRECT [[Duummy2]]' );
$this->assertFalse(
$handlers->doWikibaseHandleChange( $changeDe ),
-   "Failed asserting that 'Dummy2' redirected to by 
'Dummy' does not create an event"
+   "Failed asserting that 'Duummy2' redirected to by 
'Dummy' does not create an event"
);
 
$this->insertPage( 'Dummy' );
$this->assertTrue(
$handlers->doWikibaseHandleChange( $changeDe ),
-   "Failed asserting that 'Dummy2' creates an event"
+   "Failed asserting that 'Duummy2' creates an event"
);
}
 
diff --git a/lib/tests/phpunit/Changes/TestChanges.php 
b/lib/tests/phpunit/Changes/TestChanges.php
index ec0024d..7144879 100644
--- a/lib/tests/phpunit/Changes/TestChanges.php
+++ b/lib/tests/phpunit/Changes/TestChanges.php
@@ -92,7 +92,7 @@
$old = $new->copy();
 
// -
-   $new->getSiteLinkList()->setNewSiteLink( 'dewiki', 
'Dummy2' );
+   $new->getSiteLinkList()->setNewSiteLink( 'dewiki', 
'Duummy2' );
$changes['change-dewiki-sitelink'] = 
$changeFactory->newFromUpdate( EntityChange::UPDATE, $old, $new );
$old = $new->copy();
 

-- 
To view, visit https://gerrit.wikimedia.org/r/398532
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I94b1552a4dec5231bcf287cab68654bf22b7d5c7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits