[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Fix PropertyOrderProvider type hint in top level factory

2016-12-13 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/326986 )

Change subject: Fix PropertyOrderProvider type hint in top level factory
..


Fix PropertyOrderProvider type hint in top level factory

Bug: T150788
Change-Id: Id665385c3beace56f93520dbc432717d6a56057e
---
M client/includes/WikibaseClient.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Hoo man: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/client/includes/WikibaseClient.php 
b/client/includes/WikibaseClient.php
index 9f0a255..41f5934 100644
--- a/client/includes/WikibaseClient.php
+++ b/client/includes/WikibaseClient.php
@@ -82,6 +82,7 @@
 use Wikibase\Lib\Store\EntityNamespaceLookup;
 use Wikibase\Lib\Store\FallbackPropertyOrderProvider;
 use Wikibase\Lib\Store\HttpUrlPropertyOrderProvider;
+use Wikibase\Lib\Store\PropertyOrderProvider;
 use Wikibase\Lib\Store\WikiPagePropertyOrderProvider;
 use Wikibase\Lib\WikibaseSnakFormatterBuilders;
 use Wikibase\Lib\WikibaseValueFormatterBuilders;
@@ -1202,7 +1203,7 @@
}
 
/**
-* @return CachingPropertyOrderProvider
+* @return PropertyOrderProvider
 */
public function getPropertyOrderProvider() {
if ( $this->propertyOrderProvider === null ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/326986
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id665385c3beace56f93520dbc432717d6a56057e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: Aleksey Bekh-Ivanov (WMDE) 
Gerrit-Reviewer: Hoo man 
Gerrit-Reviewer: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Fix PropertyOrderProvider type hint in top level factory

2016-12-13 Thread WMDE 
Thiemo Mättig (WMDE) has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/326986 )

Change subject: Fix PropertyOrderProvider type hint in top level factory
..

Fix PropertyOrderProvider type hint in top level factory

Bug: T150788
Change-Id: Id665385c3beace56f93520dbc432717d6a56057e
---
M client/includes/WikibaseClient.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/86/326986/1

diff --git a/client/includes/WikibaseClient.php 
b/client/includes/WikibaseClient.php
index 9f0a255..41f5934 100644
--- a/client/includes/WikibaseClient.php
+++ b/client/includes/WikibaseClient.php
@@ -82,6 +82,7 @@
 use Wikibase\Lib\Store\EntityNamespaceLookup;
 use Wikibase\Lib\Store\FallbackPropertyOrderProvider;
 use Wikibase\Lib\Store\HttpUrlPropertyOrderProvider;
+use Wikibase\Lib\Store\PropertyOrderProvider;
 use Wikibase\Lib\Store\WikiPagePropertyOrderProvider;
 use Wikibase\Lib\WikibaseSnakFormatterBuilders;
 use Wikibase\Lib\WikibaseValueFormatterBuilders;
@@ -1202,7 +1203,7 @@
}
 
/**
-* @return CachingPropertyOrderProvider
+* @return PropertyOrderProvider
 */
public function getPropertyOrderProvider() {
if ( $this->propertyOrderProvider === null ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/326986
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id665385c3beace56f93520dbc432717d6a56057e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits