[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Move SiteLinkCommentCreator to RecentChanges namespace
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/332337 )
Change subject: Move SiteLinkCommentCreator to RecentChanges namespace
..
Move SiteLinkCommentCreator to RecentChanges namespace
Two reasons to touch this: Make the namespace PSR-4 compatible. And
move it to the more specific "RecentChanges" namespace, because this
is used only once anyway.
Change-Id: I96921d652481deea3866c120735b0c98b56b35d0
---
M client/includes/RecentChanges/RecentChangeFactory.php
R client/includes/RecentChanges/SiteLinkCommentCreator.php
M client/includes/WikibaseClient.php
M client/tests/phpunit/includes/RecentChanges/RecentChangeFactoryTest.php
R client/tests/phpunit/includes/RecentChanges/SiteLinkCommentCreatorTest.php
5 files changed, 11 insertions(+), 19 deletions(-)
Approvals:
WMDE-leszek: Looks good to me, approved
Ladsgroup: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/client/includes/RecentChanges/RecentChangeFactory.php
b/client/includes/RecentChanges/RecentChangeFactory.php
index 316c645..bee44f0 100644
--- a/client/includes/RecentChanges/RecentChangeFactory.php
+++ b/client/includes/RecentChanges/RecentChangeFactory.php
@@ -9,7 +9,6 @@
use Title;
use Wikibase\EntityChange;
use Wikibase\ItemChange;
-use Wikibase\SiteLinkCommentCreator;
use Wikimedia\Assert\Assert;
/**
diff --git a/client/includes/SiteLinkCommentCreator.php
b/client/includes/RecentChanges/SiteLinkCommentCreator.php
similarity index 99%
rename from client/includes/SiteLinkCommentCreator.php
rename to client/includes/RecentChanges/SiteLinkCommentCreator.php
index da10b96..f935ec3 100644
--- a/client/includes/SiteLinkCommentCreator.php
+++ b/client/includes/RecentChanges/SiteLinkCommentCreator.php
@@ -1,6 +1,6 @@
getContentLanguage(),
- $this->getSiteLinkCommentCreator()
- );
- }
-
- /**
-* @return SiteLinkCommentCreator
-*/
- private function getSiteLinkCommentCreator() {
- return new SiteLinkCommentCreator(
- $this->getContentLanguage(),
- $this->siteLookup,
- $this->settings->getSetting( 'siteGlobalID' )
+ new SiteLinkCommentCreator(
+ $this->getContentLanguage(),
+ $this->siteLookup,
+ $this->settings->getSetting( 'siteGlobalID' )
+ )
);
}
diff --git
a/client/tests/phpunit/includes/RecentChanges/RecentChangeFactoryTest.php
b/client/tests/phpunit/includes/RecentChanges/RecentChangeFactoryTest.php
index 893ab19..d94db33 100644
--- a/client/tests/phpunit/includes/RecentChanges/RecentChangeFactoryTest.php
+++ b/client/tests/phpunit/includes/RecentChanges/RecentChangeFactoryTest.php
@@ -14,7 +14,7 @@
use Wikibase\DataModel\Services\Diff\ItemDiff;
use Wikibase\EntityChange;
use Wikibase\ItemChange;
-use Wikibase\SiteLinkCommentCreator;
+use Wikibase\Client\RecentChanges\SiteLinkCommentCreator;
/**
* @covers Wikibase\Client\RecentChanges\RecentChangeFactory
diff --git a/client/tests/phpunit/includes/SiteLinkCommentCreatorTest.php
b/client/tests/phpunit/includes/RecentChanges/SiteLinkCommentCreatorTest.php
similarity index 97%
rename from client/tests/phpunit/includes/SiteLinkCommentCreatorTest.php
rename to
client/tests/phpunit/includes/RecentChanges/SiteLinkCommentCreatorTest.php
index 98f2ad0..da9b8f9 100644
--- a/client/tests/phpunit/includes/SiteLinkCommentCreatorTest.php
+++ b/client/tests/phpunit/includes/RecentChanges/SiteLinkCommentCreatorTest.php
@@ -1,6 +1,6 @@
https://gerrit.wikimedia.org/r/332337
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96921d652481deea3866c120735b0c98b56b35d0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE)
Gerrit-Reviewer: Ladsgroup
Gerrit-Reviewer: WMDE-leszek
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Move SiteLinkCommentCreator to RecentChanges namespace
Thiemo Mättig (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/332337 )
Change subject: Move SiteLinkCommentCreator to RecentChanges namespace
..
Move SiteLinkCommentCreator to RecentChanges namespace
Two reasons to touch this: Make the namespace PSR-4 compatible. And
move it to the more specific "RecentChanges" namespace, because this
is used only once anyway.
Change-Id: I96921d652481deea3866c120735b0c98b56b35d0
---
M client/includes/RecentChanges/RecentChangeFactory.php
R client/includes/RecentChanges/SiteLinkCommentCreator.php
M client/includes/WikibaseClient.php
M client/tests/phpunit/includes/RecentChanges/RecentChangeFactoryTest.php
R client/tests/phpunit/includes/RecentChanges/SiteLinkCommentCreatorTest.php
5 files changed, 11 insertions(+), 19 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/37/332337/1
diff --git a/client/includes/RecentChanges/RecentChangeFactory.php
b/client/includes/RecentChanges/RecentChangeFactory.php
index 316c645..bee44f0 100644
--- a/client/includes/RecentChanges/RecentChangeFactory.php
+++ b/client/includes/RecentChanges/RecentChangeFactory.php
@@ -9,7 +9,6 @@
use Title;
use Wikibase\EntityChange;
use Wikibase\ItemChange;
-use Wikibase\SiteLinkCommentCreator;
use Wikimedia\Assert\Assert;
/**
diff --git a/client/includes/SiteLinkCommentCreator.php
b/client/includes/RecentChanges/SiteLinkCommentCreator.php
similarity index 99%
rename from client/includes/SiteLinkCommentCreator.php
rename to client/includes/RecentChanges/SiteLinkCommentCreator.php
index da10b96..f935ec3 100644
--- a/client/includes/SiteLinkCommentCreator.php
+++ b/client/includes/RecentChanges/SiteLinkCommentCreator.php
@@ -1,6 +1,6 @@
getContentLanguage(),
- $this->getSiteLinkCommentCreator()
- );
- }
-
- /**
-* @return SiteLinkCommentCreator
-*/
- private function getSiteLinkCommentCreator() {
- return new SiteLinkCommentCreator(
- $this->getContentLanguage(),
- $this->siteLookup,
- $this->settings->getSetting( 'siteGlobalID' )
+ new SiteLinkCommentCreator(
+ $this->getContentLanguage(),
+ $this->siteLookup,
+ $this->settings->getSetting( 'siteGlobalID' )
+ )
);
}
diff --git
a/client/tests/phpunit/includes/RecentChanges/RecentChangeFactoryTest.php
b/client/tests/phpunit/includes/RecentChanges/RecentChangeFactoryTest.php
index 893ab19..d94db33 100644
--- a/client/tests/phpunit/includes/RecentChanges/RecentChangeFactoryTest.php
+++ b/client/tests/phpunit/includes/RecentChanges/RecentChangeFactoryTest.php
@@ -14,7 +14,7 @@
use Wikibase\DataModel\Services\Diff\ItemDiff;
use Wikibase\EntityChange;
use Wikibase\ItemChange;
-use Wikibase\SiteLinkCommentCreator;
+use Wikibase\Client\RecentChanges\SiteLinkCommentCreator;
/**
* @covers Wikibase\Client\RecentChanges\RecentChangeFactory
diff --git a/client/tests/phpunit/includes/SiteLinkCommentCreatorTest.php
b/client/tests/phpunit/includes/RecentChanges/SiteLinkCommentCreatorTest.php
similarity index 97%
rename from client/tests/phpunit/includes/SiteLinkCommentCreatorTest.php
rename to
client/tests/phpunit/includes/RecentChanges/SiteLinkCommentCreatorTest.php
index 98f2ad0..da9b8f9 100644
--- a/client/tests/phpunit/includes/SiteLinkCommentCreatorTest.php
+++ b/client/tests/phpunit/includes/RecentChanges/SiteLinkCommentCreatorTest.php
@@ -1,6 +1,6 @@
https://gerrit.wikimedia.org/r/332337
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I96921d652481deea3866c120735b0c98b56b35d0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE)
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
