[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Use prop instead of removeAttr

2017-08-10 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371026 )

Change subject: Use prop instead of removeAttr
..


Use prop instead of removeAttr

Bug: T169385
Change-Id: I683ec23e12afaade0463c55657b0808c0968a1dd
---
M client/resources/jquery.wikibase/jquery.wikibase.linkitem.js
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/client/resources/jquery.wikibase/jquery.wikibase.linkitem.js 
b/client/resources/jquery.wikibase/jquery.wikibase.linkitem.js
index 8b99bd0..6538b6c 100644
--- a/client/resources/jquery.wikibase/jquery.wikibase.linkitem.js
+++ b/client/resources/jquery.wikibase/jquery.wikibase.linkitem.js
@@ -279,7 +279,7 @@
apiUrl = $( '#wbclient-linkItem-site' 
).siteselector( 'getSelectedSite' ).getApi();
} catch ( e ) {
// Invalid input (likely incomplete). Disable 
the page input an re-disable to button
-   $page.attr( 'disabled', 'disabled' );
+   $page.prop( 'disabled', true );
this.$goButton.button( 'disable' );
return;
}
@@ -288,7 +288,7 @@
// input element. Furthermore, we remove the old 
suggestor (if there's one) and create a new
// one working on the right wiki.
$page
-   .removeAttr( 'disabled' )
+   .prop( 'disabled', false )
.suggester( {
source: function ( term ) {
var deferred = $.Deferred();
@@ -330,9 +330,9 @@
.attr( {
name: 'wbclient-linkItem-page',
id: 'wbclient-linkItem-page',
-   disabled: 'disabled',
'class': 'wbclient-linkItem-input'
} )
+   .prop( 'disabled', true )
.on( 'eachchange', function () {
// Enable the button if the field has a 
value
self.$goButton.button( $( this ).val() 
=== '' ? 'disable' : 'enable' );

-- 
To view, visit https://gerrit.wikimedia.org/r/371026
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I683ec23e12afaade0463c55657b0808c0968a1dd
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Alex Monk 
Gerrit-Reviewer: Hoo man 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Use prop instead of removeAttr

2017-08-10 Thread Alex Monk (Code Review) 
Alex Monk has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371026 )

Change subject: Use prop instead of removeAttr
..

Use prop instead of removeAttr

Change-Id: I683ec23e12afaade0463c55657b0808c0968a1dd
---
M client/resources/jquery.wikibase/jquery.wikibase.linkitem.js
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/26/371026/1

diff --git a/client/resources/jquery.wikibase/jquery.wikibase.linkitem.js 
b/client/resources/jquery.wikibase/jquery.wikibase.linkitem.js
index 8b99bd0..6538b6c 100644
--- a/client/resources/jquery.wikibase/jquery.wikibase.linkitem.js
+++ b/client/resources/jquery.wikibase/jquery.wikibase.linkitem.js
@@ -279,7 +279,7 @@
apiUrl = $( '#wbclient-linkItem-site' 
).siteselector( 'getSelectedSite' ).getApi();
} catch ( e ) {
// Invalid input (likely incomplete). Disable 
the page input an re-disable to button
-   $page.attr( 'disabled', 'disabled' );
+   $page.prop( 'disabled', true );
this.$goButton.button( 'disable' );
return;
}
@@ -288,7 +288,7 @@
// input element. Furthermore, we remove the old 
suggestor (if there's one) and create a new
// one working on the right wiki.
$page
-   .removeAttr( 'disabled' )
+   .prop( 'disabled', false )
.suggester( {
source: function ( term ) {
var deferred = $.Deferred();
@@ -330,9 +330,9 @@
.attr( {
name: 'wbclient-linkItem-page',
id: 'wbclient-linkItem-page',
-   disabled: 'disabled',
'class': 'wbclient-linkItem-input'
} )
+   .prop( 'disabled', true )
.on( 'eachchange', function () {
// Enable the button if the field has a 
value
self.$goButton.button( $( this ).val() 
=== '' ? 'disable' : 'enable' );

-- 
To view, visit https://gerrit.wikimedia.org/r/371026
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I683ec23e12afaade0463c55657b0808c0968a1dd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Alex Monk 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits