MtDu has uploaded a new change for review.
https://gerrit.wikimedia.org/r/324892
Change subject: Fix all jslint errors
......................................................................
Fix all jslint errors
Bug: T96149
Change-Id: Ia2bbbc5aa1ce887d8bc25128894ffe30589725e7
---
M extensions/PropertySuggester/modules/ext.PropertySuggester.EntitySelector.js
1 file changed, 9 insertions(+), 17 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikidata
refs/changes/92/324892/1
diff --git
a/extensions/PropertySuggester/modules/ext.PropertySuggester.EntitySelector.js
b/extensions/PropertySuggester/modules/ext.PropertySuggester.EntitySelector.js
index 2cd33c3..4b65e1b 100644
---
a/extensions/PropertySuggester/modules/ext.PropertySuggester.EntitySelector.js
+++
b/extensions/PropertySuggester/modules/ext.PropertySuggester.EntitySelector.js
@@ -32,9 +32,7 @@
this._oldCreate.apply( this, arguments );
var focusHandler = function( event ) {
- if ( self._useSuggester()
- && self.element.val() === ''
- && !self.options.menu.element.is(
':visible' )
+ if ( self._useSuggester() && self.element.val()
=== '' && !self.options.menu.element.is( ':visible' )
) {
self.options.minTermLength = 0;
self._cache = {}; // is done in the
entityselector on eachchange too
@@ -70,9 +68,7 @@
context: this._getPropertyContext(),
format: 'json',
language: this.options.language,
- 'continue': this._cache.term === term
&& this._cache.nextSuggestionOffset
- ?
this._cache.nextSuggestionOffset
- : 0
+ 'continue': this._cache.term === term
&& this._cache.nextSuggestionOffset ? this._cache.nextSuggestionOffset : 0
};
if ( data.context === 'item' ) {
@@ -101,15 +97,14 @@
* @return {wikibase.Entity|null}
*/
_getEntity: function() {
+ var $entityView;
try {
- var $entityView = this.element.closest(
':wikibase-entityview' );
+ $entityView = this.element.closest(
':wikibase-entityview' );
} catch ( ex ) {
return null;
}
- return $entityView.length > 0
- ? $entityView.data( 'entityview' ).option(
'value' )
- : null;
+ return $entityView.length > 0 ? $entityView.data(
'entityview' ).option( 'value' ) : null;
},
/**
@@ -119,15 +114,14 @@
* @return {string|null}
*/
_getPropertyId: function() {
+ var $statementview;
try {
- var $statementview = this.element.closest(
':wikibase-statementview' );
+ $statementview = this.element.closest(
':wikibase-statementview' );
} catch ( ex ) {
return null;
}
- var statement = $statementview.length > 0
- ? $statementview.data( 'statementview'
).option( 'value' )
- : null;
+ var statement = $statementview.length > 0 ?
$statementview.data( 'statementview' ).option( 'value' ) : null;
return statement ?
statement.getClaim().getMainSnak().getPropertyId() : null;
},
@@ -183,9 +177,7 @@
*/
_isInNewStatementView: function() {
var $statementview = this.element.closest(
':wikibase-statementview' ),
- value = $statementview.length > 0
- ? $statementview.data( 'statementview'
).option( 'value' )
- : null;
+ value = $statementview.length > 0 ?
$statementview.data( 'statementview' ).option( 'value' ) : null;
return !value;
}
--
To view, visit https://gerrit.wikimedia.org/r/324892
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2bbbc5aa1ce887d8bc25128894ffe30589725e7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikidata
Gerrit-Branch: master
Gerrit-Owner: MtDu <justin.d...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
