[MediaWiki-commits] [Gerrit] mediawiki...ZeroPortal[master]: Document why ApiBase is overridden and add isInternal member

2017-10-23 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/386014 )

Change subject: Document why ApiBase is overridden and add isInternal member
..


Document why ApiBase is overridden and add isInternal member

Bug: T91456
Change-Id: I94cc6e9bc9da9ed0668aa42d4ce3f65a2dd40ba4
---
M includes/ApiZeroPortal.php
1 file changed, 11 insertions(+), 1 deletion(-)

Approvals:
  Yurik: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/ApiZeroPortal.php b/includes/ApiZeroPortal.php
index 83def69..0d0a09f 100644
--- a/includes/ApiZeroPortal.php
+++ b/includes/ApiZeroPortal.php
@@ -14,7 +14,11 @@
 use ZeroBanner\ApiRawJsonPrinter;
 use ZeroBanner\ZeroConfig;
 
-/** @noinspection PhpInconsistentReturnPointsInspection */
+/** @noinspection PhpInconsistentReturnPointsInspection
+ * This class extends ApiBase in order to serve Wikipedia Zero
+ * configuration management portal experiences and ease the
+ * scheduled jobs synchronizing mobile operator IP addresses.
+ */
 class ApiZeroPortal extends ApiBase {
 
/**
@@ -365,4 +369,10 @@
}
}
 
+   /**
+* @inheritDoc
+*/
+   public function isInternal() {
+   return true;
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/386014
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I94cc6e9bc9da9ed0668aa42d4ce3f65a2dd40ba4
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/ZeroPortal
Gerrit-Branch: master
Gerrit-Owner: Dr0ptp4kt 
Gerrit-Reviewer: Anomie 
Gerrit-Reviewer: BBlack 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: Joewalsh 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: Yurik 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ZeroPortal[master]: Document why ApiBase is overridden and add isInternal member

2017-10-23 Thread Dr0ptp4kt (Code Review) 
Dr0ptp4kt has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386014 )

Change subject: Document why ApiBase is overridden and add isInternal member
..

Document why ApiBase is overridden and add isInternal member

Bug T91456

Change-Id: I94cc6e9bc9da9ed0668aa42d4ce3f65a2dd40ba4
---
M includes/ApiZeroPortal.php
1 file changed, 11 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ZeroPortal 
refs/changes/14/386014/1

diff --git a/includes/ApiZeroPortal.php b/includes/ApiZeroPortal.php
index 83def69..0d0a09f 100644
--- a/includes/ApiZeroPortal.php
+++ b/includes/ApiZeroPortal.php
@@ -14,7 +14,11 @@
 use ZeroBanner\ApiRawJsonPrinter;
 use ZeroBanner\ZeroConfig;
 
-/** @noinspection PhpInconsistentReturnPointsInspection */
+/** @noinspection PhpInconsistentReturnPointsInspection
+ * This class extends ApiBase in order to serve Wikipedia Zero
+ * configuration management portal experiences and ease the
+ * scheduled jobs synchronizing mobile operator IP addresses.
+ */
 class ApiZeroPortal extends ApiBase {
 
/**
@@ -365,4 +369,10 @@
}
}
 
+   /**
+* @inheritDoc
+*/
+   public function isInternal() {
+   return true;
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/386014
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I94cc6e9bc9da9ed0668aa42d4ce3f65a2dd40ba4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ZeroPortal
Gerrit-Branch: master
Gerrit-Owner: Dr0ptp4kt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits